kernel menuconfig broken?

kernel menuconfig broken?

[Andreas Müller]

Hi

When running bitbake -cmenuconfig virtual/kernel I get a flood of

undefined reference errors. Am I alone here?

Cheers

Andreas

Re: kernel menuconfig broken?

[Trevor Woerner]

On Sun 2018-04-01 @ 11:49:58 PM, Andreas Müller wrote:
> When running bitbake -cmenuconfig virtual/kernel I get a flood of
> undefined reference errors. Am I alone here?

Sadly, I think you might be.

	$ bitbake virtual/kernel -c menuconfig

works fine for me.

I assume you're doing this for something RaspberryPi-ish?

	Build Configuration:
	BB_VERSION           = "1.37.0"
	BUILD_SYS            = "x86_64-linux"
	NATIVELSBSTRING      = "opensuse-42.3"
	TARGET_SYS           = "arm-oe-linux-gnueabi"
	MACHINE              = "raspberrypi3"
	DISTRO               = "nodistro"
	DISTRO_VERSION       = "nodistro.0"
	TUNE_FEATURES        = "arm armv7ve vfp thumb neon vfpv4 callconvention-hard cortexa7"
	TARGET_FPU           = "hard"
	meta-raspberrypi     = "master:63e53f919089027259a513dc2cd4b140789bf1a3"
	meta                 = "master:4cedddb83623c79980b354642dfeaf78218ca4b7"
	meta-oe              
	meta-gnome           
	meta-python          
	meta-networking      
	meta-multimedia      = "master:b9d1d8718834f7287e5a65373b952cbfe9ce83fe"
	meta-qt5             = "master:e60e849de1158c879bd2c150fe79b207cdac031a"
	meta-qt5-extra       = "master:a0cf057b2f335e8d2be9180f20770773334ec209"
	meta-realtime        = "master:250bc6eaa47e550c1db5e2b0ebd42d86ee43650e"
	meta-browser         = "master:d1c902440cba26a9d1271cfb914633c68ee3791c"

Re: kernel menuconfig broken?

[Andreas Müller]

On Mon, Apr 2, 2018 at 11:57 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> On Sun 2018-04-01 @ 11:49:58 PM, Andreas Müller wrote:
>> When running bitbake -cmenuconfig virtual/kernel I get a flood of
>> undefined reference errors. Am I alone here?
>
> Sadly, I think you might be.
>
>         $ bitbake virtual/kernel -c menuconfig
>
> works fine for me.
>
> I assume you're doing this for something RaspberryPi-ish?
>
>         Build Configuration:
>         BB_VERSION           = "1.37.0"
>         BUILD_SYS            = "x86_64-linux"
>         NATIVELSBSTRING      = "opensuse-42.3"
>         TARGET_SYS           = "arm-oe-linux-gnueabi"
>         MACHINE              = "raspberrypi3"
>         DISTRO               = "nodistro"
>         DISTRO_VERSION       = "nodistro.0"
>         TUNE_FEATURES        = "arm armv7ve vfp thumb neon vfpv4 callconvention-hard cortexa7"
>         TARGET_FPU           = "hard"
>         meta-raspberrypi     = "master:63e53f919089027259a513dc2cd4b140789bf1a3"
>         meta                 = "master:4cedddb83623c79980b354642dfeaf78218ca4b7"
>         meta-oe
>         meta-gnome
>         meta-python
>         meta-networking
>         meta-multimedia      = "master:b9d1d8718834f7287e5a65373b952cbfe9ce83fe"
>         meta-qt5             = "master:e60e849de1158c879bd2c150fe79b207cdac031a"
>         meta-qt5-extra       = "master:a0cf057b2f335e8d2be9180f20770773334ec209"
>         meta-realtime        = "master:250bc6eaa47e550c1db5e2b0ebd42d86ee43650e"
>         meta-browser         = "master:d1c902440cba26a9d1271cfb914633c68ee3791c"
OK I found that I am not alone [1] and followed the suggestion to
install ncurses-devel. Strange: it install ncurses-libs x86_64. Now I
have back menuconfig but it looks horrible: All framing chars are
displayed as '@'. If I remember correct there was such an issue long
lime ago.

However it is not beautiful but I can work with it.

[1] https://github.com/crops/poky-container/issues/17

Andreas

Re: kernel menuconfig broken?

[Cal Sullivan]

Fixed by this hopefully?

https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=d5075b648b06d3120fc7e4c47ccda3d620754590

Thanks,
Cal

On 04/12/2018 01:28 PM, Andreas Müller wrote:
> On Mon, Apr 2, 2018 at 11:57 PM, Trevor Woerner <twoerner@gmail.com> wrote:
>> On Sun 2018-04-01 @ 11:49:58 PM, Andreas Müller wrote:
>>> When running bitbake -cmenuconfig virtual/kernel I get a flood of
>>> undefined reference errors. Am I alone here?
>> Sadly, I think you might be.
>>
>>          $ bitbake virtual/kernel -c menuconfig
>>
>> works fine for me.
>>
>> I assume you're doing this for something RaspberryPi-ish?
>>
>>          Build Configuration:
>>          BB_VERSION           = "1.37.0"
>>          BUILD_SYS            = "x86_64-linux"
>>          NATIVELSBSTRING      = "opensuse-42.3"
>>          TARGET_SYS           = "arm-oe-linux-gnueabi"
>>          MACHINE              = "raspberrypi3"
>>          DISTRO               = "nodistro"
>>          DISTRO_VERSION       = "nodistro.0"
>>          TUNE_FEATURES        = "arm armv7ve vfp thumb neon vfpv4 callconvention-hard cortexa7"
>>          TARGET_FPU           = "hard"
>>          meta-raspberrypi     = "master:63e53f919089027259a513dc2cd4b140789bf1a3"
>>          meta                 = "master:4cedddb83623c79980b354642dfeaf78218ca4b7"
>>          meta-oe
>>          meta-gnome
>>          meta-python
>>          meta-networking
>>          meta-multimedia      = "master:b9d1d8718834f7287e5a65373b952cbfe9ce83fe"
>>          meta-qt5             = "master:e60e849de1158c879bd2c150fe79b207cdac031a"
>>          meta-qt5-extra       = "master:a0cf057b2f335e8d2be9180f20770773334ec209"
>>          meta-realtime        = "master:250bc6eaa47e550c1db5e2b0ebd42d86ee43650e"
>>          meta-browser         = "master:d1c902440cba26a9d1271cfb914633c68ee3791c"
> OK I found that I am not alone [1] and followed the suggestion to
> install ncurses-devel. Strange: it install ncurses-libs x86_64. Now I
> have back menuconfig but it looks horrible: All framing chars are
> displayed as '@'. If I remember correct there was such an issue long
> lime ago.
>
> However it is not beautiful but I can work with it.
>
> [1] https://github.com/crops/poky-container/issues/17
>
> Andreas

Re: kernel menuconfig broken?

[Andreas Müller]

On Thu, Apr 12, 2018 at 11:19 PM, Cal Sullivan
<california.l.sullivan@intel.com> wrote:
> Fixed by this hopefully?
>
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=d5075b648b06d3120fc7e4c47ccda3d620754590
>
> Thanks,
> Cal
I am sitting on sumo -21 commits so it is included in my builds - sigh..

Andreas

Re: kernel menuconfig broken?

[Cal Sullivan]

If you're using a non-linux-yocto kernel you likely need to apply this 
patch to your kernel as well:

https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch

(This is in all linux-yocto kernels, I'm only linking to meta-intel 
because I knew where it was off the top of my head)

This was sent upstream but last I looked it didn't gain any traction. I 
think Bruce resent it recently but I can't be sure.

Thanks,
Cal

On 04/12/2018 01:28 PM, Andreas Müller wrote:
> On Mon, Apr 2, 2018 at 11:57 PM, Trevor Woerner <twoerner@gmail.com> wrote:
>> On Sun 2018-04-01 @ 11:49:58 PM, Andreas Müller wrote:
>>> When running bitbake -cmenuconfig virtual/kernel I get a flood of
>>> undefined reference errors. Am I alone here?
>> Sadly, I think you might be.
>>
>>          $ bitbake virtual/kernel -c menuconfig
>>
>> works fine for me.
>>
>> I assume you're doing this for something RaspberryPi-ish?
>>
>>          Build Configuration:
>>          BB_VERSION           = "1.37.0"
>>          BUILD_SYS            = "x86_64-linux"
>>          NATIVELSBSTRING      = "opensuse-42.3"
>>          TARGET_SYS           = "arm-oe-linux-gnueabi"
>>          MACHINE              = "raspberrypi3"
>>          DISTRO               = "nodistro"
>>          DISTRO_VERSION       = "nodistro.0"
>>          TUNE_FEATURES        = "arm armv7ve vfp thumb neon vfpv4 callconvention-hard cortexa7"
>>          TARGET_FPU           = "hard"
>>          meta-raspberrypi     = "master:63e53f919089027259a513dc2cd4b140789bf1a3"
>>          meta                 = "master:4cedddb83623c79980b354642dfeaf78218ca4b7"
>>          meta-oe
>>          meta-gnome
>>          meta-python
>>          meta-networking
>>          meta-multimedia      = "master:b9d1d8718834f7287e5a65373b952cbfe9ce83fe"
>>          meta-qt5             = "master:e60e849de1158c879bd2c150fe79b207cdac031a"
>>          meta-qt5-extra       = "master:a0cf057b2f335e8d2be9180f20770773334ec209"
>>          meta-realtime        = "master:250bc6eaa47e550c1db5e2b0ebd42d86ee43650e"
>>          meta-browser         = "master:d1c902440cba26a9d1271cfb914633c68ee3791c"
> OK I found that I am not alone [1] and followed the suggestion to
> install ncurses-devel. Strange: it install ncurses-libs x86_64. Now I
> have back menuconfig but it looks horrible: All framing chars are
> displayed as '@'. If I remember correct there was such an issue long
> lime ago.
>
> However it is not beautiful but I can work with it.
>
> [1] https://github.com/crops/poky-container/issues/17
>
> Andreas

Re: kernel menuconfig broken?

[Andreas Müller]

On Thu, Apr 12, 2018 at 11:38 PM, Cal Sullivan
<california.l.sullivan@intel.com> wrote:
> If you're using a non-linux-yocto kernel you likely need to apply this patch
> to your kernel as well:
>
> https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch
Correct: RaspberryPi kernel
>
> (This is in all linux-yocto kernels, I'm only linking to meta-intel because
> I knew where it was off the top of my head)
>
> This was sent upstream but last I looked it didn't gain any traction. I
> think Bruce resent it recently but I can't be sure.
>
> Thanks,
> Cal
>
That looks very promising - will try and let you know - thanks in advance :)

Andreas

Re: kernel menuconfig broken?

[Andreas Müller]

On Thu, Apr 12, 2018 at 11:46 PM, Andreas Müller
<schnitzeltony@gmail.com> wrote:
> On Thu, Apr 12, 2018 at 11:38 PM, Cal Sullivan
> <california.l.sullivan@intel.com> wrote:
>> If you're using a non-linux-yocto kernel you likely need to apply this patch
>> to your kernel as well:
>>
>> https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch
> Correct: RaspberryPi kernel
>>
>> (This is in all linux-yocto kernels, I'm only linking to meta-intel because
>> I knew where it was off the top of my head)
>>
>> This was sent upstream but last I looked it didn't gain any traction. I
>> think Bruce resent it recently but I can't be sure.
>>
>> Thanks,
>> Cal
>>
> That looks very promising - will try and let you know - thanks in advance :)
>
Perfect! - Thanks Cal for quick help!

Andreas

Re: kernel menuconfig broken?

[Bruce Ashfield]

On 2018-04-12 5:38 PM, Cal Sullivan wrote:
> If you're using a non-linux-yocto kernel you likely need to apply this 
> patch to your kernel as well:
> 
> https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch 
> 
> 
> (This is in all linux-yocto kernels, I'm only linking to meta-intel 
> because I knew where it was off the top of my head)
> 
> This was sent upstream but last I looked it didn't gain any traction. I 
> think Bruce resent it recently but I can't be sure.

Yes, and I'm sending it yet again! :D

Bruce

> 
> Thanks,
> Cal
> 
> On 04/12/2018 01:28 PM, Andreas Müller wrote:
>> On Mon, Apr 2, 2018 at 11:57 PM, Trevor Woerner <twoerner@gmail.com> 
>> wrote:
>>> On Sun 2018-04-01 @ 11:49:58 PM, Andreas Müller wrote:
>>>> When running bitbake -cmenuconfig virtual/kernel I get a flood of
>>>> undefined reference errors. Am I alone here?
>>> Sadly, I think you might be.
>>>
>>>          $ bitbake virtual/kernel -c menuconfig
>>>
>>> works fine for me.
>>>
>>> I assume you're doing this for something RaspberryPi-ish?
>>>
>>>          Build Configuration:
>>>          BB_VERSION           = "1.37.0"
>>>          BUILD_SYS            = "x86_64-linux"
>>>          NATIVELSBSTRING      = "opensuse-42.3"
>>>          TARGET_SYS           = "arm-oe-linux-gnueabi"
>>>          MACHINE              = "raspberrypi3"
>>>          DISTRO               = "nodistro"
>>>          DISTRO_VERSION       = "nodistro.0"
>>>          TUNE_FEATURES        = "arm armv7ve vfp thumb neon vfpv4 
>>> callconvention-hard cortexa7"
>>>          TARGET_FPU           = "hard"
>>>          meta-raspberrypi     = 
>>> "master:63e53f919089027259a513dc2cd4b140789bf1a3"
>>>          meta                 = 
>>> "master:4cedddb83623c79980b354642dfeaf78218ca4b7"
>>>          meta-oe
>>>          meta-gnome
>>>          meta-python
>>>          meta-networking
>>>          meta-multimedia      = 
>>> "master:b9d1d8718834f7287e5a65373b952cbfe9ce83fe"
>>>          meta-qt5             = 
>>> "master:e60e849de1158c879bd2c150fe79b207cdac031a"
>>>          meta-qt5-extra       = 
>>> "master:a0cf057b2f335e8d2be9180f20770773334ec209"
>>>          meta-realtime        = 
>>> "master:250bc6eaa47e550c1db5e2b0ebd42d86ee43650e"
>>>          meta-browser         = 
>>> "master:d1c902440cba26a9d1271cfb914633c68ee3791c"
>> OK I found that I am not alone [1] and followed the suggestion to
>> install ncurses-devel. Strange: it install ncurses-libs x86_64. Now I
>> have back menuconfig but it looks horrible: All framing chars are
>> displayed as '@'. If I remember correct there was such an issue long
>> lime ago.
>>
>> However it is not beautiful but I can work with it.
>>
>> [1] https://github.com/crops/poky-container/issues/17
>>
>> Andreas
> 

Re: kernel menuconfig broken?

[Paul Barker]

On Fri, 13 Apr 2018 00:12:16 +0200
Andreas Müller <schnitzeltony@gmail.com> wrote:

> On Thu, Apr 12, 2018 at 11:46 PM, Andreas Müller
> <schnitzeltony@gmail.com> wrote:
> > On Thu, Apr 12, 2018 at 11:38 PM, Cal Sullivan
> > <california.l.sullivan@intel.com> wrote:  
> >> If you're using a non-linux-yocto kernel you likely need to apply this patch
> >> to your kernel as well:
> >>
> >> https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch  
> > Correct: RaspberryPi kernel  
> >>
> >> (This is in all linux-yocto kernels, I'm only linking to meta-intel because
> >> I knew where it was off the top of my head)
> >>
> >> This was sent upstream but last I looked it didn't gain any traction. I
> >> think Bruce resent it recently but I can't be sure.
> >>
> >> Thanks,
> >> Cal
> >>  
> > That looks very promising - will try and let you know - thanks in advance :)
> >  
> Perfect! - Thanks Cal for quick help!

Sounds like we should apply this to the kernel recipe in
meta-raspberrypi.

Andreas, want to send a PR for this? Or shall I add to my todo list?

Cheers,

-- 
Paul Barker
Beta Five Ltd

Re: kernel menuconfig broken?

[Andreas Müller]

On Sat, Apr 14, 2018 at 11:10 AM, Paul Barker <paul@betafive.co.uk> wrote:
> On Fri, 13 Apr 2018 00:12:16 +0200
> Andreas Müller <schnitzeltony@gmail.com> wrote:
>
>> On Thu, Apr 12, 2018 at 11:46 PM, Andreas Müller
>> <schnitzeltony@gmail.com> wrote:
>> > On Thu, Apr 12, 2018 at 11:38 PM, Cal Sullivan
>> > <california.l.sullivan@intel.com> wrote:
>> >> If you're using a non-linux-yocto kernel you likely need to apply this patch
>> >> to your kernel as well:
>> >>
>> >> https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch
>> > Correct: RaspberryPi kernel
>> >>
>> >> (This is in all linux-yocto kernels, I'm only linking to meta-intel because
>> >> I knew where it was off the top of my head)
>> >>
>> >> This was sent upstream but last I looked it didn't gain any traction. I
>> >> think Bruce resent it recently but I can't be sure.
>> >>
>> >> Thanks,
>> >> Cal
>> >>
>> > That looks very promising - will try and let you know - thanks in advance :)
>> >
>> Perfect! - Thanks Cal for quick help!
>
> Sounds like we should apply this to the kernel recipe in
> meta-raspberrypi.
>
> Andreas, want to send a PR for this? Or shall I add to my todo list?
>
Paul: Am still on my meta-raspi-light (FYI 4.14-rt does not yet
perform good enough to make music) so I think for you it's easier:)

BTW: I had to add the kernel patch also for 4.9 - it had the same issue.

Andreas

Re: kernel menuconfig broken?

[Trevor Woerner]

[-- Attachment #1: Type: text/plain, Size: 96 bytes --]

If everyone else is seeing issues, it makes me wonder why it's working
perfectly fine for me!

[-- Attachment #2: Type: text/html, Size: 146 bytes --]

Re: kernel menuconfig broken?

[Andreas Müller]

On Sat, Apr 14, 2018 at 8:42 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> If everyone else is seeing issues, it makes me wonder why it's working
> perfectly fine for me!
>
Seems you have ncurses installed on horst that matches oe's native
ncurses. The patch description [1] gives details.

[1] https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch

Andreas

Re: kernel menuconfig broken?

[Andreas Müller]

On Fri, Apr 13, 2018 at 12:12 AM, Andreas Müller
<schnitzeltony@gmail.com> wrote:
> On Thu, Apr 12, 2018 at 11:46 PM, Andreas Müller
> <schnitzeltony@gmail.com> wrote:
>> On Thu, Apr 12, 2018 at 11:38 PM, Cal Sullivan
>> <california.l.sullivan@intel.com> wrote:
>>> If you're using a non-linux-yocto kernel you likely need to apply this patch
>>> to your kernel as well:
>>>
>>> https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch
>> Correct: RaspberryPi kernel
>>>
>>> (This is in all linux-yocto kernels, I'm only linking to meta-intel because
>>> I knew where it was off the top of my head)
>>>
>>> This was sent upstream but last I looked it didn't gain any traction. I
>>> think Bruce resent it recently but I can't be sure.
>>>
>>> Thanks,
>>> Cal
>>>
>> That looks very promising - will try and let you know - thanks in advance :)
>>
> Perfect! - Thanks Cal for quick help!
>
Hi,

seems upstream has introduced changes 4.17 -> 4.18 - the patch does
not apply anymore. Is this patch available for 4.18 somewhere?

Regards

Andreas

Re: kernel menuconfig broken?

[Anuj Mittal]

On 09/21/2018 06:04 PM, Andreas Müller wrote:
> On Fri, Apr 13, 2018 at 12:12 AM, Andreas Müller
> <schnitzeltony@gmail.com> wrote:
>> On Thu, Apr 12, 2018 at 11:46 PM, Andreas Müller
>> <schnitzeltony@gmail.com> wrote:
>>> On Thu, Apr 12, 2018 at 11:38 PM, Cal Sullivan
>>> <california.l.sullivan@intel.com> wrote:
>>>> If you're using a non-linux-yocto kernel you likely need to apply this patch
>>>> to your kernel as well:
>>>>
>>>> https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch
>>> Correct: RaspberryPi kernel
>>>>
>>>> (This is in all linux-yocto kernels, I'm only linking to meta-intel because
>>>> I knew where it was off the top of my head)
>>>>
>>>> This was sent upstream but last I looked it didn't gain any traction. I
>>>> think Bruce resent it recently but I can't be sure.
>>>>
>>>> Thanks,
>>>> Cal
>>>>
>>> That looks very promising - will try and let you know - thanks in advance :)
>>>
>> Perfect! - Thanks Cal for quick help!
>>
> Hi,
> 
> seems upstream has introduced changes 4.17 -> 4.18 - the patch does
> not apply anymore. Is this patch available for 4.18 somewhere?
> 

Are you looking for this:

https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit?h=v4.18/standard/base&id=bd6314212686ef8156a108b6f1eec67d34402878

https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/?h=v4.18/standard/base&id=0aa800372a846d6ed2c0fc3e0fdc22656d268968

Re: kernel menuconfig broken?

[Bruce Ashfield]

On 2018-09-21 7:46 AM, Anuj Mittal wrote:
> On 09/21/2018 06:04 PM, Andreas Müller wrote:
>> On Fri, Apr 13, 2018 at 12:12 AM, Andreas Müller
>> <schnitzeltony@gmail.com> wrote:
>>> On Thu, Apr 12, 2018 at 11:46 PM, Andreas Müller
>>> <schnitzeltony@gmail.com> wrote:
>>>> On Thu, Apr 12, 2018 at 11:38 PM, Cal Sullivan
>>>> <california.l.sullivan@intel.com> wrote:
>>>>> If you're using a non-linux-yocto kernel you likely need to apply this patch
>>>>> to your kernel as well:
>>>>>
>>>>> https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/recipes-kernel/linux/linux-intel/0001-menuconfig-check-lxdiaglog.sh-Allow-specification-of.patch
>>>> Correct: RaspberryPi kernel
>>>>>
>>>>> (This is in all linux-yocto kernels, I'm only linking to meta-intel because
>>>>> I knew where it was off the top of my head)
>>>>>
>>>>> This was sent upstream but last I looked it didn't gain any traction. I
>>>>> think Bruce resent it recently but I can't be sure.
>>>>>
>>>>> Thanks,
>>>>> Cal
>>>>>
>>>> That looks very promising - will try and let you know - thanks in advance :)
>>>>
>>> Perfect! - Thanks Cal for quick help!
>>>
>> Hi,
>>
>> seems upstream has introduced changes 4.17 -> 4.18 - the patch does
>> not apply anymore. Is this patch available for 4.18 somewhere?
>>
> 
> Are you looking for this:

Thanks Anuj!

That is indeed the ported patch.

I've also resent the patch, so I'm hoping after 4.19, I won't
have to carry it anymore.

Bruce

> 
> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit?h=v4.18/standard/base&id=bd6314212686ef8156a108b6f1eec67d34402878
> 
> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/?h=v4.18/standard/base&id=0aa800372a846d6ed2c0fc3e0fdc22656d268968
> 

Re: kernel menuconfig broken?

[Andreas Müller]

On Fri, Sep 21, 2018 at 1:46 PM, Anuj Mittal <anuj.mittal@intel.com> wrote:
>> Hi,
>>
>> seems upstream has introduced changes 4.17 -> 4.18 - the patch does
>> not apply anymore. Is this patch available for 4.18 somewhere?
>>
>
> Are you looking for this:
>
> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit?h=v4.18/standard/base&id=bd6314212686ef8156a108b6f1eec67d34402878
>
> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/?h=v4.18/standard/base&id=0aa800372a846d6ed2c0fc3e0fdc22656d268968
Exactly thanks

Andreas

Re: kernel menuconfig broken?

[Andreas Müller]

On Fri, Sep 21, 2018 at 4:39 PM, Andreas Müller <schnitzeltony@gmail.com> wrote:
> On Fri, Sep 21, 2018 at 1:46 PM, Anuj Mittal <anuj.mittal@intel.com> wrote:
>>> Hi,
>>>
>>> seems upstream has introduced changes 4.17 -> 4.18 - the patch does
>>> not apply anymore. Is this patch available for 4.18 somewhere?
>>>
>>
>> Are you looking for this:
>>
>> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit?h=v4.18/standard/base&id=bd6314212686ef8156a108b6f1eec67d34402878
>>
>> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/?h=v4.18/standard/base&id=0aa800372a846d6ed2c0fc3e0fdc22656d268968
> Exactly thanks
>
Otavio pointed to it when I sent them to linux-fslc: Why the code duplication?

Andreas

Re: kernel menuconfig broken?

[Bruce Ashfield]

On 2018-09-21 11:33 AM, Andreas Müller wrote:
> On Fri, Sep 21, 2018 at 4:39 PM, Andreas Müller <schnitzeltony@gmail.com> wrote:
>> On Fri, Sep 21, 2018 at 1:46 PM, Anuj Mittal <anuj.mittal@intel.com> wrote:
>>>> Hi,
>>>>
>>>> seems upstream has introduced changes 4.17 -> 4.18 - the patch does
>>>> not apply anymore. Is this patch available for 4.18 somewhere?
>>>>
>>>
>>> Are you looking for this:
>>>
>>> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit?h=v4.18/standard/base&id=bd6314212686ef8156a108b6f1eec67d34402878
>>>
>>> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/?h=v4.18/standard/base&id=0aa800372a846d6ed2c0fc3e0fdc22656d268968
>> Exactly thanks
>>
> Otavio pointed to it when I sent them to linux-fslc: Why the code duplication?
> 

What do you mean by code duplication ? There was a bug in the initial
port that needed a 2nd commit to fix it, but there's no duplicated
code.

Bruce

> Andreas
> 

Re: kernel menuconfig broken?

[Bruce Ashfield]

On 2018-09-21 11:34 AM, Bruce Ashfield wrote:
> On 2018-09-21 11:33 AM, Andreas Müller wrote:
>> On Fri, Sep 21, 2018 at 4:39 PM, Andreas Müller 
>> <schnitzeltony@gmail.com> wrote:
>>> On Fri, Sep 21, 2018 at 1:46 PM, Anuj Mittal <anuj.mittal@intel.com> 
>>> wrote:
>>>>> Hi,
>>>>>
>>>>> seems upstream has introduced changes 4.17 -> 4.18 - the patch does
>>>>> not apply anymore. Is this patch available for 4.18 somewhere?
>>>>>
>>>>
>>>> Are you looking for this:
>>>>
>>>> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit?h=v4.18/standard/base&id=bd6314212686ef8156a108b6f1eec67d34402878 
>>>>
>>>>
>>>> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/?h=v4.18/standard/base&id=0aa800372a846d6ed2c0fc3e0fdc22656d268968 
>>>>
>>> Exactly thanks
>>>
>> Otavio pointed to it when I sent them to linux-fslc: Why the code 
>> duplication?
>>
> 
> What do you mean by code duplication ? There was a bug in the initial
> port that needed a 2nd commit to fix it, but there's no duplicated
> code.

Ah. I see what you mean now. That was a mistake. I've already fixed
it in future versions, but since nothing breaks with it, the extra
block has stayed in 4.18.

Bruce

> 
> Bruce
> 
>> Andreas
>>
>