All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/12] x86: Fix the mystery of printch() during 64-bit boot
Date: Sat, 13 Oct 2018 18:20:37 +0200	[thread overview]
Message-ID: <0720c1b2-d0a8-55d8-c466-42fc3ca08eaa@gmx.de> (raw)
In-Reply-To: <1539443214-19048-10-git-send-email-bmeng.cn@gmail.com>

On 10/13/2018 05:06 PM, Bin Meng wrote:
> At present in arch_setup_gd() it calls printch(' ') at the end which
> has been a mystery for a long time as without such call the 64-bit
> U-Boot just does not boot at all.
> 
> In fact this is due to the bug that board_init_f() was called with
> boot_flags not being set. Hence whatever value being there in the
> rdi register becomes the boot_flags if without such magic call.
> With a printch(' ') call the rdi register is initialized as 0x20
> and this value seems to be sane enough for the whole boot process.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

So up to now we set gd->flags = GD_FLG_LOGINIT here.

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

  reply	other threads:[~2018-10-13 16:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13 15:06 [U-Boot] [PATCH 00/12] x86: Attempt to bring qemu-x86_64 target in travis-ci build/testing Bin Meng
2018-10-13 15:06 ` [U-Boot] [PATCH 01/12] x86: Specify -march=core2 to build 64-bit U-Boot proper Bin Meng
2018-10-13 15:06 ` [U-Boot] [PATCH 02/12] x86: Ensure no instruction sets of MMX/SSE are generated in 64-bit build Bin Meng
2018-10-13 15:49   ` Heinrich Schuchardt
2018-10-13 15:06 ` [U-Boot] [PATCH 03/12] x86: doc: Mention qemu-x86_64 support Bin Meng
2018-10-13 15:53   ` Heinrich Schuchardt
2018-10-13 15:06 ` [U-Boot] [PATCH 04/12] x86: doc: Remove stale sections of 64-bit support Bin Meng
2018-10-13 15:56   ` Heinrich Schuchardt
2018-10-13 15:06 ` [U-Boot] [PATCH 05/12] x86: qemu: enable CONFIG_SPL_DM_RTC Bin Meng
2018-10-19  3:25   ` Simon Glass
2018-10-13 15:06 ` [U-Boot] [PATCH 06/12] x86: detect unsupported relocation types Bin Meng
2018-10-13 15:06 ` [U-Boot] [PATCH 07/12] x86: put global data pointer into the .data section Bin Meng
2018-10-19  3:26   ` Simon Glass
2018-10-13 15:06 ` [U-Boot] [PATCH 08/12] efi_loader: fix relocation on x86_64 Bin Meng
2018-10-13 15:06 ` [U-Boot] [PATCH 09/12] x86: Fix the mystery of printch() during 64-bit boot Bin Meng
2018-10-13 16:20   ` Heinrich Schuchardt [this message]
2018-10-13 15:06 ` [U-Boot] [PATCH 10/12] x86: tsc: Introduce config option for early timer frequency Bin Meng
2018-10-13 16:44   ` Heinrich Schuchardt
2018-10-13 16:50     ` Bin Meng
2018-10-13 15:06 ` [U-Boot] [PATCH 11/12] x86: quark: Specify X86_TSC_TIMER_EARLY_FREQ Bin Meng
2018-10-13 16:49   ` Heinrich Schuchardt
2018-10-13 15:06 ` [U-Boot] [PATCH 12/12] WIP: travis: Add qemu-x86_64 target for test.py testing Bin Meng
2018-10-13 15:52   ` Bin Meng
2018-10-13 16:52     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0720c1b2-d0a8-55d8-c466-42fc3ca08eaa@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.