From: David Hildenbrand <david@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Thomas Huth <thuth@redhat.com>
Cc: Janosch Frank <frankja@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x <qemu-s390x@nongnu.org>
Subject: Re: [PATCH v2] s390x/cpumodel: Add more feature to gen16 default model
Date: Tue, 7 Sep 2021 12:13:45 +0200 [thread overview]
Message-ID: <07225716-c7ea-1284-1669-5dc3f46a35b6@redhat.com> (raw)
In-Reply-To: <20210907101017.27126-1-borntraeger@de.ibm.com>
On 07.09.21 12:10, Christian Borntraeger wrote:
> Add the new gen16 features to the default model and fence them for
> machine version 6.1 and earlier.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> hw/s390x/s390-virtio-ccw.c | 5 +++++
> target/s390x/gen-features.c | 8 +++++++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 4d25278cf20e..61aeccb163f7 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -803,6 +803,11 @@ DEFINE_CCW_MACHINE(6_2, "6.2", true);
> static void ccw_machine_6_1_instance_options(MachineState *machine)
> {
> ccw_machine_6_2_instance_options(machine);
> + s390_cpudef_featoff_greater(16, 1, S390_FEAT_NNPA);
> + s390_cpudef_featoff_greater(16, 1, S390_FEAT_VECTOR_PACKED_DECIMAL_ENH2);
> + s390_cpudef_featoff_greater(16, 1, S390_FEAT_BEAR_ENH);
> + s390_cpudef_featoff_greater(16, 1, S390_FEAT_RDP);
> + s390_cpudef_featoff_greater(16, 1, S390_FEAT_PAI);
> }
>
> static void ccw_machine_6_1_class_options(MachineClass *mc)
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 7d85322d6814..7cb1a6ec10be 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -663,7 +663,13 @@ static uint16_t default_GEN15_GA1[] = {
> S390_FEAT_ETOKEN,
> };
>
> -#define default_GEN16_GA1 EmptyFeat
> +static uint16_t default_GEN16_GA1[] = {
> + S390_FEAT_NNPA,
> + S390_FEAT_VECTOR_PACKED_DECIMAL_ENH2,
> + S390_FEAT_BEAR_ENH,
> + S390_FEAT_RDP,
> + S390_FEAT_PAI,
> +};
>
> /* QEMU (CPU model) features */
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-09-07 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 10:10 [PATCH v2] s390x/cpumodel: Add more feature to gen16 default model Christian Borntraeger
2021-09-07 10:13 ` David Hildenbrand [this message]
2021-09-07 11:38 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07225716-c7ea-1284-1669-5dc3f46a35b6@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.