From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DBB8C43381 for ; Wed, 27 Mar 2019 12:10:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EACA22087C for ; Wed, 27 Mar 2019 12:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728597AbfC0MKL (ORCPT ); Wed, 27 Mar 2019 08:10:11 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:53578 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728130AbfC0MKI (ORCPT ); Wed, 27 Mar 2019 08:10:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6247E374; Wed, 27 Mar 2019 05:10:08 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74F8B3F557; Wed, 27 Mar 2019 05:10:07 -0700 (PDT) Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs To: Katsuhiro Suzuki , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190321162244.10080-1-katsuhiro@katsuster.net> <8309531.dRdlsDmmhi@phil> From: Robin Murphy Message-ID: <07287fad-c3e6-bcf2-a247-fe4f5031900e@arm.com> Date: Wed, 27 Mar 2019 12:10:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/03/2019 13:49, Katsuhiro Suzuki wrote: > Hello Robin, > > Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs, > please revert my patch if you need. I found a little time to fire up the board again this morning, so I gave this another try to double-check - in fact this time I only saw it fail 3 times in 15 reboots. So something's certainly not quite right, but it's not quite as terrible as the first try implied. My suspicion at this point is that the DMA implementation might be losing characters occasionally, and obviously the bluetooth firmware transfer is going to be a lot more sensitive to that than a text console is. > BTW, there are DMA properties in RK3328 device-tree like as this patch. > RK3328 UART DMA could not work correctly too...?? Quite possibly, although my 3328 box doesn't have any UARTS connected or exposed other than the standard debug console, so I can't easily investigate there. I do have a 3288 box with similar serial bluetooth to my 3399 which might be worth digging out for comparison with an up-to-date kernel. Robin. > > Best Regards, > Katsuhiro Suzuki > > > On 2019/03/26 20:48, Robin Murphy wrote: >> On 25/03/2019 12:34, Heiko Stuebner wrote: >>> Am Donnerstag, 21. März 2019, 17:22:44 CET schrieb Katsuhiro Suzuki: >>>> Add UART dma channels as specified by the rk3399 TRM. >>>> >>>> Refer: >>>> RK3399 TRM V1.4: Chapter 12 DMA Controller >>>> >>>> Signed-off-by: Katsuhiro Suzuki >>> >>> applied for 5.2 >> >> As a heads-up, I did manage to try my board with this patch applied >> over the weekend, and it makes probing the bluetooth adapter fail with >> communication errors, so I'm not sure the 8250 and pl330 drivers are >> really cooperating well enough :( >> >> Robin. >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56480C43381 for ; Wed, 27 Mar 2019 12:10:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 285602087C for ; Wed, 27 Mar 2019 12:10:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lJOFCwAK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 285602087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AUWOIc4CRqxdfGZh1FMOBvK7nXD/rXlPLVQnqKdjW58=; b=lJOFCwAKqiRIv5U/Y4m7YyVSs U1sERfzJyfK4a5zTQKpL+O59HIApAh1LdTwoz6e3Mdoj+sdQZBsqFcd6Xkn2QuDzi62g3/O9O++ZZ qyyBucdvUNwK9f6QTOvLSox5Nb9+bybcAnQ6rFECwa857FHH/KFaaFbrNkkiUJKF7YzfQVSOdOjLv trGjt5LAMp/TQ9n8NWJF9GIy1o8TjaKmbKuZ8L5u+gYr6GhIPtJsPcppP7lDfqiKsWdyfE9EpwOZA 9Ieoz5+aWIIiDJuHs6IdPPulivjCRdqvYIHXsYXvUfAkV0D1A7SVbJGjeKtyJfgxLBU1dPgh1qewd NuY5I1PWg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h97Np-0008SX-VH; Wed, 27 Mar 2019 12:10:17 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h97Ni-0008RM-Sj; Wed, 27 Mar 2019 12:10:16 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6247E374; Wed, 27 Mar 2019 05:10:08 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74F8B3F557; Wed, 27 Mar 2019 05:10:07 -0700 (PDT) Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs To: Katsuhiro Suzuki , Heiko Stuebner References: <20190321162244.10080-1-katsuhiro@katsuster.net> <8309531.dRdlsDmmhi@phil> From: Robin Murphy Message-ID: <07287fad-c3e6-bcf2-a247-fe4f5031900e@arm.com> Date: Wed, 27 Mar 2019 12:10:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_051010_946405_643CA83C X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjYvMDMvMjAxOSAxMzo0OSwgS2F0c3VoaXJvIFN1enVraSB3cm90ZToKPiBIZWxsbyBSb2Jp biwKPiAKPiBTb3JyeSBmb3IgaW5jb252ZW5pZW5jZS4gU2luY2UgSSBkb24ndCBhZGhlcmUgZW5h YmxpbmcgRE1BIGZvciBVQVJUcywKPiBwbGVhc2UgcmV2ZXJ0IG15IHBhdGNoIGlmIHlvdSBuZWVk LgoKSSBmb3VuZCBhIGxpdHRsZSB0aW1lIHRvIGZpcmUgdXAgdGhlIGJvYXJkIGFnYWluIHRoaXMg bW9ybmluZywgc28gSSBnYXZlIAp0aGlzIGFub3RoZXIgdHJ5IHRvIGRvdWJsZS1jaGVjayAtIGlu IGZhY3QgdGhpcyB0aW1lIEkgb25seSBzYXcgaXQgZmFpbCAKMyB0aW1lcyBpbiAxNSByZWJvb3Rz LiBTbyBzb21ldGhpbmcncyBjZXJ0YWlubHkgbm90IHF1aXRlIHJpZ2h0LCBidXQgCml0J3Mgbm90 IHF1aXRlIGFzIHRlcnJpYmxlIGFzIHRoZSBmaXJzdCB0cnkgaW1wbGllZC4KCk15IHN1c3BpY2lv biBhdCB0aGlzIHBvaW50IGlzIHRoYXQgdGhlIERNQSBpbXBsZW1lbnRhdGlvbiBtaWdodCBiZSAK bG9zaW5nIGNoYXJhY3RlcnMgb2NjYXNpb25hbGx5LCBhbmQgb2J2aW91c2x5IHRoZSBibHVldG9v dGggZmlybXdhcmUgCnRyYW5zZmVyIGlzIGdvaW5nIHRvIGJlIGEgbG90IG1vcmUgc2Vuc2l0aXZl IHRvIHRoYXQgdGhhbiBhIHRleHQgY29uc29sZSBpcy4KCj4gQlRXLCB0aGVyZSBhcmUgRE1BIHBy b3BlcnRpZXMgaW4gUkszMzI4IGRldmljZS10cmVlIGxpa2UgYXMgdGhpcyBwYXRjaC4KPiBSSzMz MjggVUFSVCBETUEgY291bGQgbm90IHdvcmsgY29ycmVjdGx5IHRvby4uLj8/CgpRdWl0ZSBwb3Nz aWJseSwgYWx0aG91Z2ggbXkgMzMyOCBib3ggZG9lc24ndCBoYXZlIGFueSBVQVJUUyBjb25uZWN0 ZWQgb3IgCmV4cG9zZWQgb3RoZXIgdGhhbiB0aGUgc3RhbmRhcmQgZGVidWcgY29uc29sZSwgc28g SSBjYW4ndCBlYXNpbHkgCmludmVzdGlnYXRlIHRoZXJlLiBJIGRvIGhhdmUgYSAzMjg4IGJveCB3 aXRoIHNpbWlsYXIgc2VyaWFsIGJsdWV0b290aCB0byAKbXkgMzM5OSB3aGljaCBtaWdodCBiZSB3 b3J0aCBkaWdnaW5nIG91dCBmb3IgY29tcGFyaXNvbiB3aXRoIGFuIAp1cC10by1kYXRlIGtlcm5l bC4KClJvYmluLgoKPiAKPiBCZXN0IFJlZ2FyZHMsCj4gS2F0c3VoaXJvIFN1enVraQo+IAo+IAo+ IE9uIDIwMTkvMDMvMjYgMjA6NDgsIFJvYmluIE11cnBoeSB3cm90ZToKPj4gT24gMjUvMDMvMjAx OSAxMjozNCwgSGVpa28gU3R1ZWJuZXIgd3JvdGU6Cj4+PiBBbSBEb25uZXJzdGFnLCAyMS4gTcOk cnogMjAxOSwgMTc6MjI6NDQgQ0VUIHNjaHJpZWIgS2F0c3VoaXJvIFN1enVraToKPj4+PiBBZGQg VUFSVCBkbWEgY2hhbm5lbHMgYXMgc3BlY2lmaWVkIGJ5IHRoZSByazMzOTkgVFJNLgo+Pj4+Cj4+ Pj4gUmVmZXI6Cj4+Pj4gUkszMzk5IFRSTSBWMS40OiBDaGFwdGVyIDEyIERNQSBDb250cm9sbGVy Cj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBLYXRzdWhpcm8gU3V6dWtpIDxrYXRzdWhpcm9Aa2F0 c3VzdGVyLm5ldD4KPj4+Cj4+PiBhcHBsaWVkIGZvciA1LjIKPj4KPj4gQXMgYSBoZWFkcy11cCwg SSBkaWQgbWFuYWdlIHRvIHRyeSBteSBib2FyZCB3aXRoIHRoaXMgcGF0Y2ggYXBwbGllZCAKPj4g b3ZlciB0aGUgd2Vla2VuZCwgYW5kIGl0IG1ha2VzIHByb2JpbmcgdGhlIGJsdWV0b290aCBhZGFw dGVyIGZhaWwgd2l0aCAKPj4gY29tbXVuaWNhdGlvbiBlcnJvcnMsIHNvIEknbSBub3Qgc3VyZSB0 aGUgODI1MCBhbmQgcGwzMzAgZHJpdmVycyBhcmUgCj4+IHJlYWxseSBjb29wZXJhdGluZyB3ZWxs IGVub3VnaCA6KAo+Pgo+PiBSb2Jpbi4KPj4KPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK