[Buildroot] [PATCH 1/1] package/kodi-visualisation-fishbmc: add dependency to glm

[Buildroot] [PATCH 1/1] package/kodi-visualisation-fishbmc: add dependency to glm

[Bernd Kuhls]

The glm dependency was added upstream in 2019:
https://github.com/xbmc/visualization.fishbmc/commit/31eda216bc9f2f3883217471cfd01afde153c3eb

and was not added when this package was bumped to version 6.3.0:
https://git.buildroot.net/buildroot/commit/?id=7ad1e18bfb93cce3d397b3a2afc3ad418b828e01

This bug was found while testing per-package directories.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-visualisation-fishbmc/Config.in                    | 1 +
 .../kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/kodi-visualisation-fishbmc/Config.in b/package/kodi-visualisation-fishbmc/Config.in
index 66c1565bd7..4d86d8234b 100644
--- a/package/kodi-visualisation-fishbmc/Config.in
+++ b/package/kodi-visualisation-fishbmc/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_KODI_VISUALISATION_FISHBMC
 	bool "kodi-visualisation-fishbmc"
+	select BR2_PACKAGE_GLM
 	help
 	  Fische visualiser for Kodi
 
diff --git a/package/kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk b/package/kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk
index 1008e6f6f1..8e0fcabff9 100644
--- a/package/kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk
+++ b/package/kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk
@@ -8,6 +8,6 @@ KODI_VISUALISATION_FISHBMC_VERSION = 19.0.0-Matrix
 KODI_VISUALISATION_FISHBMC_SITE = $(call github,xbmc,visualization.fishbmc,$(KODI_VISUALISATION_FISHBMC_VERSION))
 KODI_VISUALISATION_FISHBMC_LICENSE = GPL-2.0+
 KODI_VISUALISATION_FISHBMC_LICENSE_FILES = LICENSE.md
-KODI_VISUALISATION_FISHBMC_DEPENDENCIES = kodi
+KODI_VISUALISATION_FISHBMC_DEPENDENCIES = glm kodi
 
 $(eval $(cmake-package))
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/kodi-visualisation-fishbmc: add dependency to glm

[Arnout Vandecappelle]

On 26/09/2021 15:39, Bernd Kuhls wrote:
> The glm dependency was added upstream in 2019:
> https://github.com/xbmc/visualization.fishbmc/commit/31eda216bc9f2f3883217471cfd01afde153c3eb
> 
> and was not added when this package was bumped to version 6.3.0:
> https://git.buildroot.net/buildroot/commit/?id=7ad1e18bfb93cce3d397b3a2afc3ad418b828e01
> 
> This bug was found while testing per-package directories.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/kodi-visualisation-fishbmc/Config.in                    | 1 +
>   .../kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk    | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/kodi-visualisation-fishbmc/Config.in b/package/kodi-visualisation-fishbmc/Config.in
> index 66c1565bd7..4d86d8234b 100644
> --- a/package/kodi-visualisation-fishbmc/Config.in
> +++ b/package/kodi-visualisation-fishbmc/Config.in
> @@ -1,5 +1,6 @@
>   config BR2_PACKAGE_KODI_VISUALISATION_FISHBMC
>   	bool "kodi-visualisation-fishbmc"
> +	select BR2_PACKAGE_GLM
>   	help
>   	  Fische visualiser for Kodi
>   
> diff --git a/package/kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk b/package/kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk
> index 1008e6f6f1..8e0fcabff9 100644
> --- a/package/kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk
> +++ b/package/kodi-visualisation-fishbmc/kodi-visualisation-fishbmc.mk
> @@ -8,6 +8,6 @@ KODI_VISUALISATION_FISHBMC_VERSION = 19.0.0-Matrix
>   KODI_VISUALISATION_FISHBMC_SITE = $(call github,xbmc,visualization.fishbmc,$(KODI_VISUALISATION_FISHBMC_VERSION))
>   KODI_VISUALISATION_FISHBMC_LICENSE = GPL-2.0+
>   KODI_VISUALISATION_FISHBMC_LICENSE_FILES = LICENSE.md
> -KODI_VISUALISATION_FISHBMC_DEPENDENCIES = kodi
> +KODI_VISUALISATION_FISHBMC_DEPENDENCIES = glm kodi
>   
>   $(eval $(cmake-package))
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/kodi-visualisation-fishbmc: add dependency to glm

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > The glm dependency was added upstream in 2019:
 > https://github.com/xbmc/visualization.fishbmc/commit/31eda216bc9f2f3883217471cfd01afde153c3eb

 > and was not added when this package was bumped to version 6.3.0:
 > https://git.buildroot.net/buildroot/commit/?id=7ad1e18bfb93cce3d397b3a2afc3ad418b828e01

 > This bug was found while testing per-package directories.

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Committed to 2021.05.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot