From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E80BC43461 for ; Fri, 21 May 2021 02:23:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50354611AB for ; Fri, 21 May 2021 02:23:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238569AbhEUCYo (ORCPT ); Thu, 20 May 2021 22:24:44 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4706 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238546AbhEUCYk (ORCPT ); Thu, 20 May 2021 22:24:40 -0400 Received: from dggems703-chm.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FmVgx0sJhz16PtQ; Fri, 21 May 2021 10:20:29 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggems703-chm.china.huawei.com (10.3.19.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 21 May 2021 10:23:16 +0800 Received: from [127.0.0.1] (10.40.192.162) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 21 May 2021 10:23:16 +0800 Subject: Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments To: Johan Hovold References: <1621233433-27094-1-git-send-email-tanxiaofei@huawei.com> <1621233433-27094-7-git-send-email-tanxiaofei@huawei.com> <7e63a708-64c4-b369-066b-7f83d65bf178@huawei.com> CC: , , , , From: Xiaofei Tan Message-ID: <07453180-0aa4-e260-a50d-23d27973907b@huawei.com> Date: Fri, 21 May 2021 10:23:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.192.162] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, On 2021/5/20 21:52, Johan Hovold wrote: > On Thu, May 20, 2021 at 09:21:25PM +0800, Xiaofei Tan wrote: > >>> Checkpatch already has too many checks IMO and I'm a bit surprised that >>> it doesn't check this already. Perhaps it's because you used the -f to >>> run checkpatch on in-kernel code, which you should not. >>> >>>>> Second, that sentence is not capitalised so why do add a period? >>>>> >>>> >>>> How about capitalize the sentence, or just remove the period ? >>> >>> How about just leaving this unchanged? >> >> OK >> And I will keep the patch 8/9, and combine space issues into >> one new patch, and remove the others. > > Yeah, 8/9 is arguably a fix even if it's for a very minor issue > (repeated words in a comment). > > It doesn't look like any of the white space issues are worth fixing, > though. Such pedantry can usually be addressed when the code in question > is being modified for other reasons. > OK, it is reasonable. thanks. > Johan > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCA7C433ED for ; Fri, 21 May 2021 02:23:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A338E6121E for ; Fri, 21 May 2021 02:23:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A338E6121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FmVlg0BQcz301W for ; Fri, 21 May 2021 12:23:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.190; helo=szxga04-in.huawei.com; envelope-from=tanxiaofei@huawei.com; receiver=) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FmVlF4FTbz2yWT for ; Fri, 21 May 2021 12:23:21 +1000 (AEST) Received: from dggems703-chm.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FmVgx0sJhz16PtQ; Fri, 21 May 2021 10:20:29 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggems703-chm.china.huawei.com (10.3.19.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 21 May 2021 10:23:16 +0800 Received: from [127.0.0.1] (10.40.192.162) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 21 May 2021 10:23:16 +0800 Subject: Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments To: Johan Hovold References: <1621233433-27094-1-git-send-email-tanxiaofei@huawei.com> <1621233433-27094-7-git-send-email-tanxiaofei@huawei.com> <7e63a708-64c4-b369-066b-7f83d65bf178@huawei.com> From: Xiaofei Tan Message-ID: <07453180-0aa4-e260-a50d-23d27973907b@huawei.com> Date: Fri, 21 May 2021 10:23:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.192.162] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Johan, On 2021/5/20 21:52, Johan Hovold wrote: > On Thu, May 20, 2021 at 09:21:25PM +0800, Xiaofei Tan wrote: > >>> Checkpatch already has too many checks IMO and I'm a bit surprised that >>> it doesn't check this already. Perhaps it's because you used the -f to >>> run checkpatch on in-kernel code, which you should not. >>> >>>>> Second, that sentence is not capitalised so why do add a period? >>>>> >>>> >>>> How about capitalize the sentence, or just remove the period ? >>> >>> How about just leaving this unchanged? >> >> OK >> And I will keep the patch 8/9, and combine space issues into >> one new patch, and remove the others. > > Yeah, 8/9 is arguably a fix even if it's for a very minor issue > (repeated words in a comment). > > It doesn't look like any of the white space issues are worth fixing, > though. Such pedantry can usually be addressed when the code in question > is being modified for other reasons. > OK, it is reasonable. thanks. > Johan > > . >