From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5527EC433DF for ; Thu, 4 Jun 2020 16:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3ED252072E for ; Thu, 4 Jun 2020 16:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729720AbgFDQIw (ORCPT ); Thu, 4 Jun 2020 12:08:52 -0400 Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:48196 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726026AbgFDQIu (ORCPT ); Thu, 4 Jun 2020 12:08:50 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 5DEAF1810F261; Thu, 4 Jun 2020 16:08:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: joke87_4e0d58826d98 X-Filterd-Recvd-Size: 2786 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Jun 2020 16:08:47 +0000 (UTC) Message-ID: <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken From: Joe Perches To: Dan Carpenter , Julia Lawall Cc: Linus Walleij , Christophe JAILLET , Robert Jarzmik , Daniel Mack , Haojian Zhuang , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Date: Thu, 04 Jun 2020 09:08:44 -0700 In-Reply-To: <20200604123038.GG22511@kadam> References: <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> <20200604123038.GG22511@kadam> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > OK, I recall a discussion with Dan where he suggested that some things > > that were not actually bug fixes could also merit a Fixes tag. But it's > > probably better if he weighs in directly. > > I generally think Fixes should only be used for "real bug" fixes. > > The one exception is when I'm reviewing a patch that fixes an "unused > assignment" static checker warning is that I know which commit > introduced the warning. I don't have strong feelings if it's in the > Fixes tag or if it's just mentioned in the commit message. My view is that changes that silence compiler warnings are not fixing bugs and that these changes should generally not be backported. Compiler silencing changes marked as fixes can introduce other defects in working code. Backporting patches to stable trees should be conservatively rather than liberally applied. It seems that the actual backport maintainers disagree though. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Thu, 04 Jun 2020 16:08:44 +0000 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-Id: <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> List-Id: References: <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> <20200604123038.GG22511@kadam> In-Reply-To: <20200604123038.GG22511@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Julia Lawall Cc: Linus Walleij , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Daniel Mack , Robert Jarzmik , Linux ARM On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > OK, I recall a discussion with Dan where he suggested that some things > > that were not actually bug fixes could also merit a Fixes tag. But it's > > probably better if he weighs in directly. > > I generally think Fixes should only be used for "real bug" fixes. > > The one exception is when I'm reviewing a patch that fixes an "unused > assignment" static checker warning is that I know which commit > introduced the warning. I don't have strong feelings if it's in the > Fixes tag or if it's just mentioned in the commit message. My view is that changes that silence compiler warnings are not fixing bugs and that these changes should generally not be backported. Compiler silencing changes marked as fixes can introduce other defects in working code. Backporting patches to stable trees should be conservatively rather than liberally applied. It seems that the actual backport maintainers disagree though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB459C433E0 for ; Thu, 4 Jun 2020 16:09:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1C192072E for ; Thu, 4 Jun 2020 16:09:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qDG0Kscq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1C192072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CJ07e9/GxF8tDfjUnJhC76O1hiuj8Dd390TojG9hpVA=; b=qDG0Kscq5E5ky1 LQNBR7kSpj2Q/GOpzWIsPrD0L4mdWSjbSFztMnWND6tCnIqq8Saq/ItNEdQ7Y/s9NnPusOHtRPvjy +qeF0Kvmj+ur84ueeJXi4GzyWN0UdzZwdHb8K314WtG7I2LlkfRkL4gLuUzvTmN/YTRoXziqZcbdB LkccFRcwTJ8m1xgfuUFgjTiOSx81OKa+3OSHYCR8dN9jvGAih0ttVvgJn6rV4zRAgzfYFgfZQXeRo si8aPiXvnUpls/JYs4U7h9no63G0BL7xh2STnZxi3YV3ZGqqeC02mfnoTI5W9uddiLBpWkjTES9DO x5PhCO/a+xS3cXqUXHbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgsQM-0004yH-Q2; Thu, 04 Jun 2020 16:08:58 +0000 Received: from smtprelay0146.hostedemail.com ([216.40.44.146] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgsQJ-0004xJ-Rx for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 16:08:57 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 5DEAF1810F261; Thu, 4 Jun 2020 16:08:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: joke87_4e0d58826d98 X-Filterd-Recvd-Size: 2786 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Jun 2020 16:08:47 +0000 (UTC) Message-ID: <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken From: Joe Perches To: Dan Carpenter , Julia Lawall Date: Thu, 04 Jun 2020 09:08:44 -0700 In-Reply-To: <20200604123038.GG22511@kadam> References: <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> <20200604123038.GG22511@kadam> User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_090855_962542_666CBEDD X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Daniel Mack , Robert Jarzmik , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > OK, I recall a discussion with Dan where he suggested that some things > > that were not actually bug fixes could also merit a Fixes tag. But it's > > probably better if he weighs in directly. > > I generally think Fixes should only be used for "real bug" fixes. > > The one exception is when I'm reviewing a patch that fixes an "unused > assignment" static checker warning is that I know which commit > introduced the warning. I don't have strong feelings if it's in the > Fixes tag or if it's just mentioned in the commit message. My view is that changes that silence compiler warnings are not fixing bugs and that these changes should generally not be backported. Compiler silencing changes marked as fixes can introduce other defects in working code. Backporting patches to stable trees should be conservatively rather than liberally applied. It seems that the actual backport maintainers disagree though. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel