From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 0/5] net/i40e: implement dynamic mapping
 of flow types to pctypes
Date: Tue, 3 Oct 2017 22:44:55 +0100
Message-ID: <075d4bf6-c58d-82c3-1adc-6b0fb90af506@intel.com>
References: <1505917983-119112-1-git-send-email-kirill.rybalchenko@intel.com>
 <1506956942-59123-1-git-send-email-kirill.rybalchenko@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: andrey.chilikin@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com
To: Kirill Rybalchenko <kirill.rybalchenko@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 4AC681B3E0
 for <dev@dpdk.org>; Tue,  3 Oct 2017 23:44:57 +0200 (CEST)
In-Reply-To: <1506956942-59123-1-git-send-email-kirill.rybalchenko@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/2/2017 4:08 PM, Kirill Rybalchenko wrote:
> Implement dynamic mapping of software flow types to hardware pctypes.
> This allows to map new flow types to pctypes without changing
> API of the driver.
> 
> v2:
> Remove unnecessary check for new flow types.
> Re-arrange patchset to avoid compillation errors.
> Remove unnecessary usage of statically defined flow types and pctypes.
> 
> v3:
> Remove unnecessary bit operations in I40E_PFQF_HENA and I40E_VFQF_HENA registers.
> Add new definition in enum i40e_filter_pctype for for invalid pctype.
> Fixed bugs in i40e_pctype_to_flowtype and i40e_flowtype_to_pctype functions.
> Function rte_pmd_i40e_flow_type_mapping_get returns now full mapping table.
> testpmd: changed command syntax from 'pctype mapping...' to
> 'port config pctype mapping...' and 'show port pctype mapping'
> Various small modifications in code style after reviewing.
> 
> v4:
> Change prototypes of some static functions.
> Move declaration of automatic variables to beginning of function.
> Move declaration of I40E_FILTER_PCTYPE_INVALID to i40e_ethdev.h
> Fix some typos in source filea and documentation.
> 
> Kirill Rybalchenko (5):
>   net/i40e: remove unnecessary bit operations
>   net/i40e: implement dynamic mapping of sw flow types to hw pctypes
>   net/i40e: add new functions to manipulate with pctype      mapping
>     table
>   app/testpmd: add new commands to manipulate with pctype mapping
>   ethdev: remove unnecessary check for new flow type

There is a comment related to testpmd documentation.

Also there are long line checkpatch warnings, can you please check them
and fix reasonable ones.

Other than above two overall looks good to me, so for next version you
can keep:

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>