From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A048C282D8 for ; Fri, 1 Feb 2019 18:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA7F020823 for ; Fri, 1 Feb 2019 18:24:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WbH6jL3G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730783AbfBASYK (ORCPT ); Fri, 1 Feb 2019 13:24:10 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45589 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729984AbfBASYK (ORCPT ); Fri, 1 Feb 2019 13:24:10 -0500 Received: by mail-wr1-f65.google.com with SMTP id t6so8060852wrr.12 for ; Fri, 01 Feb 2019 10:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bmTspHt94YuHE3z6GJDZCgmxkBnubP/W6IztDAVY2nE=; b=WbH6jL3GWkA2iScHp/sQOVcwi8pQaQiL5m6fyh+Jo8T0WEtLqbMdk5+ui2sB8tU7uz bIKpxLzmP4uPngY6AJXOqtciEMwZejFrxiYgCB5GVEGhQo4fb1h/2M8UhpSDfzq8n/gh TVsjL0qrD3BPRbHpqFrzXV3HY2In3y/qW2sESO6ZxmoHcp+Ajt4GNk/FDGkptXHZb5h6 uIOJmXMECN56IqH2g/SY8KOuz1C0gdAr/GQRMaSeNokWfwVNhhKvcyDnky/w4gOSoe56 bHH5zV/JlcvXRVepELjm5v+IUuEhg2axqZTDFDHQlau1WWl+235vENt+AcdiVgduwCEd e4WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bmTspHt94YuHE3z6GJDZCgmxkBnubP/W6IztDAVY2nE=; b=oGLsRIjH9Sj/CWTwRPGIoWphM/Vm2P2zflgb1NNXsVQPcNw00PbA60n09Pr7ZpLZTo +xim9i7dQilbrLbA3pp5F1E725QfJhh/xtBftZXSeo/wuXUgr3GvX42j5MA7I9nIz/6S dL5Nzo/Kgoozbdx1iA0bZ0AVHv6n3yeNxghjQ9dusWga8OutIEAnViePQtUPQrHxwOLR j4C3NSRp07jOnPZgl5EEJdQinTCqwEgAISU8FrnnpcUJB+/idI2Xsb+TGYCoIsrVkZYH BWFQM4oBUGuagzcoOBi5Ni2nFH0zJYWV8/rWuzInVEwmtz8JRNYzK67dUpflq04Kt7V0 DVCQ== X-Gm-Message-State: AHQUAubqnytDkfXUCQcl4w8jtBrkTLN0ENCeA/cezRTrNNpZjH1oU37i qb9q8buM17gYxT3fGoW4aKV1mjEp X-Google-Smtp-Source: AHgI3IZ3UpXMTn+vobCCSL8LZsnAIC1jB8XDSlDlB+aEgrqGEYXz8gjixdhyAWtXCaUkwQx6KkrhSQ== X-Received: by 2002:a5d:4ac7:: with SMTP id y7mr17015560wrs.196.1549045447726; Fri, 01 Feb 2019 10:24:07 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:dd2a:ac:a04b:d136? (p200300EA8BF1E200DD2A00ACA04BD136.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:dd2a:ac:a04b:d136]) by smtp.googlemail.com with ESMTPSA id v133sm3511880wmf.19.2019.02.01.10.24.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Feb 2019 10:24:07 -0800 (PST) Subject: Re: WoL broken in r8169.c since kernel 4.19 To: Marc Haber Cc: "netdev@vger.kernel.org" References: <20190127205555.GF27062@torres.zugschlus.de> <64b22f62-ca8a-caee-5a39-f06ffe6598d1@gmail.com> <20190128073010.GG27062@torres.zugschlus.de> <20190128202235.GH27062@torres.zugschlus.de> <20190129073253.GJ27062@torres.zugschlus.de> <20190129153553.GL27062@torres.zugschlus.de> <638767f7-5701-309b-97b1-a83f774afbab@gmail.com> <20190130153735.GN27062@torres.zugschlus.de> <070e8dac-4ab2-ef86-f44d-991c7c8182aa@gmail.com> <20190201171943.GA25308@torres.zugschlus.de> From: Heiner Kallweit Message-ID: <075de04d-4a5d-e557-aba6-7e569826a356@gmail.com> Date: Fri, 1 Feb 2019 19:24:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190201171943.GA25308@torres.zugschlus.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It's too much effort to make the current r8169 compile under an older kernel. But thanks anyway for trying! Heiner On 01.02.2019 18:19, Marc Haber wrote: > On Fri, Feb 01, 2019 at 07:49:09AM +0100, Heiner Kallweit wrote: >> Great, thanks. This patch has been applied and is part of latest linux-next kernel already: >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/?h=next-20190201 >> Would be much appreciated if you could build and test this kernel version. > > I regret that I have not been able to get this through the compiler. > When I clone the linux-next repo and try to build with deb-pkg, some > process chokes on the weird version number of the linux-next kernel, and > transplanting the r8169.c from linux-next on to 4.20.6, compile aborts: > > In file included from drivers/net/ethernet/realtek/r8169.c:13: > ./include/linux/pci.h:830:12: error: ‘PCI_VENDOR_ID_USR’ undeclared here (not in a function); did you mean ‘PCI_VENDOR_ID_UMC’? > .vendor = PCI_VENDOR_ID_##vend, .device = (dev), \ > ^~~~~~~~~~~~~~ > drivers/net/ethernet/realtek/r8169.c:222:4: note: in expansion of macro ‘PCI_VDEVICE’ > { PCI_VDEVICE(USR, 0x0116), RTL_CFG_0 }, > ^~~~~~~~~~~ > drivers/net/ethernet/realtek/r8169.c: In function ‘rtl8169_start_xmit’: > drivers/net/ethernet/realtek/r8169.c:6261:6: error: implicit declaration of function ‘__netdev_sent_queue’; did you mean ‘netdev_sent_queue’? [-Werror=implicit-function-declaration] > if (__netdev_sent_queue(dev, skb->len, skb->xmit_more)) > ^~~~~~~~~~~~~~~~~~~ > netdev_sent_queue > drivers/net/ethernet/realtek/r8169.c: In function ‘r8169_phy_connect’: > drivers/net/ethernet/realtek/r8169.c:6653:22: warning: passing argument 1 of ‘linkmode_copy’ makes pointer from integer without a cast [-Wint-conversion] > linkmode_copy(phydev->advertising, phydev->supported); > ~~~~~~^~~~~~~~~~~~~ > In file included from ./include/linux/phy.h:22, > from drivers/net/ethernet/realtek/r8169.c:19: > ./include/linux/linkmode.h:13:49: note: expected ‘long unsigned int *’ but argument is of type ‘u32’ {aka ‘unsigned int’} > static inline void linkmode_copy(unsigned long *dst, const unsigned long *src) > ~~~~~~~~~~~~~~~^~~ > drivers/net/ethernet/realtek/r8169.c:6653:43: warning: passing argument 2 of ‘linkmode_copy’ makes pointer from integer without a cast [-Wint-conversion] > linkmode_copy(phydev->advertising, phydev->supported); > ~~~~~~^~~~~~~~~~~ > In file included from ./include/linux/phy.h:22, > from drivers/net/ethernet/realtek/r8169.c:19: > ./include/linux/linkmode.h:13:75: note: expected ‘const long unsigned int *’ but argument is of type ‘u32’ {aka ‘unsigned int’} > static inline void linkmode_copy(unsigned long *dst, const unsigned long *src) > ~~~~~~~~~~~~~~~~~~~~~^~~ > cc1: some warnings being treated as errors > make[4]: *** [scripts/Makefile.build:297: drivers/net/ethernet/realtek/r8169.o] Error 1 > > Will it help if I transplant more files from linux-next to 4.20.6? > > Greetings > Marc >