From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/2] package/nfs-utils: fix unnecessary files removal
Date: Sun, 5 May 2019 22:40:49 +0200 [thread overview]
Message-ID: <0761f786-b4ff-ce13-34f5-d404bbf0d443@mind.be> (raw)
In-Reply-To: <1556442175-1494-1-git-send-email-angelo@amarulasolutions.com>
On 28/04/2019 11:02, Angelo Compagnucci wrote:
> Removing of unnecessary files is actually broken by the fact that the rm
> command is executed inside build directory and not the target directory.
>
> This patch fixes the problem changing to target directory before
> removing files.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> v3->v4: separate fix patch as requested by Arnout
>
> package/nfs-utils/nfs-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index 9fa7ae2..4bb62de 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -57,7 +57,7 @@ NFS_UTILS_CONF_OPTS += --disable-tirpc
> endif
>
> define NFS_UTILS_INSTALL_FIXUP
> - rm -f $(NFS_UTILS_TARGETS_)
> + cd $(TARGET_DIR) && rm -f $(NFS_UTILS_TARGETS_)
Personally, I'd have used $(addprefix) instead of cd, but that's just my own
thing, so: applied to master, thanks.
Regards,
Arnout
> touch $(TARGET_DIR)/etc/exports
> $(INSTALL) -D -m 644 \
> $(@D)/utils/mount/nfsmount.conf $(TARGET_DIR)/etc/nfsmount.conf
>
next prev parent reply other threads:[~2019-05-05 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 9:02 [Buildroot] [PATCH v4 1/2] package/nfs-utils: fix unnecessary files removal Angelo Compagnucci
2019-04-28 9:02 ` [Buildroot] [PATCH v4 2/2] package/nfs-utils: making nfs server optional Angelo Compagnucci
2019-05-05 20:44 ` Arnout Vandecappelle
2019-05-05 20:40 ` Arnout Vandecappelle [this message]
2019-05-10 9:57 ` [Buildroot] [PATCH v4 1/2] package/nfs-utils: fix unnecessary files removal Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0761f786-b4ff-ce13-34f5-d404bbf0d443@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.