From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/ncurses: enable widechar for host build
Date: Tue, 8 May 2018 22:30:50 +0200 [thread overview]
Message-ID: <076570fa-ba56-34bc-7b71-3fa726e81e75@mind.be> (raw)
In-Reply-To: <20180508153139.0d807f82@windsurf.home>
On 08-05-18 15:31, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 3 May 2018 21:45:07 +0200, Yann E. MORIN wrote:
>
>> What about overriding HOSTCC when calling linux-menuconfig:
>>
>> diff --git a/linux/linux.mk b/linux/linux.mk
>> index 9e646baffc..75a256ff9e 100644
>> --- a/linux/linux.mk
>> +++ b/linux/linux.mk
>> @@ -235,7 +235,7 @@ LINUX_KCONFIG_FILE = $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE))
>> endif
>> LINUX_KCONFIG_FRAGMENT_FILES = $(call qstrip,$(BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES))
>> LINUX_KCONFIG_EDITORS = menuconfig xconfig gconfig nconfig
>> -LINUX_KCONFIG_OPTS = $(LINUX_MAKE_FLAGS)
>> +LINUX_KCONFIG_OPTS = $(LINUX_MAKE_FLAGS) HOSTCC="$(HOSTCC)"
>>
>> # If no package has yet set it, set it from the Kconfig option
>> LINUX_NEEDS_MODULES ?= $(BR2_LINUX_NEEDS_MODULES)
>>
>> We should not need any library from HOST_DIR when we run menuconfig.
>>
>> Note: we may still want to enable widechar in host-ncurses for other
>> reasons, though. But with the proposdal above, there is no lopnger any
>> mix of system ncurses vs our own.
>
> Arnout, any comment on Yann's proposal? I have to say my preference
> goes to Yann's solution, as it's the one that ensures there is no
> mixing of ncurses between the one we build in HOST_DIR and the one
> provided by the system.
As noted in another thread, the same problem might occur for another package.
Basically, kconfig will fail if we pass the normal HOST_CONFIGURE_OPTS. But I
guess it's not likely that we ever have a package that does that, since kconfig
packages are normally target packages, and kconfig doesn't listen to
CFLAGS_FOR_BUILD/LDFLAGS_FOR_BUILD.
So OK, Yann, can you prepare a patch? I've marked this patch as Rejected.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2018-05-08 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 15:24 [Buildroot] 'make foo-menuconfig' broken when host-ncurses was built Arnout Vandecappelle
2018-04-26 19:08 ` [Buildroot] [PATCH] package/ncurses: enable widechar for host build Arnout Vandecappelle
2018-04-27 12:05 ` Scott Fan
2018-05-03 7:58 ` Arnout Vandecappelle
2018-05-03 19:45 ` Yann E. MORIN
2018-05-08 13:31 ` Thomas Petazzoni
2018-05-08 20:30 ` Arnout Vandecappelle [this message]
2018-05-01 20:12 ` [Buildroot] 'make foo-menuconfig' broken when host-ncurses was built Peter Korsgaard
2018-05-02 23:19 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=076570fa-ba56-34bc-7b71-3fa726e81e75@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.