Re: [Buildroot] [PATCH] skeleton + init: prepare /run/lock and adjust compat symlinks

[Arnout Vandecappelle <arnout@mind.be>]

On 12/01/2022 09:53, Norbert Lange wrote:
> 
> 
> 
> Thomas Petazzoni <thomas.petazzoni@bootlin.com 
> <mailto:thomas.petazzoni@bootlin.com>> schrieb am Mi., 12. Jan. 2022, 09:14:
> 
>     Hello Norbert,
> 
>     On Mon,  5 Oct 2020 00:41:36 +0200
>     Norbert Lange <nolange79@gmail.com <mailto:nolange79@gmail.com>> wrote:
> 
>      > Linux distros changed /var/run and /var/lock to reside on an tmpfs in
>      > /run a long time ago, and buildroot seems to agree by providing this
>      > tmpfs on all supported init systems.
> 
>     I am not 100% sure but it seems like this patch has potentially broken
>     the build of vtun, which now fails with:
> 
>        /usr/bin/install: cannot create directory
>     '/home/giuliobenetti/autobuild/run/instance-0/output-1/target/var/lock':
>     File exists
> 
>     If you look at http://autobuild.buildroot.net/?reason=vtun%
>     <http://autobuild.buildroot.net/?reason=vtun%>, vtun
>     version 3.0.4 restarted failing to build on January 10, with this error.
> 
>     Could you have a look ?
> 
>     Best regards,
> 
>     Thomas
>     -- 
>     Thomas Petazzoni, CTO, Bootlin
>     Embedded Linux and Kernel engineering
>     https://bootlin.com <https://bootlin.com>
> 
> 
> Seems like the issue is, that run/lock is not existing when installing.
> Anything installed there will be gone (already before this commit), so it's 
> kinda pointless to do so.

  Ah, yes, there are many packages that require a directory in a tmpfs and that 
create it at build time (because they dont "know" that it's going to be a tmpfs) 
and at runtime (in the init script, through tmpfiles, or by the application itself).

> I don't know how many packages have this issue, imho it would be better to fix 
> them instead of making a run/lock directory for broken packages (that will get 
> removed later)

  We're not going to patch packages just for that, because unavoidably some 
upstreams are not going to be receptive. Creating the directory is a much 
simpler solution.

  Regards,
  Arnout

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot