From: Dmitry Fleytman <dmitry@daynix.com>
To: Gonglei <arei.gonglei@huawei.com>
Cc: qemu-devel@nongnu.org, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] e1000: fix buliding complaint
Date: Wed, 31 Aug 2016 15:58:55 +0300 [thread overview]
Message-ID: <0781C43B-C45B-4CB9-8E41-B501F2B6614B@daynix.com> (raw)
In-Reply-To: <1472530253-94132-3-git-send-email-arei.gonglei@huawei.com>
Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
> On 30 Aug 2016, at 07:10 AM, Gonglei <arei.gonglei@huawei.com> wrote:
>
> hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared inline after being called
> hw/net/e1000e_core.c:56: warning: previous declaration of e1000e_set_interrupt_cause was here
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/net/e1000e_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
> index badb1fe..825e169 100644
> --- a/hw/net/e1000e_core.c
> +++ b/hw/net/e1000e_core.c
> @@ -2168,7 +2168,7 @@ e1000e_update_interrupt_state(E1000ECore *core)
> }
> }
>
> -static inline void
> +static void
> e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val)
> {
> trace_e1000e_irq_set_cause_entry(val, core->mac[ICR]);
> --
> 1.7.12.4
>
>
next prev parent reply other threads:[~2016-08-31 12:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 4:10 [Qemu-devel] [PATCH v2 0/2] fix building complaint Gonglei
2016-08-30 4:10 ` [Qemu-devel] [PATCH v2 1/2] crypto: " Gonglei
2016-08-30 14:14 ` Eric Blake
2016-08-30 14:21 ` Peter Maydell
2016-09-05 10:14 ` Daniel P. Berrange
2016-09-05 10:50 ` Gonglei (Arei)
2016-09-05 11:04 ` Daniel P. Berrange
2016-09-05 12:02 ` Gonglei (Arei)
2016-09-05 12:07 ` Daniel P. Berrange
2016-08-30 4:10 ` [Qemu-devel] [PATCH v2 2/2] e1000: fix buliding complaint Gonglei
2016-08-31 12:58 ` Dmitry Fleytman [this message]
2016-09-09 7:15 ` Gonglei (Arei)
2016-09-13 6:00 ` Dmitry Fleytman
2016-09-22 6:30 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0781C43B-C45B-4CB9-8E41-B501F2B6614B@daynix.com \
--to=dmitry@daynix.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.