From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D26E8C433E0 for ; Tue, 9 Mar 2021 22:15:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FAD465020 for ; Tue, 9 Mar 2021 22:15:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230431AbhCIWO1 (ORCPT ); Tue, 9 Mar 2021 17:14:27 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:51373 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231960AbhCIWOS (ORCPT ); Tue, 9 Mar 2021 17:14:18 -0500 Received: from [192.168.100.1] ([82.142.6.26]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MaIvT-1lDrLg2j3N-00WEYS; Tue, 09 Mar 2021 23:13:29 +0100 Subject: Re: [PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , kvm@vger.kernel.org, Paul Durrant , Jason Wang , David Hildenbrand , Thomas Huth , Jiaxun Yang , Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, qemu-trivial@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Huacai Chen , Halil Pasic , Christian Borntraeger , Marcel Apfelbaum , Anthony Perard , qemu-ppc@nongnu.org, Aleksandar Rikalo , Eduardo Habkost , Amit Shah , Richard Henderson , Greg Kurz , Alex Williamson , qemu-arm@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , xen-devel@lists.xenproject.org, Sunil Muthuswamy , John Snow , David Gibson , Kevin Wolf , Marcelo Tosatti , qemu-s390x@nongnu.org, Max Reitz , "Michael S. Tsirkin" , Cornelia Huck , Paolo Bonzini , Aurelien Jarno References: <20210111152020.1422021-1-philmd@redhat.com> <20210111152020.1422021-2-philmd@redhat.com> From: Laurent Vivier Message-ID: <07895651-8d3f-5029-f53d-c85046a4d671@vivier.eu> Date: Tue, 9 Mar 2021 23:13:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210111152020.1422021-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:12XOd/fQZjSctmbivNeZ1JZuQewWmbkfNL57bgUQXmbdKx9dqLq HByZ1sycMG2xd1f+Y6yoJ/TNHv1q6ARh/FZPZEs0rYlTXo9PPylXUW3db8Eoe56W/2ymSKS /crueO/Fx3A1swwtZA4GcywniuEYh2T+g3qQCTjORZGEdqbUjOU+rQWriBAh+Sl4PrvEl7W vTfr73lCewZh9adojPJ2A== X-UI-Out-Filterresults: notjunk:1;V03:K0:0bXVhwhndoo=:bFHdv36pWdMKsFzU/9x10J fmKQKyh8l7iyerCElMGY2yYMA3QZwQ6jbBMMIVsI6KEc+S2AIhKNe7HuCowVP5x4JzeuftrFe e1+4vqqbDGJ3WGNzmpMYAhJ0Njbl6/EAgMbtJQKAqVaryqK3xVT9dpbAwX3JzDGJqUfhAXoyN JdHgfLNttj3xq5oyOsgInECsqt4mS31a+Lqlsy422v8f/DZtEkiOmSHFr077kI8kzB2J7k7HL Pq97nLqxOVL/HO97G3GmXoeFA/rtuZlezrPfR0HVlsWTR+XvzwO9rqlp5Web+tuIavvic7Vu+ m8uJOnVXHSJSFQaDy0PAXdj4FDanqvaZ9O1bOj3zb6DcA1MOhXI+XZ/DB4Tt3isCVhPMAk1oI uru20n4qviPJbzX7PPt7Bo/L3VJeJyDIUhcqJHkgj+lgqfnL42QDBDbdSpSHhQ3q3VgvXUM2Y KfFETldzFg== Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Le 11/01/2021 à 16:20, Philippe Mathieu-Daudé a écrit : > runstate_check() returns a boolean. runstate_is_running() > returns what runstate_check() returns, also a boolean. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/runstate.h | 2 +- > softmmu/runstate.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h > index e557f470d42..3ab35a039a0 100644 > --- a/include/sysemu/runstate.h > +++ b/include/sysemu/runstate.h > @@ -6,7 +6,7 @@ > > bool runstate_check(RunState state); > void runstate_set(RunState new_state); > -int runstate_is_running(void); > +bool runstate_is_running(void); > bool runstate_needs_reset(void); > bool runstate_store(char *str, size_t size); > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c > index 636aab0addb..c7a67147d17 100644 > --- a/softmmu/runstate.c > +++ b/softmmu/runstate.c > @@ -217,7 +217,7 @@ void runstate_set(RunState new_state) > current_run_state = new_state; > } > > -int runstate_is_running(void) > +bool runstate_is_running(void) > { > return runstate_check(RUN_STATE_RUNNING); > } > Applied to my trivial-patches branch. Thanks, Laurent From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B9DC433DB for ; Tue, 9 Mar 2021 22:15:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84CCD650AC for ; Tue, 9 Mar 2021 22:15:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84CCD650AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJkdP-00036v-GS for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 17:15:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJkcJ-0001pL-Aj; Tue, 09 Mar 2021 17:14:15 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:46445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJkcH-0006uf-Jw; Tue, 09 Mar 2021 17:14:15 -0500 Received: from [192.168.100.1] ([82.142.6.26]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MaIvT-1lDrLg2j3N-00WEYS; Tue, 09 Mar 2021 23:13:29 +0100 Subject: Re: [PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210111152020.1422021-1-philmd@redhat.com> <20210111152020.1422021-2-philmd@redhat.com> From: Laurent Vivier Message-ID: <07895651-8d3f-5029-f53d-c85046a4d671@vivier.eu> Date: Tue, 9 Mar 2021 23:13:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210111152020.1422021-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:12XOd/fQZjSctmbivNeZ1JZuQewWmbkfNL57bgUQXmbdKx9dqLq HByZ1sycMG2xd1f+Y6yoJ/TNHv1q6ARh/FZPZEs0rYlTXo9PPylXUW3db8Eoe56W/2ymSKS /crueO/Fx3A1swwtZA4GcywniuEYh2T+g3qQCTjORZGEdqbUjOU+rQWriBAh+Sl4PrvEl7W vTfr73lCewZh9adojPJ2A== X-UI-Out-Filterresults: notjunk:1;V03:K0:0bXVhwhndoo=:bFHdv36pWdMKsFzU/9x10J fmKQKyh8l7iyerCElMGY2yYMA3QZwQ6jbBMMIVsI6KEc+S2AIhKNe7HuCowVP5x4JzeuftrFe e1+4vqqbDGJ3WGNzmpMYAhJ0Njbl6/EAgMbtJQKAqVaryqK3xVT9dpbAwX3JzDGJqUfhAXoyN JdHgfLNttj3xq5oyOsgInECsqt4mS31a+Lqlsy422v8f/DZtEkiOmSHFr077kI8kzB2J7k7HL Pq97nLqxOVL/HO97G3GmXoeFA/rtuZlezrPfR0HVlsWTR+XvzwO9rqlp5Web+tuIavvic7Vu+ m8uJOnVXHSJSFQaDy0PAXdj4FDanqvaZ9O1bOj3zb6DcA1MOhXI+XZ/DB4Tt3isCVhPMAk1oI uru20n4qviPJbzX7PPt7Bo/L3VJeJyDIUhcqJHkgj+lgqfnL42QDBDbdSpSHhQ3q3VgvXUM2Y KfFETldzFg== Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , kvm@vger.kernel.org, Paul Durrant , Jason Wang , Aleksandar Rikalo , Gerd Hoffmann , Stefano Stabellini , "Michael S. Tsirkin" , qemu-block@nongnu.org, qemu-trivial@nongnu.org, John Snow , David Hildenbrand , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, Huacai Chen , Thomas Huth , Eduardo Habkost , Amit Shah , Richard Henderson , Greg Kurz , Alex Williamson , qemu-arm@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , Sunil Muthuswamy , =?UTF-8?Q?Alex_Benn=c3=a9e?= , David Gibson , Kevin Wolf , Marcelo Tosatti , qemu-s390x@nongnu.org, Max Reitz , qemu-ppc@nongnu.org, Cornelia Huck , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 11/01/2021 à 16:20, Philippe Mathieu-Daudé a écrit : > runstate_check() returns a boolean. runstate_is_running() > returns what runstate_check() returns, also a boolean. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/runstate.h | 2 +- > softmmu/runstate.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h > index e557f470d42..3ab35a039a0 100644 > --- a/include/sysemu/runstate.h > +++ b/include/sysemu/runstate.h > @@ -6,7 +6,7 @@ > > bool runstate_check(RunState state); > void runstate_set(RunState new_state); > -int runstate_is_running(void); > +bool runstate_is_running(void); > bool runstate_needs_reset(void); > bool runstate_store(char *str, size_t size); > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c > index 636aab0addb..c7a67147d17 100644 > --- a/softmmu/runstate.c > +++ b/softmmu/runstate.c > @@ -217,7 +217,7 @@ void runstate_set(RunState new_state) > current_run_state = new_state; > } > > -int runstate_is_running(void) > +bool runstate_is_running(void) > { > return runstate_check(RUN_STATE_RUNNING); > } > Applied to my trivial-patches branch. Thanks, Laurent