From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from merlin.infradead.org ([205.233.59.134]:46130 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754148AbeEHW4V (ORCPT ); Tue, 8 May 2018 18:56:21 -0400 Subject: Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED() To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, tomi.valkeinen@ti.com, linux-omap@vger.kernel.org References: <201805050150.CmagcMOg%fengguang.wu@intel.com> <8d55f45b6aa36f5c758d191825f14cd31723b371.1525466956.git.mchehab+samsung@kernel.org> <20180505181447.2ba0ca3f@vento.lan> From: Randy Dunlap Message-ID: <0789b035-0e0f-0665-bd0b-3a7aae6fe9f7@infradead.org> Date: Tue, 8 May 2018 15:56:12 -0700 MIME-Version: 1.0 In-Reply-To: <20180505181447.2ba0ca3f@vento.lan> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote: > Em Sat, 5 May 2018 10:59:23 -0700 > Randy Dunlap escreveu: > >> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote: >>> Just checking for ifdefs cause build issues as reported by >>> kernel test: >>> >>> config: openrisc-allmodconfig (attached as .config) >>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections': >>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration] >>> mgr = omapdss_find_mgr_from_display(def_dssdev); >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] >>> mgr = omapdss_find_mgr_from_display(def_dssdev); >>> ^ >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display': >>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration] >>> def_name = omapdss_get_default_display_name(); >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion] >>> def_name = omapdss_get_default_display_name(); >>> ^ >>> >>> So, use IS_ENABLED() instead. >> >> Hi, >> >> I would like to test this (the change doesn't make much sense to me), >> but I cannot find the kernel config file nor the kernel test robot's >> email of this report. >> >> Please include an lkml.kernel.org/r/ reference to such emails >> so that interested parties can join the party. > > The message was not c/c to lkml. You can see the original here: > > https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html > > >> >> Does this patch apply only to your media tree? so hopefully I can see it in >> linux-next on Monday. > > Yes, as it is over another two patches applied there. > > If you want to test it earlier, it is in the top of the master branch: > https://git.linuxtv.org/media_tree.git > >> >> Thanks. >> >>> Cc: Bartlomiej Zolnierkiewicz >>> Cc: Randy Dunlap >>> Cc: tomi.valkeinen@ti.com >>> Cc: linux-omap@vger.kernel.org >>> Cc: linux-fbdev@vger.kernel.org >>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP") >>> Signed-off-by: Mauro Carvalho Chehab >>> --- >>> include/video/omapfb_dss.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h >>> index e9775144ff3b..12755d8d9b4f 100644 >>> --- a/include/video/omapfb_dss.h >>> +++ b/include/video/omapfb_dss.h >>> @@ -778,7 +778,7 @@ struct omap_dss_driver { >>> >>> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask); >>> >>> -#ifdef CONFIG_FB_OMAP2 >>> +#if IS_ENABLED(CONFIG_FB_OMAP2) >>> >>> enum omapdss_version omapdss_get_version(void); >>> bool omapdss_is_initialized(void); The patch doesn't make any sense to me. I would like to see an explanation of why this is needed, other than "it fixes the build." ;) But it does fix the build, so: Tested-by: Randy Dunlap thanks, -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Tue, 08 May 2018 22:56:12 +0000 Subject: Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED() Message-Id: <0789b035-0e0f-0665-bd0b-3a7aae6fe9f7@infradead.org> List-Id: References: <201805050150.CmagcMOg%fengguang.wu@intel.com> <8d55f45b6aa36f5c758d191825f14cd31723b371.1525466956.git.mchehab+samsung@kernel.org> <20180505181447.2ba0ca3f@vento.lan> In-Reply-To: <20180505181447.2ba0ca3f@vento.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , tomi.valkeinen@ti.com, linux-omap@vger.kernel.org, Linux Media Mailing List On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote: > Em Sat, 5 May 2018 10:59:23 -0700 > Randy Dunlap escreveu: > >> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote: >>> Just checking for ifdefs cause build issues as reported by >>> kernel test: >>> >>> config: openrisc-allmodconfig (attached as .config) >>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections': >>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration] >>> mgr = omapdss_find_mgr_from_display(def_dssdev); >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] >>> mgr = omapdss_find_mgr_from_display(def_dssdev); >>> ^ >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display': >>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration] >>> def_name = omapdss_get_default_display_name(); >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion] >>> def_name = omapdss_get_default_display_name(); >>> ^ >>> >>> So, use IS_ENABLED() instead. >> >> Hi, >> >> I would like to test this (the change doesn't make much sense to me), >> but I cannot find the kernel config file nor the kernel test robot's >> email of this report. >> >> Please include an lkml.kernel.org/r/ reference to such emails >> so that interested parties can join the party. > > The message was not c/c to lkml. You can see the original here: > > https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html > > >> >> Does this patch apply only to your media tree? so hopefully I can see it in >> linux-next on Monday. > > Yes, as it is over another two patches applied there. > > If you want to test it earlier, it is in the top of the master branch: > https://git.linuxtv.org/media_tree.git > >> >> Thanks. >> >>> Cc: Bartlomiej Zolnierkiewicz >>> Cc: Randy Dunlap >>> Cc: tomi.valkeinen@ti.com >>> Cc: linux-omap@vger.kernel.org >>> Cc: linux-fbdev@vger.kernel.org >>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP") >>> Signed-off-by: Mauro Carvalho Chehab >>> --- >>> include/video/omapfb_dss.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h >>> index e9775144ff3b..12755d8d9b4f 100644 >>> --- a/include/video/omapfb_dss.h >>> +++ b/include/video/omapfb_dss.h >>> @@ -778,7 +778,7 @@ struct omap_dss_driver { >>> >>> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask); >>> >>> -#ifdef CONFIG_FB_OMAP2 >>> +#if IS_ENABLED(CONFIG_FB_OMAP2) >>> >>> enum omapdss_version omapdss_get_version(void); >>> bool omapdss_is_initialized(void); The patch doesn't make any sense to me. I would like to see an explanation of why this is needed, other than "it fixes the build." ;) But it does fix the build, so: Tested-by: Randy Dunlap thanks, -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED() Date: Tue, 8 May 2018 15:56:12 -0700 Message-ID: <0789b035-0e0f-0665-bd0b-3a7aae6fe9f7@infradead.org> References: <201805050150.CmagcMOg%fengguang.wu@intel.com> <8d55f45b6aa36f5c758d191825f14cd31723b371.1525466956.git.mchehab+samsung@kernel.org> <20180505181447.2ba0ca3f@vento.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180505181447.2ba0ca3f@vento.lan> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , tomi.valkeinen@ti.com, linux-omap@vger.kernel.org, Linux Media Mailing List List-Id: linux-omap@vger.kernel.org T24gMDUvMDUvMjAxOCAwMjoxNCBQTSwgTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIHdyb3RlOgo+IEVt IFNhdCwgNSBNYXkgMjAxOCAxMDo1OToyMyAtMDcwMAo+IFJhbmR5IER1bmxhcCA8cmR1bmxhcEBp bmZyYWRlYWQub3JnPiBlc2NyZXZldToKPiAKPj4gT24gMDUvMDQvMjAxOCAwMTo0OSBQTSwgTWF1 cm8gQ2FydmFsaG8gQ2hlaGFiIHdyb3RlOgo+Pj4gSnVzdCBjaGVja2luZyBmb3IgaWZkZWZzIGNh dXNlIGJ1aWxkIGlzc3VlcyBhcyByZXBvcnRlZCBieQo+Pj4ga2VybmVsIHRlc3Q6Cj4+Pgo+Pj4g Y29uZmlnOiBvcGVucmlzYy1hbGxtb2Rjb25maWcgKGF0dGFjaGVkIGFzIC5jb25maWcpCj4+PiBj b21waWxlcjogb3Ixay1saW51eC1nY2MgKEdDQykgNi4wLjAgMjAxNjAzMjcgKGV4cGVyaW1lbnRh bCkKPj4+Cj4+PiBBbGwgZXJyb3JzIChuZXcgb25lcyBwcmVmaXhlZCBieSA+Pik6Cj4+Pgo+Pj4g ICAgZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvb21hcGZiLW1haW4uYzogSW4gZnVu Y3Rpb24gJ29tYXBmYl9pbml0X2Nvbm5lY3Rpb25zJzogIAo+Pj4+PiBkcml2ZXJzL3ZpZGVvL2Zi ZGV2L29tYXAyL29tYXBmYi9vbWFwZmItbWFpbi5jOjIzOTY6ODogZXJyb3I6IGltcGxpY2l0IGRl Y2xhcmF0aW9uIG9mIGZ1bmN0aW9uICdvbWFwZHNzX2ZpbmRfbWdyX2Zyb21fZGlzcGxheScgWy1X ZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dICAKPj4+ICAgICAgbWdyID0gb21h cGRzc19maW5kX21ncl9mcm9tX2Rpc3BsYXkoZGVmX2Rzc2Rldik7Cj4+PiAgICAgICAgICAgIF5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4+PiAgICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29t YXAyL29tYXBmYi9vbWFwZmItbWFpbi5jOjIzOTY6Njogd2FybmluZzogYXNzaWdubWVudCBtYWtl cyBwb2ludGVyIGZyb20gaW50ZWdlciB3aXRob3V0IGEgY2FzdCBbLVdpbnQtY29udmVyc2lvbl0K Pj4+ICAgICAgbWdyID0gb21hcGRzc19maW5kX21ncl9mcm9tX2Rpc3BsYXkoZGVmX2Rzc2Rldik7 Cj4+PiAgICAgICAgICBeCj4+PiAgICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9v bWFwZmItbWFpbi5jOiBJbiBmdW5jdGlvbiAnb21hcGZiX2ZpbmRfZGVmYXVsdF9kaXNwbGF5Jzog IAo+Pj4+PiBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9vbWFwZmItbWFpbi5jOjI0 MzA6MTM6IGVycm9yOiBpbXBsaWNpdCBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbiAnb21hcGRzc19n ZXRfZGVmYXVsdF9kaXNwbGF5X25hbWUnIFstV2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xh cmF0aW9uXSAgCj4+PiAgICAgIGRlZl9uYW1lID0gb21hcGRzc19nZXRfZGVmYXVsdF9kaXNwbGF5 X25hbWUoKTsKPj4+ICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fgo+Pj4gICAgZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvb21hcGZiLW1haW4u YzoyNDMwOjExOiB3YXJuaW5nOiBhc3NpZ25tZW50IG1ha2VzIHBvaW50ZXIgZnJvbSBpbnRlZ2Vy IHdpdGhvdXQgYSBjYXN0IFstV2ludC1jb252ZXJzaW9uXQo+Pj4gICAgICBkZWZfbmFtZSA9IG9t YXBkc3NfZ2V0X2RlZmF1bHRfZGlzcGxheV9uYW1lKCk7Cj4+PiAgICAgICAgICAgICAgIF4KPj4+ Cj4+PiBTbywgdXNlIElTX0VOQUJMRUQoKSBpbnN0ZWFkLiAgCj4+Cj4+IEhpLAo+Pgo+PiBJIHdv dWxkIGxpa2UgdG8gdGVzdCB0aGlzICh0aGUgY2hhbmdlIGRvZXNuJ3QgbWFrZSBtdWNoIHNlbnNl IHRvIG1lKSwKPj4gYnV0IEkgY2Fubm90IGZpbmQgdGhlIGtlcm5lbCBjb25maWcgZmlsZSBub3Ig dGhlIGtlcm5lbCB0ZXN0IHJvYm90J3MKPj4gZW1haWwgb2YgdGhpcyByZXBvcnQuCj4+Cj4+IFBs ZWFzZSBpbmNsdWRlIGFuIGxrbWwua2VybmVsLm9yZy9yLzxtZXNzYWdlX2lkPiByZWZlcmVuY2Ug dG8gc3VjaCBlbWFpbHMKPj4gc28gdGhhdCBpbnRlcmVzdGVkIHBhcnRpZXMgY2FuIGpvaW4gdGhl IHBhcnR5Lgo+IAo+IFRoZSBtZXNzYWdlIHdhcyBub3QgYy9jIHRvIGxrbWwuIFlvdSBjYW4gc2Vl IHRoZSBvcmlnaW5hbCBoZXJlOgo+IAo+IGh0dHBzOi8vd3d3Lm1haWwtYXJjaGl2ZS5jb20vbGlu dXgtbWVkaWFAdmdlci5rZXJuZWwub3JnL21zZzEzMDgwOS5odG1sCj4gCj4gCj4+Cj4+IERvZXMg dGhpcyBwYXRjaCBhcHBseSBvbmx5IHRvIHlvdXIgbWVkaWEgdHJlZT8gIHNvIGhvcGVmdWxseSBJ IGNhbiBzZWUgaXQgaW4KPj4gbGludXgtbmV4dCBvbiBNb25kYXkuCj4gCj4gWWVzLCBhcyBpdCBp cyBvdmVyIGFub3RoZXIgdHdvIHBhdGNoZXMgYXBwbGllZCB0aGVyZS4KPiAKPiBJZiB5b3Ugd2Fu dCB0byB0ZXN0IGl0IGVhcmxpZXIsIGl0IGlzIGluIHRoZSB0b3Agb2YgdGhlIG1hc3RlciBicmFu Y2g6Cj4gCWh0dHBzOi8vZ2l0LmxpbnV4dHYub3JnL21lZGlhX3RyZWUuZ2l0Cj4gCj4+Cj4+IFRo YW5rcy4KPj4KPj4+IENjOiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVA c2Ftc3VuZy5jb20+Cj4+PiBDYzogUmFuZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+ Cj4+PiBDYzogdG9taS52YWxrZWluZW5AdGkuY29tCj4+PiBDYzogbGludXgtb21hcEB2Z2VyLmtl cm5lbC5vcmcKPj4+IENjOiBsaW51eC1mYmRldkB2Z2VyLmtlcm5lbC5vcmcKPj4+IEZpeGVzOiA3 NzFmN2JlODdmZjkgKCJtZWRpYTogb21hcGZiOiBvbWFwZmJfZHNzLmg6IGFkZCBzdHVicyB0byBi dWlsZCB3aXRoIENPTVBJTEVfVEVTVCAmJiBEUk1fT01BUCIpCj4+PiBTaWduZWQtb2ZmLWJ5OiBN YXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWIrc2Ftc3VuZ0BrZXJuZWwub3JnPgo+Pj4gLS0t Cj4+PiAgaW5jbHVkZS92aWRlby9vbWFwZmJfZHNzLmggfCAyICstCj4+PiAgMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvdmlkZW8vb21hcGZiX2Rzcy5oIGIvaW5jbHVkZS92aWRlby9vbWFwZmJfZHNzLmgKPj4+ IGluZGV4IGU5Nzc1MTQ0ZmYzYi4uMTI3NTVkOGQ5YjRmIDEwMDY0NAo+Pj4gLS0tIGEvaW5jbHVk ZS92aWRlby9vbWFwZmJfZHNzLmgKPj4+ICsrKyBiL2luY2x1ZGUvdmlkZW8vb21hcGZiX2Rzcy5o Cj4+PiBAQCAtNzc4LDcgKzc3OCw3IEBAIHN0cnVjdCBvbWFwX2Rzc19kcml2ZXIgewo+Pj4gIAo+ Pj4gIHR5cGVkZWYgdm9pZCAoKm9tYXBfZGlzcGNfaXNyX3QpICh2b2lkICphcmcsIHUzMiBtYXNr KTsKPj4+ICAKPj4+IC0jaWZkZWYgQ09ORklHX0ZCX09NQVAyCj4+PiArI2lmIElTX0VOQUJMRUQo Q09ORklHX0ZCX09NQVAyKQo+Pj4gIAo+Pj4gIGVudW0gb21hcGRzc192ZXJzaW9uIG9tYXBkc3Nf Z2V0X3ZlcnNpb24odm9pZCk7Cj4+PiAgYm9vbCBvbWFwZHNzX2lzX2luaXRpYWxpemVkKHZvaWQp OwoKVGhlIHBhdGNoIGRvZXNuJ3QgbWFrZSBhbnkgc2Vuc2UgdG8gbWUuICBJIHdvdWxkIGxpa2Ug dG8gc2VlIGFuCmV4cGxhbmF0aW9uIG9mIHdoeSB0aGlzIGlzIG5lZWRlZCwgb3RoZXIgdGhhbiAi aXQgZml4ZXMgdGhlIGJ1aWxkLiIgOykKCkJ1dCBpdCBkb2VzIGZpeCB0aGUgYnVpbGQsIHNvOgpU ZXN0ZWQtYnk6IFJhbmR5IER1bmxhcCA8cmR1bmxhcEBpbmZyYWRlYWQub3JnPgoKCnRoYW5rcywK LS0gCn5SYW5keQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK