Re: [Qemu-devel] [PATCH for-2.7 v5.1 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK.

From: Felipe Franciosi <felipe@nutanix.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Felipe Franciosi" <felipe@nutanix.com>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"Anil Kumar Boggarapu" <anilkumar.boggarapu@nutanix.com>,
	"Prerna Saxena" <saxenap.ltc@gmail.com>,
	"Prerna Saxena" <prerna.saxena@nutanix.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.7 v5.1 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK.
Date: Sat, 30 Jul 2016 09:38:27 +0000	[thread overview]
Message-ID: <079DCD2D-4777-4383-9B00-D893FF381C61@nutanix.com> (raw)
In-Reply-To: <579BBFA6.2050709@redhat.com>

(Intentionally top-posting:)

Hey Eric,

That's really odd. I don't recall changing anything, but I just checked my (other) e-mail on the nongnu.org's archive and indeed it looks awful. (It looks fine on both clients I use, though.) Thanks for letting me know, I'll sort this out.

Cheers,
Felipe

> On 29 Jul 2016, at 21:42, Eric Blake <eblake@redhat.com> wrote:
> 
> On 07/29/2016 09:31 AM, Felipe Franciosi wrote:
>> Heya,
>> 
>> On 29 Jul 2016, at 13:47, Marc-André Lureau <marcandre.lureau@gmail.com<mailto:marcandre.lureau@gmail.com>> wrote:
>> 
>> Hi
>> 
>> On Thu, Jul 28, 2016 at 11:07 AM, Prerna Saxena <saxenap.ltc@gmail.com<mailto:saxenap.ltc@gmail.com>> wrote:
>> From: Prerna Saxena <prerna.saxena@nutanix.com<mailto:prerna.saxena@nutanix.com>>
> 
> Wow, your mailer's poor choice of quoting style makes it VERY difficult
> to read your reply.
> 
> 
>> +With this protocol extension negotiated, the sender (QEMU) can set the
>> +"need_reply" [Bit 3] flag to any command. This indicates that
>> +the client MUST respond with a Payload VhostUserMsg indicating success or
>> +failure. The payload should be set to zero on success or non-zero on failure.
>> +(Unless the message already has an explicit reply body)
>> 
>> Unless/unless (for consistency, the rest of the document doesn't use
>> Upper-case inside parentheses)
>> 
>> Actually, if the sentence starts inside the parenthesis it should be capital.
>> See rule 2a:
>> http://www.grammarbook.com/punctuation/parens.asp
>> 
>> Prerna's text looks correct to me. If it's wrong in other places we should probably fix it there separately.
>> 
> 
> Based on the number of '>' inserted by my mailer, it appears that you
> wrote all four of the above paragraphs. In reality, Prerna wrote the
> first paragraph (quoted from the patch, Marc-André wrote the second, and
> you wrote the third and fourth.  In fact, your mailer ACTIVELY stripped
> the '>' that was already present in Marc-André's mail when he quoted
> Prerna, rather than the usual paradigm of adding yet another layer of '>'.
> 
> You really need to get that fixed.  We should not have to hunt and
> compare multiple emails in order to determine what you are adding to the
> conversation, nor mis-attribute it to the wrong author.
> 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 