From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDBA1C4332E for ; Fri, 5 Mar 2021 10:50:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A328D64FD4 for ; Fri, 5 Mar 2021 10:50:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbhCEKtp (ORCPT ); Fri, 5 Mar 2021 05:49:45 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:50765 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbhCEKta (ORCPT ); Fri, 5 Mar 2021 05:49:30 -0500 Received: from mail-wr1-f71.google.com ([209.85.221.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI81R-0000Yh-Cm for linux-kernel@vger.kernel.org; Fri, 05 Mar 2021 10:49:29 +0000 Received: by mail-wr1-f71.google.com with SMTP id v13so881392wrs.21 for ; Fri, 05 Mar 2021 02:49:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x355s57mqby7JDxFCF0HuhCS/cEaB4YomcQNrg8OfjI=; b=tnPEhdBP4Kc7HWjzLcErwZ5wmLr0mrQCOkhqCORAg+iUiwbjf40SGyk4uC06W8ka4u JRy2kzgzZL8V4sJS+RmN60eM2CKbskCJEtpwrvyFcxpHI2Yhzix8Vja2swmxuCOdGrhZ 9tfcmizZWCCx5P3ed2T+TQDFL+TXdv2WNjHE4zjM/yY4FheFPFE4VMM9EEvRHn6ttUQm hFE0ybTURJy02uX1pUou4sZD58bkixWf0p7l2JU8vqQYfiwx8WJDtxYnoyqpusW16RZg fnMYZVH4HQRQwLCgGQJjqBbH2H7Ll2YOW/1NYu8s20nmcROLjC/PKL2D4Esh/bjCX3Hw 8KIg== X-Gm-Message-State: AOAM532rm7jk7oASgNDdez+FNxddyNQABm3HLcN7g2IRgC3X9DhLsKWe mBkoF4aXaPThJKY2zQdQR+cFQJ3nKyIEAIhYPiNdSyn7g4qVldAKCReVd0laJfCN4sDruK3VpmL CRw/qWJpPYxu/u5oKOrhk4ftRgxXgAhpLg/nfvPVH4g== X-Received: by 2002:adf:b609:: with SMTP id f9mr8296378wre.223.1614941368891; Fri, 05 Mar 2021 02:49:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYz6bNl1iPPftQcYDplqdzOSjyJy6jsc5Nui7+7tYXrGSPIMpQb+uLEy89c759e4pgLKfP3w== X-Received: by 2002:adf:b609:: with SMTP id f9mr8296353wre.223.1614941368730; Fri, 05 Mar 2021 02:49:28 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id u4sm4084003wrm.24.2021.03.05.02.49.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:49:28 -0800 (PST) From: Krzysztof Kozlowski Subject: Re: [RFT PATCH v3 20/27] tty: serial: samsung_tty: Add s3c24xx_port_type To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-21-marcan@marcan.st> Message-ID: <079d64da-0e36-d626-fc45-0973519e0ee3@canonical.com> Date: Fri, 5 Mar 2021 11:49:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-21-marcan@marcan.st> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2021 22:38, Hector Martin wrote: > This decouples the TTY layer PORT_ types, which are exposed to > userspace, from the driver-internal flag of what kind of port this is. s/This decouples/Decouple > > This removes s3c24xx_serial_has_interrupt_mask, which was just checking s/This removes/Remove/ https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L89 This actually also applies to your patch 19 and 21... and maybe more. > for a specific type anyway. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/samsung_tty.c | 112 +++++++++++++++++++------------ > 1 file changed, 70 insertions(+), 42 deletions(-) > Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A6DC433E0 for ; Fri, 5 Mar 2021 10:52:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B24564FDF for ; Fri, 5 Mar 2021 10:52:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B24564FDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: Cc:To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tE+UgW3K/jaupLzm0BJVHlgJ8OSJSH20EelH1HOJKeQ=; b=ZL8f2Rd04JaFoHzDCmejDnD/f //GD70KNAd+53wRmBnnq3RD061cG6AO4KpdfIg+pM/k5B4yOAQp5bGJR8KZoTeUdKz044e+mwluj+ xUdKylOuEStNr4JHhlRgG89YlqN0h46fmjI2qhJfgbwn0SiuwLR0qd+sKFBjSVgN2VFIUhzsB+OZl sOyp45bCMonjpnIqkTPoNqz1LZ964yHkiXhti8fwCofhJ77qZfaO8dGJZQiVRacC7FU8XuJ1CJZZX HCZRtjFxBRTuOgeVZY2Veu0c11WdryJcNzySF1BTAzQg5VdABtUuvqQkvOiECqEoasl/SmzZQa16K 7ml9M1log==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI81e-00Ed9d-7s; Fri, 05 Mar 2021 10:49:42 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI81S-00Ed6V-6R for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:49:36 +0000 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI81R-0000YR-5t for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:49:29 +0000 Received: by mail-wr1-f72.google.com with SMTP id h21so869864wrc.19 for ; Fri, 05 Mar 2021 02:49:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x355s57mqby7JDxFCF0HuhCS/cEaB4YomcQNrg8OfjI=; b=f/okcnwBj2M0NOi1s6w3fYAaaKFelJIZcjfLsOWNiSOBtZhH90EdJnlhDc7IZgbMK+ 0fnTRUDucVMrXiPSKeOo9HV3te/IVoNy3S62Xo0POYFzghYUklrQA2kh3SHvegvDgkWw NatMnvWmQNKquGoK4qVojG3op72THlY/4uDCb5iBuzQE9O4fPvCixP226ihxN5kCJgMB dEV4mYezJsZGc2IkZpZZ8ldLJLABw/EHjItLs1Gf87EyMGBZ92YjUhUHnA2YjJaU3QHw ybJCFfbzRybALxCNPyDPnZWiXTT+EZkEUva1O8NLB6jYNpEOo50fxQVFZKND75fo4ErF dXMQ== X-Gm-Message-State: AOAM531bwJcQDBR4u58bGrWuh0R7KhwgEsYz25ft5eWqAnqYAjcYLJCp lD7e5dKZ0SOcomJ5tTLVLN6Helv4oT3FbYj+o/fQSxsyoDfjWmVEU6B1Js09wPGwU/sW/3Y7JL+ va5ItesBSSMP+uq5NZdXXoI+2QfWKBWrctWRiP+f6fmlsHDL5II67 X-Received: by 2002:adf:b609:: with SMTP id f9mr8296371wre.223.1614941368890; Fri, 05 Mar 2021 02:49:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYz6bNl1iPPftQcYDplqdzOSjyJy6jsc5Nui7+7tYXrGSPIMpQb+uLEy89c759e4pgLKfP3w== X-Received: by 2002:adf:b609:: with SMTP id f9mr8296353wre.223.1614941368730; Fri, 05 Mar 2021 02:49:28 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id u4sm4084003wrm.24.2021.03.05.02.49.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:49:28 -0800 (PST) From: Krzysztof Kozlowski Subject: Re: [RFT PATCH v3 20/27] tty: serial: samsung_tty: Add s3c24xx_port_type To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-21-marcan@marcan.st> Message-ID: <079d64da-0e36-d626-fc45-0973519e0ee3@canonical.com> Date: Fri, 5 Mar 2021 11:49:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-21-marcan@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_104933_942723_0944C531 X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2021 22:38, Hector Martin wrote: > This decouples the TTY layer PORT_ types, which are exposed to > userspace, from the driver-internal flag of what kind of port this is. s/This decouples/Decouple > > This removes s3c24xx_serial_has_interrupt_mask, which was just checking s/This removes/Remove/ https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L89 This actually also applies to your patch 19 and 21... and maybe more. > for a specific type anyway. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/samsung_tty.c | 112 +++++++++++++++++++------------ > 1 file changed, 70 insertions(+), 42 deletions(-) > Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel