From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F939C433B4 for ; Tue, 6 Apr 2021 07:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8A8E613B8 for ; Tue, 6 Apr 2021 07:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232478AbhDFHnH (ORCPT ); Tue, 6 Apr 2021 03:43:07 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:50502 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232693AbhDFHnE (ORCPT ); Tue, 6 Apr 2021 03:43:04 -0400 Received: from mail-wr1-f70.google.com ([209.85.221.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lTgMR-0004Xt-Ru for linux-kernel@vger.kernel.org; Tue, 06 Apr 2021 07:42:55 +0000 Received: by mail-wr1-f70.google.com with SMTP id r12so9533657wro.15 for ; Tue, 06 Apr 2021 00:42:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=un5YlHzl0BXO6eaQ9eW4dvRNdp9xfJ5KIDYh8hbqnBI=; b=atnWkh9tfhr2HmXtR9Mg7iby1ETXUbFaRxuMVD1r3KCdnx53+UfqJk7ya4fPO5gPH9 gdpNPSrj/wBtWyyAzNAZ7e10m7Xvlpd5c9BQRZyKZuPVtLFxcg/5mGHjb5ANXTfducHJ LwJZeteK5R4/7HOS1TnqNyhtRJNdb/c+C/N/QapwgFmonXLL8tq8A65QMmCOIRDVpjB6 9sz7Nv3xSoaE2iKBWNDvrXZs9q9ZQ83Hl3URqIFUyDJD+HLFKxFm1HbUr/JW2sVgRgKu 4tGtppL8FDoFP/XZPitxDri7hGRQTMDuqOiI8ZpgRxfyaQoMCxH7SNwJvjRlMHqiuzfL iWJw== X-Gm-Message-State: AOAM531u1URAwCAjHcxnVHtLP2yLhji1T+Ypy83+oEBHgNdBENi/1VlD DC3lX81MQnbBgimrbGPxD2pmoF0MKZQUTbYPiK/jnVhXkqEO+cxYROSujAg8TkX3d7Vzdzzt9S5 jAbqhsbS/zbtyleNt5daof2+jmPSFnFucJ17kB3vqdw== X-Received: by 2002:a05:6000:1acb:: with SMTP id i11mr33901261wry.68.1617694975646; Tue, 06 Apr 2021 00:42:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBgJ29Q8kLgm96eyYaDgv9lrgSX6WAUdxiyLTBZQLm0lIymW7kzWKpwg8SwRxbvqmYyS/tzQ== X-Received: by 2002:a05:6000:1acb:: with SMTP id i11mr33901245wry.68.1617694975481; Tue, 06 Apr 2021 00:42:55 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id s5sm15349625wrw.2.2021.04.06.00.42.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 00:42:54 -0700 (PDT) Subject: Re: [PATCH v2] nfc: s3fwrn5: remove unnecessary label To: samirweng1979 , k.opasiak@samsung.com Cc: linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wengjianfeng References: <20210406015954.10988-1-samirweng1979@163.com> From: Krzysztof Kozlowski Message-ID: <07a98473-1e85-cd28-3854-063a73592155@canonical.com> Date: Tue, 6 Apr 2021 09:42:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210406015954.10988-1-samirweng1979@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2021 03:59, samirweng1979 wrote: > From: wengjianfeng > > In function s3fwrn5_nci_post_setup, the variable ret is assigned then > goto out label, which just return ret, so we use return to replace it. > Other goto sentences are similar, we use return sentences to replace > goto sentences and delete out label. > > Signed-off-by: wengjianfeng > --- > drivers/nfc/s3fwrn5/core.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof