All of lore.kernel.org
 help / color / mirror / Atom feed
* [xenomai-images][PATCH] linux-xenomai: x86: Enable vfat support for UEFI boot
@ 2021-04-08 15:12 Florian Bezdeka
  2021-04-08 17:24 ` Jan Kiszka
  0 siblings, 1 reply; 4+ messages in thread
From: Florian Bezdeka @ 2021-04-08 15:12 UTC (permalink / raw)
  To: xenomai

Trying to boot up the example image on an x86 board with UEFI failed
because vfat support was missing. The x86 defconfig has been
re-synchronized with the arm64 defconfig to enable UEFI boot support.

Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---
 recipes-kernel/linux/files/amd64_defconfig | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/recipes-kernel/linux/files/amd64_defconfig b/recipes-kernel/linux/files/amd64_defconfig
index bc5cd0b..2b7e63f 100644
--- a/recipes-kernel/linux/files/amd64_defconfig
+++ b/recipes-kernel/linux/files/amd64_defconfig
@@ -3609,7 +3609,10 @@ CONFIG_FSCACHE_HISTOGRAM=y
 # DOS/FAT/NT Filesystems
 #
 # CONFIG_MSDOS_FS is not set
-# CONFIG_VFAT_FS is not set
+CONFIG_VFAT_FS=y
+CONFIG_FAT_DEFAULT_CODEPAGE=437
+CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
+# CONFIG_FAT_DEFAULT_UTF8 is not set
 # CONFIG_NTFS_FS is not set
 
 #
@@ -3681,8 +3684,8 @@ CONFIG_9P_FSCACHE=y
 CONFIG_9P_FS_POSIX_ACL=y
 # CONFIG_9P_FS_SECURITY is not set
 CONFIG_NLS=y
-CONFIG_NLS_DEFAULT="cp437"
-# CONFIG_NLS_CODEPAGE_437 is not set
+CONFIG_NLS_DEFAULT="iso8859-1"
+CONFIG_NLS_CODEPAGE_437=y
 # CONFIG_NLS_CODEPAGE_737 is not set
 # CONFIG_NLS_CODEPAGE_775 is not set
 # CONFIG_NLS_CODEPAGE_850 is not set
@@ -3706,7 +3709,7 @@ CONFIG_NLS_DEFAULT="cp437"
 # CONFIG_NLS_CODEPAGE_1250 is not set
 # CONFIG_NLS_CODEPAGE_1251 is not set
 # CONFIG_NLS_ASCII is not set
-# CONFIG_NLS_ISO8859_1 is not set
+CONFIG_NLS_ISO8859_1=y
 # CONFIG_NLS_ISO8859_2 is not set
 # CONFIG_NLS_ISO8859_3 is not set
 # CONFIG_NLS_ISO8859_4 is not set
-- 
2.30.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [xenomai-images][PATCH] linux-xenomai: x86: Enable vfat support for UEFI boot
  2021-04-08 15:12 [xenomai-images][PATCH] linux-xenomai: x86: Enable vfat support for UEFI boot Florian Bezdeka
@ 2021-04-08 17:24 ` Jan Kiszka
  2021-04-12  7:45   ` Bezdeka, Florian
  0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2021-04-08 17:24 UTC (permalink / raw)
  To: Florian Bezdeka, xenomai

On 08.04.21 17:12, Florian Bezdeka wrote:
> Trying to boot up the example image on an x86 board with UEFI failed
> because vfat support was missing. The x86 defconfig has been
> re-synchronized with the arm64 defconfig to enable UEFI boot support.
> 
> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
>  recipes-kernel/linux/files/amd64_defconfig | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes-kernel/linux/files/amd64_defconfig b/recipes-kernel/linux/files/amd64_defconfig
> index bc5cd0b..2b7e63f 100644
> --- a/recipes-kernel/linux/files/amd64_defconfig
> +++ b/recipes-kernel/linux/files/amd64_defconfig
> @@ -3609,7 +3609,10 @@ CONFIG_FSCACHE_HISTOGRAM=y
>  # DOS/FAT/NT Filesystems
>  #
>  # CONFIG_MSDOS_FS is not set
> -# CONFIG_VFAT_FS is not set
> +CONFIG_VFAT_FS=y
> +CONFIG_FAT_DEFAULT_CODEPAGE=437
> +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
> +# CONFIG_FAT_DEFAULT_UTF8 is not set
>  # CONFIG_NTFS_FS is not set
>  
>  #
> @@ -3681,8 +3684,8 @@ CONFIG_9P_FSCACHE=y
>  CONFIG_9P_FS_POSIX_ACL=y
>  # CONFIG_9P_FS_SECURITY is not set
>  CONFIG_NLS=y
> -CONFIG_NLS_DEFAULT="cp437"
> -# CONFIG_NLS_CODEPAGE_437 is not set
> +CONFIG_NLS_DEFAULT="iso8859-1"
> +CONFIG_NLS_CODEPAGE_437=y
>  # CONFIG_NLS_CODEPAGE_737 is not set
>  # CONFIG_NLS_CODEPAGE_775 is not set
>  # CONFIG_NLS_CODEPAGE_850 is not set
> @@ -3706,7 +3709,7 @@ CONFIG_NLS_DEFAULT="cp437"
>  # CONFIG_NLS_CODEPAGE_1250 is not set
>  # CONFIG_NLS_CODEPAGE_1251 is not set
>  # CONFIG_NLS_ASCII is not set
> -# CONFIG_NLS_ISO8859_1 is not set
> +CONFIG_NLS_ISO8859_1=y
>  # CONFIG_NLS_ISO8859_2 is not set
>  # CONFIG_NLS_ISO8859_3 is not set
>  # CONFIG_NLS_ISO8859_4 is not set
> 

I wonder if we should rather store a savedefconfig result here. That
might have prevented this. Or are those options not part of the
x86_64-defconfig?

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [xenomai-images][PATCH] linux-xenomai: x86: Enable vfat support for UEFI boot
  2021-04-08 17:24 ` Jan Kiszka
@ 2021-04-12  7:45   ` Bezdeka, Florian
  2021-04-12  7:46     ` Jan Kiszka
  0 siblings, 1 reply; 4+ messages in thread
From: Bezdeka, Florian @ 2021-04-12  7:45 UTC (permalink / raw)
  To: xenomai, jan.kiszka

On Thu, 2021-04-08 at 19:24 +0200, Jan Kiszka wrote:
> On 08.04.21 17:12, Florian Bezdeka wrote:
> > Trying to boot up the example image on an x86 board with UEFI failed
> > because vfat support was missing. The x86 defconfig has been
> > re-synchronized with the arm64 defconfig to enable UEFI boot support.
> > 
> > Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> > ---
> >  recipes-kernel/linux/files/amd64_defconfig | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/recipes-kernel/linux/files/amd64_defconfig b/recipes-kernel/linux/files/amd64_defconfig
> > index bc5cd0b..2b7e63f 100644
> > --- a/recipes-kernel/linux/files/amd64_defconfig
> > +++ b/recipes-kernel/linux/files/amd64_defconfig
> > @@ -3609,7 +3609,10 @@ CONFIG_FSCACHE_HISTOGRAM=y
> >  # DOS/FAT/NT Filesystems
> >  #
> >  # CONFIG_MSDOS_FS is not set
> > -# CONFIG_VFAT_FS is not set
> > +CONFIG_VFAT_FS=y
> > +CONFIG_FAT_DEFAULT_CODEPAGE=437
> > +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
> > +# CONFIG_FAT_DEFAULT_UTF8 is not set
> >  # CONFIG_NTFS_FS is not set
> >  #
> > @@ -3681,8 +3684,8 @@ CONFIG_9P_FSCACHE=y
> >  CONFIG_9P_FS_POSIX_ACL=y
> >  # CONFIG_9P_FS_SECURITY is not set
> >  CONFIG_NLS=y
> > -CONFIG_NLS_DEFAULT="cp437"
> > -# CONFIG_NLS_CODEPAGE_437 is not set
> > +CONFIG_NLS_DEFAULT="iso8859-1"
> > +CONFIG_NLS_CODEPAGE_437=y
> >  # CONFIG_NLS_CODEPAGE_737 is not set
> >  # CONFIG_NLS_CODEPAGE_775 is not set
> >  # CONFIG_NLS_CODEPAGE_850 is not set
> > @@ -3706,7 +3709,7 @@ CONFIG_NLS_DEFAULT="cp437"
> >  # CONFIG_NLS_CODEPAGE_1250 is not set
> >  # CONFIG_NLS_CODEPAGE_1251 is not set
> >  # CONFIG_NLS_ASCII is not set
> > -# CONFIG_NLS_ISO8859_1 is not set
> > +CONFIG_NLS_ISO8859_1=y
> >  # CONFIG_NLS_ISO8859_2 is not set
> >  # CONFIG_NLS_ISO8859_3 is not set
> >  # CONFIG_NLS_ISO8859_4 is not set
> > 
> 
> I wonder if we should rather store a savedefconfig result here. That
> might have prevented this. Or are those options not part of the
> x86_64-defconfig?

On the long run: Yes, sounds reasonable. 

Converting that to a defconfig now will trigger a lot of reformatting,
resulting in a big diff. Other configs (arm64, armhf) are affected as
well. Maybe something we should postpone to 3.2, so we get the
necessary testing?

> 
> Jan
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [xenomai-images][PATCH] linux-xenomai: x86: Enable vfat support for UEFI boot
  2021-04-12  7:45   ` Bezdeka, Florian
@ 2021-04-12  7:46     ` Jan Kiszka
  0 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2021-04-12  7:46 UTC (permalink / raw)
  To: Bezdeka, Florian (T RDA IOT SES-DE), xenomai

On 12.04.21 09:45, Bezdeka, Florian (T RDA IOT SES-DE) wrote:
> On Thu, 2021-04-08 at 19:24 +0200, Jan Kiszka wrote:
>> On 08.04.21 17:12, Florian Bezdeka wrote:
>>> Trying to boot up the example image on an x86 board with UEFI failed
>>> because vfat support was missing. The x86 defconfig has been
>>> re-synchronized with the arm64 defconfig to enable UEFI boot support.
>>>
>>> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
>>> ---
>>>  recipes-kernel/linux/files/amd64_defconfig | 11 +++++++----
>>>  1 file changed, 7 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/recipes-kernel/linux/files/amd64_defconfig b/recipes-kernel/linux/files/amd64_defconfig
>>> index bc5cd0b..2b7e63f 100644
>>> --- a/recipes-kernel/linux/files/amd64_defconfig
>>> +++ b/recipes-kernel/linux/files/amd64_defconfig
>>> @@ -3609,7 +3609,10 @@ CONFIG_FSCACHE_HISTOGRAM=y
>>>  # DOS/FAT/NT Filesystems
>>>  #
>>>  # CONFIG_MSDOS_FS is not set
>>> -# CONFIG_VFAT_FS is not set
>>> +CONFIG_VFAT_FS=y
>>> +CONFIG_FAT_DEFAULT_CODEPAGE=437
>>> +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
>>> +# CONFIG_FAT_DEFAULT_UTF8 is not set
>>>  # CONFIG_NTFS_FS is not set
>>>  #
>>> @@ -3681,8 +3684,8 @@ CONFIG_9P_FSCACHE=y
>>>  CONFIG_9P_FS_POSIX_ACL=y
>>>  # CONFIG_9P_FS_SECURITY is not set
>>>  CONFIG_NLS=y
>>> -CONFIG_NLS_DEFAULT="cp437"
>>> -# CONFIG_NLS_CODEPAGE_437 is not set
>>> +CONFIG_NLS_DEFAULT="iso8859-1"
>>> +CONFIG_NLS_CODEPAGE_437=y
>>>  # CONFIG_NLS_CODEPAGE_737 is not set
>>>  # CONFIG_NLS_CODEPAGE_775 is not set
>>>  # CONFIG_NLS_CODEPAGE_850 is not set
>>> @@ -3706,7 +3709,7 @@ CONFIG_NLS_DEFAULT="cp437"
>>>  # CONFIG_NLS_CODEPAGE_1250 is not set
>>>  # CONFIG_NLS_CODEPAGE_1251 is not set
>>>  # CONFIG_NLS_ASCII is not set
>>> -# CONFIG_NLS_ISO8859_1 is not set
>>> +CONFIG_NLS_ISO8859_1=y
>>>  # CONFIG_NLS_ISO8859_2 is not set
>>>  # CONFIG_NLS_ISO8859_3 is not set
>>>  # CONFIG_NLS_ISO8859_4 is not set
>>>
>>
>> I wonder if we should rather store a savedefconfig result here. That
>> might have prevented this. Or are those options not part of the
>> x86_64-defconfig?
> 
> On the long run: Yes, sounds reasonable.
> 
> Converting that to a defconfig now will trigger a lot of reformatting,
> resulting in a big diff. Other configs (arm64, armhf) are affected as
> well. Maybe something we should postpone to 3.2, so we get the
> necessary testing?

I'm fine with doing that as a separate patch, but already because of the
broad range of kernel versions we are testing NOW (4.4 - 5.10), we
should convert ASAP.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-12  7:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 15:12 [xenomai-images][PATCH] linux-xenomai: x86: Enable vfat support for UEFI boot Florian Bezdeka
2021-04-08 17:24 ` Jan Kiszka
2021-04-12  7:45   ` Bezdeka, Florian
2021-04-12  7:46     ` Jan Kiszka

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.