From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Thu, 14 May 2020 00:25:14 +0000 Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework Message-Id: <07bb6080f8be9f6613f460e2d6e19f3d456e219c.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> In-Reply-To: <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> To: Sumit Garg , zohar@linux.ibm.com, jejb@linux.ibm.com Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org, op-tee@lists.trustedfirmware.org, corbet@lwn.net, janne.karhunen@gmail.com, linux-doc@vger.kernel.org, jmorris@namei.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Markus.Wamser@mixed-mode.de, casey@schaufler-ca.com, linux-integrity@vger.kernel.org, jens.wiklander@linaro.org, linux-arm-kernel@lists.infradead.org, serge@hallyn.com On Wed, 2020-05-06 at 15:10 +0530, Sumit Garg wrote: > Current trusted keys framework is tightly coupled to use TPM device as > an underlying implementation which makes it difficult for implementations > like Trusted Execution Environment (TEE) etc. to provide trusked keys > support in case platform doesn't posses a TPM device. > > So this patch tries to add generic trusted keys framework where underlying > implemtations like TPM, TEE etc. could be easily plugged-in. > > Suggested-by: Jarkko Sakkinen > Signed-off-by: Sumit Garg I tend to agree how this is implemented and could merge it as such. I'm just thinking if we could refine this patch in a way that instead of copying TRUSTED_DEBUG macro we could just replace pr_info() statements with pr_debug()? /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42630C433DF for ; Thu, 14 May 2020 00:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FB80205ED for ; Thu, 14 May 2020 00:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733121AbgENAZ1 (ORCPT ); Wed, 13 May 2020 20:25:27 -0400 Received: from mga01.intel.com ([192.55.52.88]:53240 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732946AbgENAZ0 (ORCPT ); Wed, 13 May 2020 20:25:26 -0400 IronPort-SDR: pw48jvxnERiPyZBSrKdMTKCsAM/mOxATAGPHq+ahdRvbcbobJR3CJmk+E8d8dCqr2XfgWJM5cf 6NZtcSQQgggg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 17:25:26 -0700 IronPort-SDR: LmigXyC+PKXEwMmfY0sVl4rNnEd46L+o3kglBun/40P0Ry5MzcqKSfH2nUh0qUui+AXBzt99h0 L6gOZAQubFMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,389,1583222400"; d="scan'208";a="262661894" Received: from gliber-mobl1.ger.corp.intel.com ([10.249.38.41]) by orsmga003.jf.intel.com with ESMTP; 13 May 2020 17:25:20 -0700 Message-ID: <07bb6080f8be9f6613f460e2d6e19f3d456e219c.camel@linux.intel.com> Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework From: Jarkko Sakkinen To: Sumit Garg , zohar@linux.ibm.com, jejb@linux.ibm.com Cc: dhowells@redhat.com, jens.wiklander@linaro.org, corbet@lwn.net, jmorris@namei.org, serge@hallyn.com, casey@schaufler-ca.com, janne.karhunen@gmail.com, daniel.thompson@linaro.org, Markus.Wamser@mixed-mode.de, keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, tee-dev@lists.linaro.org Date: Thu, 14 May 2020 03:25:14 +0300 In-Reply-To: <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-05-06 at 15:10 +0530, Sumit Garg wrote: > Current trusted keys framework is tightly coupled to use TPM device as > an underlying implementation which makes it difficult for implementations > like Trusted Execution Environment (TEE) etc. to provide trusked keys > support in case platform doesn't posses a TPM device. > > So this patch tries to add generic trusted keys framework where underlying > implemtations like TPM, TEE etc. could be easily plugged-in. > > Suggested-by: Jarkko Sakkinen > Signed-off-by: Sumit Garg I tend to agree how this is implemented and could merge it as such. I'm just thinking if we could refine this patch in a way that instead of copying TRUSTED_DEBUG macro we could just replace pr_info() statements with pr_debug()? /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38447C433E1 for ; Thu, 14 May 2020 00:25:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 345DC205ED for ; Thu, 14 May 2020 00:25:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pi1B9umY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 345DC205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oj6tkVvPz7Hcb+iK1Gg1IIKpq4ObKrpwXQKGBUm+C54=; b=Pi1B9umYSdVcqo 1NQtRgJD+xT6hWDC9+/a12Uo30PrNLQPl1saH4SPffwZaE4JzW8cOGwJN0VCLR4KTbsGv+z8EO2Ur lgF5NltN+1vaAToFHvwhxkdsgFtHznfYUmuGqiEB0UIumpf10BHU9pBkNlLm8VwFZZaklBUYmQuCO mf6z4kwcY1NxAjlC4YH8b/whbfreUPwo77kSte0gUkjTRWtyJdCy0go1unf1z98FyBiYkDiPJeVGM YWeUI726YTDyti6G1XIesqAC+nFaTXrB0uCppCVdQdLE8J56NtwMQ4VtaQOEH7OesDFOKG+s1EFuC Olwrv/djkwrAyNWzppxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZ1gp-0000vZ-DZ; Thu, 14 May 2020 00:25:31 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZ1gm-0000uQ-6j for linux-arm-kernel@lists.infradead.org; Thu, 14 May 2020 00:25:29 +0000 IronPort-SDR: 9QNcjs9bXsaAftfhhML8pZt2+zRY/lmDejgNRxmSo5+pGje+uiI8tFj9ABrOu03KggLbVBsoX2 XmlhoJK8WMFg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 17:25:26 -0700 IronPort-SDR: LmigXyC+PKXEwMmfY0sVl4rNnEd46L+o3kglBun/40P0Ry5MzcqKSfH2nUh0qUui+AXBzt99h0 L6gOZAQubFMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,389,1583222400"; d="scan'208";a="262661894" Received: from gliber-mobl1.ger.corp.intel.com ([10.249.38.41]) by orsmga003.jf.intel.com with ESMTP; 13 May 2020 17:25:20 -0700 Message-ID: <07bb6080f8be9f6613f460e2d6e19f3d456e219c.camel@linux.intel.com> Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework From: Jarkko Sakkinen To: Sumit Garg , zohar@linux.ibm.com, jejb@linux.ibm.com Date: Thu, 14 May 2020 03:25:14 +0300 In-Reply-To: <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Evolution 3.36.1-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_172528_289253_E86F84EF X-CRM114-Status: UNSURE ( 8.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org, op-tee@lists.trustedfirmware.org, corbet@lwn.net, janne.karhunen@gmail.com, linux-doc@vger.kernel.org, jmorris@namei.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Markus.Wamser@mixed-mode.de, casey@schaufler-ca.com, linux-integrity@vger.kernel.org, jens.wiklander@linaro.org, linux-arm-kernel@lists.infradead.org, serge@hallyn.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-05-06 at 15:10 +0530, Sumit Garg wrote: > Current trusted keys framework is tightly coupled to use TPM device as > an underlying implementation which makes it difficult for implementations > like Trusted Execution Environment (TEE) etc. to provide trusked keys > support in case platform doesn't posses a TPM device. > > So this patch tries to add generic trusted keys framework where underlying > implemtations like TPM, TEE etc. could be easily plugged-in. > > Suggested-by: Jarkko Sakkinen > Signed-off-by: Sumit Garg I tend to agree how this is implemented and could merge it as such. I'm just thinking if we could refine this patch in a way that instead of copying TRUSTED_DEBUG macro we could just replace pr_info() statements with pr_debug()? /Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel