From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF6aG-0005ey-ET for qemu-devel@nongnu.org; Fri, 12 Apr 2019 20:31:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hF6aF-0001Bg-HE for qemu-devel@nongnu.org; Fri, 12 Apr 2019 20:31:52 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:33271) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hF6aF-0001As-3U for qemu-devel@nongnu.org; Fri, 12 Apr 2019 20:31:51 -0400 Received: by mail-pg1-x542.google.com with SMTP id k19so5948402pgh.0 for ; Fri, 12 Apr 2019 17:31:51 -0700 (PDT) References: <20190411100836.646-1-david@redhat.com> <20190411100836.646-30-david@redhat.com> From: Richard Henderson Message-ID: <07c96b48-c3f9-096c-1cd6-d95bce3c3ccd@linaro.org> Date: Fri, 12 Apr 2019 14:31:46 -1000 MIME-Version: 1.0 In-Reply-To: <20190411100836.646-30-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 29/41] s390x/tcg: Implement VECTOR ELEMENT SHIFT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Cornelia Huck , Thomas Huth , Richard Henderson On 4/11/19 12:08 AM, David Hildenbrand wrote: > Only for one special case we can reuse real gvec helpers. Mostly > rely on oom helpers. > > One important thing to take care of is always to properly mask of > unused bits from the shift count. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 18 +++++ > target/s390x/insn-data.def | 9 +++ > target/s390x/translate_vx.inc.c | 113 ++++++++++++++++++++++++++++++++ > target/s390x/vec_int_helper.c | 99 ++++++++++++++++++++++++++++ > 4 files changed, 239 insertions(+) Again, I should fill out these in gvec... Reviewed-by: Richard Henderson r~