From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>,
Wedson Almeida Filho <wedsonaf@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86: Use asm-goto to implement mutex fast path on x86-64
Date: Mon, 01 Jul 2013 07:45:41 -0700 [thread overview]
Message-ID: <07ca6bb4-2153-48ec-9171-dd7d66720d96@email.android.com> (raw)
In-Reply-To: <20130701143646.GG23515@pd.tnic>
Right... brain not awake yet, sorry, and responding from my phone.
I am not to worried about trading off a bit of additional branch mispredicts if everything else wins, but Ingo does have a valid question if we are measuring the right thing.
The effect is definitely big enough that it would be good to understand it one way or the other.
And regardless of the source... nice job!
Borislav Petkov <bp@alien8.de> wrote:
>On Mon, Jul 01, 2013 at 07:30:14AM -0700, H. Peter Anvin wrote:
>> Unconditional branches don't need prediction. The branch predictor
>> is used for conditional branches and in some hardware designs for
>> indirect branches. Unconditional direct branches never go through
>> the branch predictor simply because the front end can know with 100%
>> certainty where the flow of control will be.
>
>I meant the conditional Jcc branches:
>
>ffffffff81774920 <mutex_lock>:
>
>...
>
>ffffffff8177492d: f0 ff 0b lock decl (%rbx)
>ffffffff81774930: 79 08 jns ffffffff8177493a
><mutex_lock+0x1a>
>
>
>
>ffffffff81774730 <mutex_unlock>:
>
>...
>
>ffffffff81774738: f0 ff 07 lock incl (%rdi)
>ffffffff8177473b: 7f 0a jg ffffffff81774747
><mutex_unlock+0x17>
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
next prev parent reply other threads:[~2013-07-01 14:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 10:54 [PATCH] x86: Use asm-goto to implement mutex fast path on x86-64 Wedson Almeida Filho
2013-06-28 11:19 ` Ingo Molnar
2013-06-28 14:09 ` Borislav Petkov
2013-06-28 14:12 ` H. Peter Anvin
2013-06-28 15:15 ` Peter Zijlstra
2013-06-28 16:41 ` [PATCH] x86, cpufeature: Use new CC_HAVE_ASM_GOTO Borislav Petkov
2013-07-05 14:24 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2013-06-29 23:56 ` [PATCH] x86: Use asm-goto to implement mutex fast path on x86-64 Wedson Almeida Filho
2013-06-30 22:00 ` Borislav Petkov
2013-07-01 7:50 ` Ingo Molnar
2013-07-01 10:23 ` Borislav Petkov
2013-07-01 11:11 ` Ingo Molnar
2013-07-01 12:29 ` Borislav Petkov
2013-07-01 12:50 ` Ingo Molnar
2013-07-01 14:48 ` Borislav Petkov
2013-07-01 22:28 ` Borislav Petkov
2013-07-01 22:35 ` Wedson Almeida Filho
2013-07-01 22:44 ` Borislav Petkov
2013-07-02 6:39 ` Ingo Molnar
2013-07-02 10:29 ` Borislav Petkov
2013-07-01 14:30 ` H. Peter Anvin
2013-07-01 14:36 ` Borislav Petkov
2013-07-01 14:45 ` H. Peter Anvin [this message]
2013-07-01 14:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07ca6bb4-2153-48ec-9171-dd7d66720d96@email.android.com \
--to=hpa@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wedsonaf@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.