From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761450AbcLRT3q (ORCPT ); Sun, 18 Dec 2016 14:29:46 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35638 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757273AbcLRT3o (ORCPT ); Sun, 18 Dec 2016 14:29:44 -0500 Subject: Re: [PATCH] printk: Remove no longer used second struct cont To: Linus Torvalds , Sergey Senozhatsky References: <1481806438-30185-1-git-send-email-geert@linux-m68k.org> <20161215162336.GA18152@pathway.suse.cz> <20161216013706.GA20445@jagdpanzerIV.localdomain> Cc: Petr Mladek , Geert Uytterhoeven , Joe Perches , Steven Rostedt , Mark Rutland , Andrew Morton , Linux Kernel Mailing List From: Scott Matheina Message-ID: <07cb49cf-857b-1aa0-16e3-f9f06083dcc0@matheina.com> Date: Sun, 18 Dec 2016 13:29:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/2016 07:50 PM, Linus Torvalds wrote: > On Thu, Dec 15, 2016 at 5:37 PM, Sergey Senozhatsky > wrote: >> basically I'm talking about a bunch of 80-cols fixups. > Please don't. > > Nobody uses a vt100 terminal any more. The 80-column wrapping is > excessive, and makes things like "grep" not work as well. > > No, we still don't want excessively long lines, but that's generally > mainly because > > (a) we don't want to have excessively _complicated_ lines > > (b) we don't want to have excessively deep indentation (so if line > length is due to 4+ levels of indentation, that's usually the primary > problem). > > (c) email quoting gets iffier and uglier, so short lines always are > preferred if possible > > but in general, aside from those concerns, a long legible line is > generally preferred over just adding line breaks for the very > _occasional_ line. > > At the 100-column mark you almost have to break, because at that point > people may start to be actually limited by their displays, but 80 > columns generally isn't it. > > In fact, I thought we already upped the check-patch limit to 100? checkpatch.pl line 50 my $max_line_length = 80; Not changed as of yet. > > Linus