From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F0CC433E0 for ; Fri, 29 Jan 2021 00:16:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 691F264E00 for ; Fri, 29 Jan 2021 00:16:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 691F264E00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ai4A53uNqJv0cL5DVTZWscJkUxjWXhrpWf5RlZZ0YI4=; b=K2xl8c81a14KORwhU0Dv+Hz6F TL3ZPoBsjui8dPCUDHCjVThsfAgkVMBiFWiupVyUEokjsA5S4Ebrq0xlSpTk3WR2jEOWxynan2NT2 GfqgAxgBywsSJIIp7Bb81rptwm2oa/VHOcptTaSaZ8NYf6Y1bKpW1HddIg0lJEopZABhJzYSCMAWk bu0RycyPzCmyOTpmE55pENChsOf4SZRPBTdIfun+A1zARSdauLm4w6bKjCYpcBbsGbCaNwDOwKs+z dT1kPI2YLwz+HCdLj4uwKo7hLdqIc1y4/7Olh0Wz5w4MQeQ2+/2iRDqSZEA5Lvf5QRFkwv2SMrLCt EtiNDuIeQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5HRI-0003ww-7V; Fri, 29 Jan 2021 00:15:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5HRE-0003wH-Ui for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 00:15:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C596413D5; Thu, 28 Jan 2021 16:14:57 -0800 (PST) Received: from [10.57.35.163] (unknown [10.57.35.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FB8C3F66E; Thu, 28 Jan 2021 16:14:57 -0800 (PST) Subject: Re: [PATCH 1/2] perf/arm-cmn: Fix PMU instance naming To: Will Deacon References: <649a2281233f193d59240b13ed91b57337c77b32.1611839564.git.robin.murphy@arm.com> <20210128201422.GB3016@willie-the-truck> From: Robin Murphy Message-ID: <07ec98a6-e773-69bd-d2fa-6737e433b43d@arm.com> Date: Fri, 29 Jan 2021 00:14:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210128201422.GB3016@willie-the-truck> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_191501_111428_E8AF50DD X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-01-28 20:14, Will Deacon wrote: > On Thu, Jan 28, 2021 at 01:12:43PM +0000, Robin Murphy wrote: >> Although it's neat to avoid the suffix for the typical case of a >> single PMU, it means systems with multiple CMN instances end up with >> inconsistent naming. I think it also breaks perf tool's "uncore alias" >> logic if the common instance prefix is also the full name of one. >> >> Avoid any surprises by not trying to be clever and simply numbering >> every instance, even when it might technically prove redundant. >> >> Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") >> Signed-off-by: Robin Murphy >> --- >> Documentation/admin-guide/perf/arm-cmn.rst | 2 +- >> drivers/perf/arm-cmn.c | 13 ++++--------- >> 2 files changed, 5 insertions(+), 10 deletions(-) > > Hmm, so usually I'd push-back on changes like this because it's a > user-visible change, however in this case we're talking about a pretty > niche PMU and a relatively new driver so I think we should proceed. However, > if anybody complains then we'll need to support them in one way or another. Yeah, I'm kicking myself for not remembering about the aliasing thing from the start - it came up tangentially from conversation with some interested users the other day - so hopefully the practicality will outweigh any possible early-adopter inconvenience. Thanks, Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel