From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33068)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bDtgM-0004sL-W8
	for qemu-devel@nongnu.org; Fri, 17 Jun 2016 09:19:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bDtgK-0003gW-Qn
	for qemu-devel@nongnu.org; Fri, 17 Jun 2016 09:19:33 -0400
References: <1466169069-29375-1-git-send-email-real@ispras.ru>
	<1466169069-29375-4-git-send-email-real@ispras.ru>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <07f85ae6-2145-90a7-ff4d-29d04cb961b6@redhat.com>
Date: Fri, 17 Jun 2016 15:19:18 +0200
MIME-Version: 1.0
In-Reply-To: <1466169069-29375-4-git-send-email-real@ispras.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/13] vmport: identify vmport type by
 macro TYPE_VMPORT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Efimov Vasily <real@ispras.ru>, qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Kirill Batuzov <batuzovk@ispras.ru>



On 17/06/2016 15:10, Efimov Vasily wrote:
> Currently vmport device is identified by the string literal. Using a
> preprocessor alias instead is preferable.
> 
> Signed-off-by: Efimov Vasily <real@ispras.ru>
> ---
>  hw/misc/vmport.c     | 1 -
>  include/hw/i386/pc.h | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c
> index 6896789..c763811 100644
> --- a/hw/misc/vmport.c
> +++ b/hw/misc/vmport.c
> @@ -36,7 +36,6 @@
>  #define VMPORT_ENTRIES 0x2c
>  #define VMPORT_MAGIC   0x564D5868
>  
> -#define TYPE_VMPORT "vmport"
>  #define VMPORT(obj) OBJECT_CHECK(VMPortState, (obj), TYPE_VMPORT)
>  
>  typedef struct VMPortState
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 9ca2309..aab3a53 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -199,11 +199,12 @@ typedef struct GSIState {
>  void gsi_handler(void *opaque, int n, int level);
>  
>  /* vmport.c */
> +#define TYPE_VMPORT "vmport"
>  typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
>  
>  static inline void vmport_init(ISABus *bus)
>  {
> -    isa_create_simple(bus, "vmport");
> +    isa_create_simple(bus, TYPE_VMPORT);
>  }
>  
>  void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>