Re: [PATCH 3/3] station, eapol: Set up eap-tls-common for session caching

[Denis Kenzior <denkenz@gmail.com>]

Hi Andrew,

On 11/17/22 07:56, Andrew Zaborowski wrote:
> Use eap_set_peer_id() to set a string identifying the TLS server,
> currently the hex-encoded SSID of the network, to be used as group name
> and primary key in the session cache l_settings object.  Provide pointers
> to storage_eap_tls_cache_{load,sync} to eap-tls-common.c using
> eap_tls_set_session_cache_ops().  Listen to Known Network removed
> signals and call eap_tls_forget_peer() to have any session related to
> the network also dropped from the cache.
> ---
>   src/eapol.c   |  6 ++++++
>   src/station.c | 28 ++++++++++++++++++++++++++++
>   2 files changed, 34 insertions(+)
> 

<snip>

> @@ -5139,6 +5159,12 @@ static int station_init(void)
>   
>   	watchlist_init(&event_watches, NULL);
>   
> +	eap_tls_set_session_cache_ops(storage_eap_tls_cache_load,
> +					storage_eap_tls_cache_sync);
> +	known_networks_watch = known_networks_watch_add(
> +						station_known_networks_changed,
> +						NULL, NULL);

This requires a dependency between station and known_networks module since the 
watchlist is initialized in known_networks_init.  I added this in a follow on 
commit.  Please have a look.

> +
>   	return 0;
>   }
>   

All three applied, thanks.

Regards,
-Denis