Re: [PATCH][next] wireless: wext-spy: Fix out-of-bounds warning

From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH][next] wireless: wext-spy: Fix out-of-bounds warning
Date: Thu, 22 Apr 2021 15:03:17 -0500	[thread overview]
Message-ID: <07fc2c3a-ffba-8dad-1ddf-d4da7482c65a@embeddedor.com> (raw)
In-Reply-To: <317099c78edb9fdde3db3f1e7c9a4f77529b281a.camel@sipsolutions.net>


On 4/22/21 02:04, Johannes Berg wrote:
> On Wed, 2021-04-21 at 18:43 -0500, Gustavo A. R. Silva wrote:
>>
>>  	/* Just do it */
>> -	memcpy(&(spydata->spy_thr_low), &(threshold->low),
>> -	       2 * sizeof(struct iw_quality));
>> +	memcpy(&spydata->spy_thr_low, &threshold->low, sizeof(threshold->low));
>> +	memcpy(&spydata->spy_thr_high, &threshold->high, sizeof(threshold->high));
>>
> 
> It would've been really simple to stick to 80 columns here (and
> everywhere in the patch), please do that.
> 
> Also, why not just use struct assigments?
> 
> 	spydata->spy_thr_low = threshold->low;
> 
> etc.
> Done: https://lore.kernel.org/lkml/20210422200032.GA168995@embeddedor/
> Seems far simpler (and shorter lines).

Done:
	https://lore.kernel.org/lkml/20210422200032.GA168995@embeddedor/

Thanks for the feedback.
--
Gustavo