Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

[Pierre Morel <pmorel@linux.ibm.com>]

On 7/15/21 8:16 AM, Markus Armbruster wrote:
> Pierre Morel <pmorel@linux.ibm.com> writes:
> 
>> Drawers and Books are levels 4 and 3 of the S390 CPU
>> topology.
>> We allow the user to define these levels and we will
>> store the values inside the S390CcwMachineState.
> 
> Double-checking: are these members specific to S390?

Yes AFAIK

> 
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
> 
> [...]
> 
>> diff --git a/qapi/machine.json b/qapi/machine.json
>> index c3210ee1fb..98aff804c6 100644
>> --- a/qapi/machine.json
>> +++ b/qapi/machine.json
>> @@ -883,6 +883,8 @@
>     ##
>     # @CpuInstanceProperties:
>     #
>     # List of properties to be used for hotplugging a CPU instance,
>     # it should be passed by management with device_add command when
>     # a CPU is being hotplugged.
>     #
>     # @node-id: NUMA node ID the CPU belongs to
>     # @socket-id: socket number within node/board the CPU belongs to
> 
> Missing: documentation for your new members.

Oh yes, right forgot these, thanks.

> 
>     # @die-id: die number within node/board the CPU belongs to (Since 4.1)
>     # @core-id: core number within die the CPU belongs to
>     # @thread-id: thread number within core the CPU belongs to
>     #
>     # Note: currently there are 5 properties that could be present
>     #       but management should be prepared to pass through other
>     #       properties with device_add command to allow for future
>     #       interface extension. This also requires the filed names to be kept in
>     #       sync with the properties passed to -device/device_add.
>     #
>     # Since: 2.7
>     ##
>     { 'struct': 'CpuInstanceProperties',
>>     'data': { '*node-id': 'int',
>>               '*socket-id': 'int',
>>               '*die-id': 'int',
>> +            '*drawer-id': 'int',
>> +            '*book-id': 'int',
>>               '*core-id': 'int',
>>               '*thread-id': 'int'
>>     }
> 
> [...]
> 
> 

-- 
Pierre Morel
IBM Lab Boeblingen