From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "ming.lei@redhat.com" , "axboe@kernel.dk" CC: "hch@lst.de" , "tomi@nomi.cz" , "linux-block@vger.kernel.org" , "ps@pks.im" , "soprwa@gmail.com" , "stern@rowland.harvard.edu" , "stable@vger.kernel.org" Subject: Re: [PATCH] block: really disable runtime-pm for blk-mq Date: Mon, 30 Jul 2018 20:43:12 +0000 Message-ID: <08023c404ab13ef6e1ccbf6efdae3dbc6bb484a4.camel@wdc.com> References: <20180730120219.24164-1-ming.lei@redhat.com> In-Reply-To: <20180730120219.24164-1-ming.lei@redhat.com> Content-Type: text/plain; charset="utf-7" MIME-Version: 1.0 List-ID: On Mon, 2018-07-30 at 20:02 +-0800, Ming Lei wrote: +AD4- Runtime PM isn't ready for blk-mq yet, and commit 765e40b675a9 (+ACI-= block: +AD4- disable runtime-pm for blk-mq+ACI-) tried to disable it. Unfortunatel= y, +AD4- it can't take effect in that way since user space still can switch +AD4- it on via 'echo auto +AD4- /sys/block/sdN/device/power/control'. +AD4-=20 +AD4- This patch disables runtime-pm for blk-mq really by pm+AF8-runtime+AF= 8-disable() +AD4- and fixes all kinds of PM related kernel crash. Reviewed-by: Bart Van Assche +ADw-bart.vanassche+AEA-wdc.com+AD4- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.hgst.iphmx.com ([216.71.153.141]:26913 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727456AbeG3WUA (ORCPT ); Mon, 30 Jul 2018 18:20:00 -0400 From: Bart Van Assche To: "ming.lei@redhat.com" , "axboe@kernel.dk" CC: "hch@lst.de" , "tomi@nomi.cz" , "linux-block@vger.kernel.org" , "ps@pks.im" , "soprwa@gmail.com" , "stern@rowland.harvard.edu" , "stable@vger.kernel.org" Subject: Re: [PATCH] block: really disable runtime-pm for blk-mq Date: Mon, 30 Jul 2018 20:43:12 +0000 Message-ID: <08023c404ab13ef6e1ccbf6efdae3dbc6bb484a4.camel@wdc.com> References: <20180730120219.24164-1-ming.lei@redhat.com> In-Reply-To: <20180730120219.24164-1-ming.lei@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-7" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Mon, 2018-07-30 at 20:02 +-0800, Ming Lei wrote: +AD4- Runtime PM isn't ready for blk-mq yet, and commit 765e40b675a9 (+ACI-= block: +AD4- disable runtime-pm for blk-mq+ACI-) tried to disable it. Unfortunatel= y, +AD4- it can't take effect in that way since user space still can switch +AD4- it on via 'echo auto +AD4- /sys/block/sdN/device/power/control'. +AD4-=20 +AD4- This patch disables runtime-pm for blk-mq really by pm+AF8-runtime+AF= 8-disable() +AD4- and fixes all kinds of PM related kernel crash. Reviewed-by: Bart Van Assche +ADw-bart.vanassche+AEA-wdc.com+AD4-