From: <Ajay.Kathat@microchip.com>
To: <kvalo@codeaurora.org>
Cc: <linux-wireless@vger.kernel.org>, <Claudiu.Beznea@microchip.com>
Subject: Re: [PATCH] wilc1000: use wilc handler as cookie in request_threaded_irq()
Date: Thu, 25 Feb 2021 04:21:41 +0000 [thread overview]
Message-ID: <0802f506-c254-a562-7bf5-08a1d524938b@microchip.com> (raw)
In-Reply-To: <87tuq1fpss.fsf@codeaurora.org>
Hi Kalle,
On 24/02/21 8:58 pm, Kalle Valo wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> <Ajay.Kathat@microchip.com> writes:
>
>> From: Ajay Singh <ajay.kathat@microchip.com>
>>
>> Use same cookie for request_threaded_irq() & free_irq() to properly free
>> IRQ during module unload. free_irq() already uses *wilc* handler so the
>> changes are required for request_threaded_irq().
>>
>> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
>> ---
>> drivers/net/wireless/microchip/wilc1000/netdev.c | 14 +++++---------
>> 1 file changed, 5 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
>> index 1b205e7d97a8..66f725aad209 100644
>> --- a/drivers/net/wireless/microchip/wilc1000/netdev.c
>> +++ b/drivers/net/wireless/microchip/wilc1000/netdev.c
>> @@ -24,12 +24,10 @@
>>
>> static irqreturn_t isr_uh_routine(int irq, void *user_data)
>> {
>> - struct net_device *dev = user_data;
>> - struct wilc_vif *vif = netdev_priv(dev);
>> - struct wilc *wilc = vif->wilc;
>> + struct wilc *wilc = (struct wilc *)user_data;
>
> No need to cast a void pointer.
Sure. I will submit V2 version for this patch by removing explicit cast.
Regards,
Ajay
>
>>
>> if (wilc->close) {
>> - netdev_err(dev, "Can't handle UH interrupt\n");
>> + pr_err("Can't handle UH interrupt");
>> return IRQ_HANDLED;
>> }
>> return IRQ_WAKE_THREAD;
>> @@ -37,12 +35,10 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data)
>>
>> static irqreturn_t isr_bh_routine(int irq, void *userdata)
>> {
>> - struct net_device *dev = userdata;
>> - struct wilc_vif *vif = netdev_priv(userdata);
>> - struct wilc *wilc = vif->wilc;
>> + struct wilc *wilc = (struct wilc *)userdata;
>
> Same here.
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
prev parent reply other threads:[~2021-02-25 4:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 12:21 [PATCH] wilc1000: use wilc handler as cookie in request_threaded_irq() Ajay.Kathat
2021-02-24 15:28 ` Kalle Valo
2021-02-25 4:21 ` Ajay.Kathat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0802f506-c254-a562-7bf5-08a1d524938b@microchip.com \
--to=ajay.kathat@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.