From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Gareth Williams <gareth.williams.jx@renesas.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v5 2/2] i2c: designware: Add support for an interface clock
Date: Fri, 1 Mar 2019 16:53:07 +0200 [thread overview]
Message-ID: <080b8edd-168e-d71a-b4c2-985460a51e53@linux.intel.com> (raw)
In-Reply-To: <1551361930-24434-3-git-send-email-gareth.williams.jx@renesas.com>
On 2/28/19 3:52 PM, Gareth Williams wrote:
> From: Phil Edworthy <phil.edworthy@renesas.com>
>
> The Synopsys I2C Controller has an interface clock, but most SoCs hide
> this away. However, on some SoCs you need to explicitly enable the
> interface clock in order to access the registers. Therefore, add
> support for an optional interface clock.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> Signed-off-by: Gareth Williams <gareth.williams.jx@renesas.com>
> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> v5:
> - Updated comments to reference "interface clock" instead of
> "peripheral clock".
> - Corrected spelling in commit message, changing "explicity" to
> "explicitly".
> v4:
> - Updated comments to reference "peripheral clock"
> instead of "bus clock".
> - Added Wolfram's Acked-by
> v3:
> - busclk renamed to pclk.
> - Added comment with dw_i2c_dev struct definition describing pclk.
> - Added enable rollback of first clock if second fails to enable.
> v2:
> - Use new devm_clk_get_optional() function as it simplifies handling when
> the optional clock is not present.
> ---
> drivers/i2c/busses/i2c-designware-common.c | 18 ++++++++++++++++--
> drivers/i2c/busses/i2c-designware-core.h | 2 ++
> drivers/i2c/busses/i2c-designware-platdrv.c | 5 +++++
> 3 files changed, 23 insertions(+), 2 deletions(-)
>
Build & boot tested on linux-next that has the required commit
60b8f0ddf1a9 ("clk: Add (devm_)clk_get_optional() functions").
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2019-03-01 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 13:52 [PATCH v5 0/2] i2c: designware: Add support for a bus clock Gareth Williams
2019-02-28 13:52 ` [PATCH v5 1/2] dt: snps,designware-i2c: Add clock bindings documentation Gareth Williams
2019-03-01 14:57 ` Jarkko Nikula
2019-03-20 16:58 ` Wolfram Sang
2019-02-28 13:52 ` [PATCH v5 2/2] i2c: designware: Add support for an interface clock Gareth Williams
2019-03-01 14:53 ` Jarkko Nikula [this message]
2019-03-20 16:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=080b8edd-168e-d71a-b4c2-985460a51e53@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gareth.williams.jx@renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.