From: Matthias Schiffer <mschiffer@universe-factory.net>
To: jengelh@inai.de
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH xtables-addons] build: fix configure compatiblity with POSIX shells
Date: Fri, 1 Apr 2016 22:35:34 +0200 [thread overview]
Message-ID: <080ce332d72f144b21b5d63986b6e8ebd9bc3095.1459542934.git.mschiffer@universe-factory.net> (raw)
The kernel version detection code uses some bashisms, which makes the build
fail on Debian systems where /bin/sh links to dash. Replace with POSIX-
conforming commands at the cost of requiring awk.
---
configure.ac | 24 +++++++++---------------
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/configure.ac b/configure.ac
index 82a1355..735c090 100644
--- a/configure.ac
+++ b/configure.ac
@@ -44,21 +44,15 @@ regular_CFLAGS="-Wall -Waggregate-return -Wmissing-declarations \
if test -n "$kbuilddir"; then
AC_MSG_CHECKING([kernel version that we will build against])
- krel="$(make -sC "$kbuilddir" M=$PWD kernelrelease)";
- kmajor="${krel%%[[^0-9]]*}";
- kmajor="$(($kmajor+0))";
- krel="${krel:${#kmajor}}";
- krel="${krel#.}";
- kminor="${krel%%[[^0-9]]*}";
- kminor="$(($kminor+0))";
- krel="${krel:${#kminor}}";
- krel="${krel#.}";
- kmicro="${krel%%[[^0-9]]*}";
- kmicro="$(($kmicro+0))";
- krel="${krel:${#kmicro}}";
- krel="${krel#.}";
- kstable="${krel%%[[^0-9]]*}";
- kstable="$(($kstable+0))";
+ krel="$(make -sC "$kbuilddir" M=$PWD kernelrelease | $AWK -v 'FS=[[^0-9.]]' '{print $1; exit}')";
+ save_IFS=$IFS;
+ IFS='.';
+ set x $krel;
+ kmajor="$(($2+0))";
+ kminor="$(($3+0))";
+ kmicro="$(($4+0))";
+ kstable="$(($5+0))";
+ IFS=$save_IFS;
if test -z "$kmajor" -o -z "$kminor" -o -z "$kmicro"; then
echo "WARNING: Version detection did not succeed. Continue at own luck.";
else
--
2.8.0
next reply other threads:[~2016-04-01 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 20:35 Matthias Schiffer [this message]
2016-04-03 10:11 ` [PATCH xtables-addons] build: fix configure compatiblity with POSIX shells Jan Engelhardt
2016-04-03 11:57 ` Matthias Schiffer
2016-04-03 16:01 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=080ce332d72f144b21b5d63986b6e8ebd9bc3095.1459542934.git.mschiffer@universe-factory.net \
--to=mschiffer@universe-factory.net \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.