From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72ECC432C0 for ; Mon, 25 Nov 2019 11:03:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B65212068E for ; Mon, 25 Nov 2019 11:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727645AbfKYLDm (ORCPT ); Mon, 25 Nov 2019 06:03:42 -0500 Received: from foss.arm.com ([217.140.110.172]:48566 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727278AbfKYLDm (ORCPT ); Mon, 25 Nov 2019 06:03:42 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD46431B; Mon, 25 Nov 2019 03:03:41 -0800 (PST) Received: from [10.1.194.37] (e113632-lin.cambridge.arm.com [10.1.194.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 52BDF3F52E; Mon, 25 Nov 2019 03:03:40 -0800 (PST) Subject: Re: [PATCH] sched/fair: fix rework of find_idlest_group() To: Vincent Guittot Cc: linux-kernel , Ingo Molnar , Peter Zijlstra , Phil Auld , Srikar Dronamraju , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Hillf Danton , Parth Shah , Rik van Riel , kernel test robot References: <1571405198-27570-12-git-send-email-vincent.guittot@linaro.org> <1571762798-25900-1-git-send-email-vincent.guittot@linaro.org> <2bb75047-4a93-4f1d-e2ff-99c499b5a070@arm.com> From: Valentin Schneider Message-ID: <08220a1c-5f31-75ff-4f07-25c45ccc8a14@arm.com> Date: Mon, 25 Nov 2019 11:03:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/2019 09:16, Vincent Guittot wrote: > > This is an extension of idle_cpu which also returns int and I wanted > to stay consistent with it > > So we might want to make some kind of cleanup or rewording of > interfaces and their descriptions but this should be done as a whole > and out of the scope of this patch and would worth having a dedicated > patch IMO because it would imply to modify other patch of the code > that is not covered by this patch like idle_cpu or cpu_util_without > Fair enough.