From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gilad Broner" Subject: Re: [PATCH v1 2/2] scsi: ufs: add support to allow non standard behaviours (quirks) Date: Tue, 7 Apr 2015 07:53:16 -0000 Message-ID: <08233ba82c96ccf7d66e06f238f67282.squirrel@www.codeaurora.org> References: <1427812635-16617-1-git-send-email-ygardi@codeaurora.org> <1427812635-16617-3-git-send-email-ygardi@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:46834 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbbDGHxR (ORCPT ); Tue, 7 Apr 2015 03:53:17 -0400 In-Reply-To: <1427812635-16617-3-git-send-email-ygardi@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Cc: james.bottomley@hansenpartnership.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, ygardi@codeaurora.org, Vinayak Holikatti , "James E.J. Bottomley" > Some implementation of UFS host controller HW might have some non-standard > behaviours (quirks) when compared to behaviour specified by UFSHCI > specification. This patch add support to allow specifying all such quirks > to standard UFS host controller driver so standard driver takes them into > account. > > In this change a UFSHCD_QUIRK_DELAY_BEFORE_DME_CMDS is introduced, > where a minimum delay of 1ms is required before DME commands for > stability purposes. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 22 +++++++++++++++++----- > drivers/scsi/ufs/ufs-qcom.h | 18 ++++++++++++++++++ > drivers/scsi/ufs/ufshcd.c | 35 +++++++++++++++++++++++++++++++++++ > drivers/scsi/ufs/ufshcd.h | 9 +++++++++ > 4 files changed, 79 insertions(+), 5 deletions(-) > Reviewed-by: Gilad Broner -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbbDGHxU (ORCPT ); Tue, 7 Apr 2015 03:53:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46834 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbbDGHxR (ORCPT ); Tue, 7 Apr 2015 03:53:17 -0400 Message-ID: <08233ba82c96ccf7d66e06f238f67282.squirrel@www.codeaurora.org> In-Reply-To: <1427812635-16617-3-git-send-email-ygardi@codeaurora.org> References: <1427812635-16617-1-git-send-email-ygardi@codeaurora.org> <1427812635-16617-3-git-send-email-ygardi@codeaurora.org> Date: Tue, 7 Apr 2015 07:53:16 -0000 Subject: Re: [PATCH v1 2/2] scsi: ufs: add support to allow non standard behaviours (quirks) From: "Gilad Broner" To: "Yaniv Gardi" Cc: james.bottomley@hansenpartnership.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, ygardi@codeaurora.org, "Vinayak Holikatti" , "James E.J. Bottomley" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Some implementation of UFS host controller HW might have some non-standard > behaviours (quirks) when compared to behaviour specified by UFSHCI > specification. This patch add support to allow specifying all such quirks > to standard UFS host controller driver so standard driver takes them into > account. > > In this change a UFSHCD_QUIRK_DELAY_BEFORE_DME_CMDS is introduced, > where a minimum delay of 1ms is required before DME commands for > stability purposes. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 22 +++++++++++++++++----- > drivers/scsi/ufs/ufs-qcom.h | 18 ++++++++++++++++++ > drivers/scsi/ufs/ufshcd.c | 35 +++++++++++++++++++++++++++++++++++ > drivers/scsi/ufs/ufshcd.h | 9 +++++++++ > 4 files changed, 79 insertions(+), 5 deletions(-) > Reviewed-by: Gilad Broner -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project