From: Fred Konrad <konrad@adacore.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Fabien Chouteau <chouteau@adacore.com>
Subject: Re: [PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef
Date: Tue, 5 Jan 2021 14:15:47 +0100 [thread overview]
Message-ID: <0828d066-21e9-ec57-d902-3a963c7b2cfe@adacore.com> (raw)
In-Reply-To: <20201212144134.29594-3-peter.maydell@linaro.org>
Le 12/12/20 à 3:41 PM, Peter Maydell a écrit :
> The grlib.h header defines a set_pil_in_fn typedef which is never
> used; remove it.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/sparc/grlib.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/sparc/grlib.h b/include/hw/sparc/grlib.h
> index e1d1beaa73f..2104f493f32 100644
> --- a/include/hw/sparc/grlib.h
> +++ b/include/hw/sparc/grlib.h
> @@ -34,8 +34,6 @@
> /* IRQMP */
> #define TYPE_GRLIB_IRQMP "grlib,irqmp"
>
> -typedef void (*set_pil_in_fn) (void *opaque, uint32_t pil_in);
> -
> void grlib_irqmp_ack(DeviceState *dev, int intno);
>
> /* GPTimer */
>
Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>
next prev parent reply other threads:[~2021-01-05 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 14:41 [PATCH 0/2] sparc/leon3: Make grlib-irqmp handle its own inbound IRQ lines Peter Maydell
2020-12-12 14:41 ` [PATCH 1/2] hw/sparc: Make grlib-irqmp device " Peter Maydell
2020-12-13 12:08 ` Philippe Mathieu-Daudé
2021-01-05 13:15 ` Fred Konrad
2020-12-12 14:41 ` [PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef Peter Maydell
2020-12-13 12:05 ` Philippe Mathieu-Daudé
2021-01-05 13:15 ` Fred Konrad [this message]
2021-01-05 13:04 ` [PATCH 0/2] sparc/leon3: Make grlib-irqmp handle its own inbound IRQ lines Mark Cave-Ayland
2021-01-05 13:17 ` Fred Konrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0828d066-21e9-ec57-d902-3a963c7b2cfe@adacore.com \
--to=konrad@adacore.com \
--cc=atar4qemu@gmail.com \
--cc=chouteau@adacore.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.