From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D327B10E1AF for ; Fri, 23 Dec 2022 08:37:16 +0000 (UTC) Message-ID: <082d7a1d-880c-54ac-997c-608ee51891ab@intel.com> Date: Fri, 23 Dec 2022 14:06:59 +0530 To: "B, Jeevan" , "igt-dev@lists.freedesktop.org" References: <20221115170855.196572-1-bhanuprakash.modem@intel.com> <20221115170855.196572-46-bhanuprakash.modem@intel.com> Content-Language: en-US From: "Modem, Bhanuprakash" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t v5 45/52] tests/i915/kms_flip_tiling: Add support for Bigjoiner List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri-23-12-2022 01:41 pm, B, Jeevan wrote: > > >> -----Original Message----- >> From: igt-dev On Behalf Of >> Bhanuprakash Modem >> Sent: Tuesday, November 15, 2022 10:39 PM >> To: igt-dev@lists.freedesktop.org >> Subject: [igt-dev] [i-g-t v5 45/52] tests/i915/kms_flip_tiling: Add support for >> Bigjoiner >> >> This patch will add a check to Skip the subtest if a selected pipe/output >> combo won't support Bigjoiner or 8K mode. >> >> Example: >> * Pipe-D wont support a mode > 5K >> * To use 8K mode on a pipe then consecutive pipe must be available & free. >> >> V2: - Use updated helper name >> >> Signed-off-by: Bhanuprakash Modem >> --- >> tests/i915/kms_flip_tiling.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/tests/i915/kms_flip_tiling.c b/tests/i915/kms_flip_tiling.c index >> 1183feb6..2e2b9511 100644 >> --- a/tests/i915/kms_flip_tiling.c >> +++ b/tests/i915/kms_flip_tiling.c >> @@ -79,6 +79,9 @@ test_flip_tiling(data_t *data, enum pipe pipe, >> igt_output_t *output, uint64_t mo >> igt_crc_t reference_crc, crc; >> int fb_id, ret; >> >> + igt_info("Using (pipe %s + %s) to run the subtest.\n", >> + kmstest_pipe_name(pipe), igt_output_name(output)); >> + > > Is igt_info required here ?? > igt_dynamic_f has the info already. Will float a new rev by removing this print. - Bhanu > >> memcpy(&data->old_fb, &data->fb, sizeof(data->fb)); >> >> mode = igt_output_get_mode(output); >> @@ -195,8 +198,12 @@ igt_main >> for_each_pipe_with_valid_output(&data.display, pipe, >> output) { >> igt_plane_t *plane; >> >> + igt_display_reset(&data.display); >> pipe_crc_free(&data); >> + >> igt_output_set_pipe(output, pipe); >> + if (!i915_pipe_output_combo_valid(&data.display)) >> + continue; >> >> plane = igt_output_get_plane_type(output, >> DRM_PLANE_TYPE_PRIMARY); >> >> -- >> 2.38.0 >