From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C6AC433FF for ; Tue, 13 Aug 2019 08:55:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C08A92063F for ; Tue, 13 Aug 2019 08:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728380AbfHMIza (ORCPT ); Tue, 13 Aug 2019 04:55:30 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55004 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728376AbfHMIz0 (ORCPT ); Tue, 13 Aug 2019 04:55:26 -0400 Received: by mail-wm1-f67.google.com with SMTP id p74so738193wme.4 for ; Tue, 13 Aug 2019 01:55:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sPUyfB4muaIr59fd4usHXqxooogTzwXwDuPC1t7ce04=; b=oraCBNTzgxKl8cVAcpHHZmOURipAhUS6g9A9q/lLX0ZnNOr++V0cJCy2CNoOT4HKK9 ICqd9yhOMICEbGQQMjDuUmUHyIv9TCuTxCQbuKmn6LGy9Qnttk4A/JyU6aPOW3tSfImm AqCFJPOP3xTq86snZ0YdqKyyQ/oDdgyOBRf+nde5Jf5KXDDHr0zHIb0znsYsetFZLK+i qsLhNh9eQyBLOlYYJCDskvFR3b1EmtWbVce7ntyx6eVSWv3JYohBdYtfikJjWRbPfTG0 pF7RCM+xwjf41PHndOzipgL0n7dkODUEzKwmFaLW6DOZnpt6yUETTSLqqrJz040+fmuM uJjA== X-Gm-Message-State: APjAAAWJZWxI4rpNps0jurixkkXtRoDxgVOxXHhoYh9oGJEQaEF/xQXQ u4nBBTqrRzaeIWhOnr7wtJuRuQ== X-Google-Smtp-Source: APXvYqxbrJjpte7v8LCdT4TY1BMezIoEu72MDVQxtXaSnj9GyHSbv3Go1giiz3C/PIGfATdRGc3mYg== X-Received: by 2002:a05:600c:2292:: with SMTP id 18mr1851704wmf.156.1565686524175; Tue, 13 Aug 2019 01:55:24 -0700 (PDT) Received: from [192.168.10.150] ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id n14sm212546507wra.75.2019.08.13.01.55.22 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 01:55:23 -0700 (PDT) Subject: Re: [RFC PATCH v6 16/92] kvm: introspection: handle events and event replies To: =?UTF-8?Q?Adalbert_Laz=c4=83r?= , kvm@vger.kernel.org Cc: linux-mm@kvack.org, virtualization@lists.linux-foundation.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Konrad Rzeszutek Wilk , Tamas K Lengyel , Mathieu Tarral , =?UTF-8?Q?Samuel_Laur=c3=a9n?= , Patrick Colp , Jan Kiszka , Stefan Hajnoczi , Weijiang Yang , Yu C Zhang , =?UTF-8?Q?Mihai_Don=c8=9bu?= References: <20190809160047.8319-1-alazar@bitdefender.com> <20190809160047.8319-17-alazar@bitdefender.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <08325b3b-3af9-382b-7c0f-8410e8fcb545@redhat.com> Date: Tue, 13 Aug 2019 10:55:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190809160047.8319-17-alazar@bitdefender.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 09/08/19 17:59, Adalbert Lazăr wrote: > > + reply->padding2); > + > + ivcpu->reply_waiting = false; > + return expected->error; > +} > + > /* Is this missing a wakeup? > > +static bool need_to_wait(struct kvm_vcpu *vcpu) > +{ > + struct kvmi_vcpu *ivcpu = IVCPU(vcpu); > + > + return ivcpu->reply_waiting; > +} > + Do you actually need this function? It seems to me that everywhere you call it you already have an ivcpu, so you can just access the field. Also, "reply_waiting" means "there is a reply that is waiting". What you mean is "waiting_for_reply". The overall structure of the jobs code is confusing. The same function kvm_run_jobs_and_wait is an infinite loop before and gets a "break" later. It is also not clear why kvmi_job_wait is called through a job. Can you have instead just kvm_run_jobs in KVM_REQ_INTROSPECTION, and something like this instead when sending an event: int kvmi_wait_for_reply(struct kvm_vcpu *vcpu) { struct kvmi_vcpu *ivcpu = IVCPU(vcpu); while (ivcpu->waiting_for_reply) { kvmi_run_jobs(vcpu); err = swait_event_killable(*wq, !ivcpu->waiting_for_reply || !list_empty(&ivcpu->job_list)); if (err) return -EINTR; } return 0; } ? Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH v6 16/92] kvm: introspection: handle events and event replies Date: Tue, 13 Aug 2019 10:55:21 +0200 Message-ID: <08325b3b-3af9-382b-7c0f-8410e8fcb545@redhat.com> References: <20190809160047.8319-1-alazar@bitdefender.com> <20190809160047.8319-17-alazar@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190809160047.8319-17-alazar@bitdefender.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: =?UTF-8?Q?Adalbert_Laz=c4=83r?= , kvm@vger.kernel.org Cc: Tamas K Lengyel , Weijiang Yang , Yu C Zhang , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Jan Kiszka , =?UTF-8?Q?Samuel_Laur=c3=a9n?= , Konrad Rzeszutek Wilk , virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Patrick Colp , Mathieu Tarral , Stefan Hajnoczi , =?UTF-8?Q?Mihai_Don=c8=9bu?= List-Id: virtualization@lists.linuxfoundation.org T24gMDkvMDgvMTkgMTc6NTksIEFkYWxiZXJ0IExhesSDciB3cm90ZToKPiAKPiArCQkJIHJlcGx5 LT5wYWRkaW5nMik7Cj4gKwo+ICsJaXZjcHUtPnJlcGx5X3dhaXRpbmcgPSBmYWxzZTsKPiArCXJl dHVybiBleHBlY3RlZC0+ZXJyb3I7Cj4gK30KPiArCj4gIC8qCgpJcyB0aGlzIG1pc3NpbmcgYSB3 YWtldXA/Cgo+ICAKPiArc3RhdGljIGJvb2wgbmVlZF90b193YWl0KHN0cnVjdCBrdm1fdmNwdSAq dmNwdSkKPiArewo+ICsJc3RydWN0IGt2bWlfdmNwdSAqaXZjcHUgPSBJVkNQVSh2Y3B1KTsKPiAr Cj4gKwlyZXR1cm4gaXZjcHUtPnJlcGx5X3dhaXRpbmc7Cj4gK30KPiArCgpEbyB5b3UgYWN0dWFs bHkgbmVlZCB0aGlzIGZ1bmN0aW9uPyAgSXQgc2VlbXMgdG8gbWUgdGhhdCBldmVyeXdoZXJlIHlv dQpjYWxsIGl0IHlvdSBhbHJlYWR5IGhhdmUgYW4gaXZjcHUsIHNvIHlvdSBjYW4ganVzdCBhY2Nl c3MgdGhlIGZpZWxkLgoKQWxzbywgInJlcGx5X3dhaXRpbmciIG1lYW5zICJ0aGVyZSBpcyBhIHJl cGx5IHRoYXQgaXMgd2FpdGluZyIuICBXaGF0CnlvdSBtZWFuIGlzICJ3YWl0aW5nX2Zvcl9yZXBs eSIuCgpUaGUgb3ZlcmFsbCBzdHJ1Y3R1cmUgb2YgdGhlIGpvYnMgY29kZSBpcyBjb25mdXNpbmcu ICBUaGUgc2FtZSBmdW5jdGlvbgprdm1fcnVuX2pvYnNfYW5kX3dhaXQgaXMgYW4gaW5maW5pdGUg bG9vcCBiZWZvcmUgYW5kIGdldHMgYSAiYnJlYWsiCmxhdGVyLiAgSXQgaXMgYWxzbyBub3QgY2xl YXIgd2h5IGt2bWlfam9iX3dhaXQgaXMgY2FsbGVkIHRocm91Z2ggYSBqb2IuCiBDYW4geW91IGhh dmUgaW5zdGVhZCBqdXN0IGt2bV9ydW5fam9icyBpbiBLVk1fUkVRX0lOVFJPU1BFQ1RJT04sIGFu ZApzb21ldGhpbmcgbGlrZSB0aGlzIGluc3RlYWQgd2hlbiBzZW5kaW5nIGFuIGV2ZW50OgoKaW50 IGt2bWlfd2FpdF9mb3JfcmVwbHkoc3RydWN0IGt2bV92Y3B1ICp2Y3B1KQp7CglzdHJ1Y3Qga3Zt aV92Y3B1ICppdmNwdSA9IElWQ1BVKHZjcHUpOwoKCXdoaWxlIChpdmNwdS0+d2FpdGluZ19mb3Jf cmVwbHkpIHsKCQlrdm1pX3J1bl9qb2JzKHZjcHUpOwoKCQllcnIgPSBzd2FpdF9ldmVudF9raWxs YWJsZSgqd3EsCgkJCQkhaXZjcHUtPndhaXRpbmdfZm9yX3JlcGx5IHx8CgkJCQkhbGlzdF9lbXB0 eSgmaXZjcHUtPmpvYl9saXN0KSk7CgoJCWlmIChlcnIpCgkJCXJldHVybiAtRUlOVFI7Cgl9CgoJ cmV0dXJuIDA7Cn0KCj8KClBhb2xvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBs aXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5v cmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==