All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Guo Ren <guoren@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, <linux-sh@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	<linux-csky@vger.kernel.org>
Subject: Re: [PATCH 0/3] Cleanup MAY_HAVE_SPARSE_IRQ
Date: Mon, 27 Sep 2021 20:35:48 +0800	[thread overview]
Message-ID: <083297b0-58e2-aa1e-2f8a-47845a9b373e@huawei.com> (raw)
In-Reply-To: <CAJF2gTQ6J-ah8xqmBHLu7KWDB9Far2Lzpfu6fFM7EBXNCJFS7g@mail.gmail.com>


On 2021/9/27 20:09, Guo Ren wrote:
> I didn't see the patch delete:
> #else /* !CONFIG_SPARSE_IRQ */
> struct irq_desc irq_desc[NR_IRQS] __cacheline_aligned_in_smp = {
>          [0 ... NR_IRQS-1] = {
>                  .handle_irq     = handle_bad_irq,
>                  .depth          = 1,
>                  .lock           = __RAW_SPIN_LOCK_UNLOCKED(irq_desc->lock),
>          }
> };
> ...
>
> Flat irq_desc[] is simple and easy for debugging. We do want to del it?

This patches want to kill MAY_HAVE_SPARSE_IRQ,  not !SPARSE_IRQ.

so I won't delete above parts(eg, ARM could use both SPARSE_IRQ and

!SPARSE_IRQ via different config,)

>
> On Mon, Sep 27, 2021 at 4:11 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> Most ARCHs support SPARSE_IRQ, and MAY_HAVE_SPARSE_IRQ is useless, and
>> only sh and csky select it, but the could use SPARSE_IRQ too, let's
>> kill MAY_HAVE_SPARSE_IRQ, also cleanup the kernel/irq/Kconfig a little.
>>
>> Kefeng Wang (3):
>>    sh: Cleanup about SPARSE_IRQ
>>    csky: Use SPARSE_IRQ
>>    genirq: Cleanup Kconfig
>>
>>   arch/csky/Kconfig         |  2 +-
>>   arch/sh/Kconfig           |  1 -
>>   arch/sh/include/asm/irq.h |  9 -------
>>   kernel/irq/Kconfig        | 50 ++++++++++++++++-----------------------
>>   4 files changed, 21 insertions(+), 41 deletions(-)
>>
>> --
>> 2.26.2
>>
>

  reply	other threads:[~2021-09-27 12:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27  8:13 [PATCH 0/3] Cleanup MAY_HAVE_SPARSE_IRQ Kefeng Wang
2021-09-27  8:14 ` [PATCH 1/3] sh: Cleanup about SPARSE_IRQ Kefeng Wang
2021-09-27 14:29   ` Geert Uytterhoeven
2021-09-27  8:14 ` [PATCH 2/3] csky: Use SPARSE_IRQ Kefeng Wang
2021-09-28  3:39   ` Guo Ren
2021-09-28  4:47     ` Kefeng Wang
2021-09-27  8:14 ` [PATCH 3/3] genirq: Cleanup Kconfig Kefeng Wang
2021-09-27 12:09 ` [PATCH 0/3] Cleanup MAY_HAVE_SPARSE_IRQ Guo Ren
2021-09-27 12:35   ` Kefeng Wang [this message]
2021-09-27 14:08     ` Guo Ren
2021-09-28  5:08 ` Guo Ren
2021-09-28  5:43   ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=083297b0-58e2-aa1e-2f8a-47845a9b373e@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=dalias@libc.org \
    --cc=guoren@kernel.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.