From: Hayes Wang <hayeswang@realtek.com>
To: Daniele Forsi <dforsi@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: RE: [PATCH net-next 4/4] r8152: support firmware files
Date: Wed, 20 Aug 2014 12:35:09 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB251585A@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <CAN_we7P2LDvR8miAsoSeL6+iEOK+ucgjRDC8jtPbc4_-2nn7MQ@mail.gmail.com>
Daniele Forsi [mailto:dforsi@gmail.com]
> Sent: Wednesday, August 20, 2014 8:01 PM
> To: Hayes Wang
> Cc: netdev@vger.kernel.org; nic_swsd;
> linux-kernel@vger.kernel.org; USB list
> Subject: Re: [PATCH net-next 4/4] r8152: support firmware files
[...]
> > + start = le32_to_cpu(fw_header->fw_start);
> > + if (start > fw->size)
> > + goto out;
>
> since "start" is an offset in an array of size "fw->size" this should
> check for ">=" and if a command is at least cmd(2 bytes) + length(2
> bytes), shouldn't this check for "start >= fw->size - 4"?
Is this necessary? Besides the check of the "start",
there are checks of the "size" and rtl_fw_data_ok().
I think they cover the situations which you indicate.
Best Regards,
Hayes
next prev parent reply other threads:[~2014-08-20 12:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 8:58 [PATCH net-next 0/4] r8152: firmware support Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 1/4] r8152: check code with checkpatch.pl Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 2/4] r8152: replace strncpy with strlcpy Hayes Wang
2014-08-20 8:58 ` Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 3/4] r8152: remove clear_bp function Hayes Wang
2014-08-20 8:58 ` Hayes Wang
2014-08-20 12:00 ` Sergei Shtylyov
[not found] ` <201408210131.s7L1VuAJ031162@rtits1.realtek.com>
2014-08-21 2:12 ` Hayes Wang
2014-08-21 17:29 ` Sergei Shtylyov
2014-08-21 17:29 ` Sergei Shtylyov
2014-08-22 2:38 ` Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 4/4] r8152: support firmware files Hayes Wang
2014-08-20 12:01 ` Daniele Forsi
2014-08-20 12:35 ` Hayes Wang [this message]
2014-08-20 13:32 ` Daniele Forsi
2014-08-20 13:32 ` Daniele Forsi
2014-08-24 21:20 ` Francois Romieu
2014-08-25 3:23 ` Hayes Wang
2014-08-23 2:41 ` [PATCH net-next 0/4] r8152: firmware support David Miller
2014-08-25 3:43 ` Hayes Wang
2014-08-25 3:43 ` Hayes Wang
2014-08-25 4:26 ` David Miller
2014-08-25 6:43 ` Hayes Wang
2014-08-25 6:43 ` Hayes Wang
2014-08-25 7:00 ` David Miller
2014-08-25 7:53 ` [PATCH net-next] r8152: check code with checkpatch.pl Hayes Wang
2014-08-25 19:58 ` David Miller
2014-08-26 2:08 ` [PATCH net-next] r8152: replace strncpy with strlcpy Hayes Wang
2014-08-27 23:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB251585A@RTITMBSV03.realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=dforsi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.