From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] phy: add support for STM32 usb phy controller
Date: Fri, 27 Apr 2018 11:18:12 +0200 [thread overview]
Message-ID: <0849b46f-a605-78fb-3264-df0e8ea07014@denx.de> (raw)
In-Reply-To: <1524819715-23074-1-git-send-email-patrice.chotard@st.com>
On 04/27/2018 11:01 AM, Patrice Chotard wrote:
> This patch adds phy tranceiver driver for STM32 USB PHY
> Controller (usbphyc) that provides dual port High-Speed
> phy for OTG (single port) and EHCI/OHCI host controller
> (two ports).
Oh, I see.
> One port of the phy is shared between the two USB controllers
> through a UTMI+ switch.
>
> Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
[...]
> +static int stm32_usbphyc_probe(struct udevice *dev)
> +{
> + struct stm32_usbphyc *usbphyc = dev_get_priv(dev);
> + struct reset_ctl reset;
> + ofnode node;
> + int i, ret;
> +
> + usbphyc->base = dev_read_addr(dev);
> + if (usbphyc->base == FDT_ADDR_T_NONE)
> + return -EINVAL;
> +
> + /* Enable clock */
> + ret = clk_get_by_index(dev, 0, &usbphyc->clk);
> + if (ret)
> + return ret;
> +
> + ret = clk_enable(&usbphyc->clk);
> + if (ret)
> + return ret;
> +
> + /* Reset */
> + ret = reset_get_by_index(dev, 0, &reset);
> + if (!ret) {
> + reset_assert(&reset);
> + udelay(2);
> + reset_deassert(&reset);
Shouldn't the reset delay be a reset controller property ?
> + }
Looks good,
Reviewed-by: Marek Vasut <marex@denx.de>
Remind me to pick it after the release please.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-04-27 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 9:01 [U-Boot] [PATCH v2] phy: add support for STM32 usb phy controller Patrice Chotard
2018-04-27 9:18 ` Marek Vasut [this message]
2018-04-27 14:28 ` Patrice CHOTARD
2018-04-27 14:37 ` Marek Vasut
2018-05-15 13:27 ` Patrice CHOTARD
2018-05-16 9:37 ` Marek Vasut
2018-05-16 14:59 ` Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0849b46f-a605-78fb-3264-df0e8ea07014@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.