All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Brendan Jackman <jackmanb@google.com>, KP Singh <kpsingh@kernel.org>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Florent Revest <revest@chromium.org>,
	Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH v2 bpf-next] bpf: Explicitly zero-extend R0 after 32-bit cmpxchg
Date: Wed, 17 Feb 2021 09:59:31 +0100	[thread overview]
Message-ID: <08669818-c99d-0d30-e1db-53160c063611@iogearbox.net> (raw)
In-Reply-To: <CA+i-1C3ZTymNxLor0==orAdnboPXTCwFQWsu-8+K9VtOrprpZg@mail.gmail.com>

On 2/17/21 8:59 AM, Brendan Jackman wrote:
> On Wed, 17 Feb 2021 at 02:43, KP Singh <kpsingh@kernel.org> wrote:
>> On Wed, Feb 17, 2021 at 1:50 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>>> On 2/16/21 3:19 PM, Brendan Jackman wrote:
> [...]
>>> Looks good overall, one small nit ... is it possible to move this into fixup_bpf_calls()
>>> where we walk the prog insns & handle most of the rewrites already?
>>
>> Ah, so I thought fixup_bpf_calls was for "calls" but now looking at
>> the function it does
>> more than just fixing up calls. I guess we could also rename it and
>> update the comment
>> on the function.
> 
> Ah yes. Looks like we have:
> 
> - Some division-by-zero related stuff
> - Implementation of LD_ABS/LD_IND
> - Some spectre mitigation
> - Tail calls
> - Fixups for map and jiffies helper calls
> 
> How about I rename this function to do_misc_fixups and add a short
> comment to each of the above sections outlining what they're doing?

Sounds good to me, I would probably make the rename & comments a separate
patch from the 32 bit cmpxchg fix though.

Thanks,
Daniel

      reply	other threads:[~2021-02-17  9:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 14:19 [PATCH v2 bpf-next] bpf: Explicitly zero-extend R0 after 32-bit cmpxchg Brendan Jackman
2021-02-16 16:30 ` KP Singh
2021-02-16 19:55 ` Ilya Leoshkevich
2021-02-17  7:51   ` Brendan Jackman
2021-02-17  0:50 ` Daniel Borkmann
2021-02-17  1:43   ` KP Singh
2021-02-17  7:59     ` Brendan Jackman
2021-02-17  8:59       ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08669818-c99d-0d30-e1db-53160c063611@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=iii@linux.ibm.com \
    --cc=jackmanb@google.com \
    --cc=kpsingh@kernel.org \
    --cc=revest@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.