From: Jonathan Toppins <jtoppins@redhat.com>
To: Shannon Nelson <snelson@pensando.io>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net] ionic: tame the watchdog timer on reconfig
Date: Fri, 19 Jun 2020 12:06:20 -0400 [thread overview]
Message-ID: <086f01c2-b8ab-3a92-2a1b-b53fa1e0245b@redhat.com> (raw)
In-Reply-To: <20200618172904.53814-1-snelson@pensando.io>
On 6/18/20 1:29 PM, Shannon Nelson wrote:
> Even with moving netif_tx_disable() to an earlier point when
> taking down the queues for a reconfiguration, we still end
> up with the occasional netdev watchdog Tx Timeout complaint.
> The old method of using netif_trans_update() works fine for
> queue 0, but has no effect on the remaining queues. Using
> netif_device_detach() allows us to signal to the watchdog to
> ignore us for the moment.
>
> Fixes: beead698b173 ("ionic: Add the basic NDO callbacks for netdev support")
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
Acked-by: Jonathan Toppins <jtoppins@redhat.com>
next prev parent reply other threads:[~2020-06-19 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 17:29 [PATCH net] ionic: tame the watchdog timer on reconfig Shannon Nelson
2020-06-19 16:06 ` Jonathan Toppins [this message]
2020-06-21 0:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=086f01c2-b8ab-3a92-2a1b-b53fa1e0245b@redhat.com \
--to=jtoppins@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.