From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE628C433EF for ; Mon, 25 Apr 2022 13:13:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DAF0D83B5C; Mon, 25 Apr 2022 15:13:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1650892436; bh=507Pp0Rki8XCJYJjlY7AOLsfSpcszpVAyM9DsRyvbrM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UQLMmVcjVAGIJdTEQCQ/4JwbFODhn1zr88GoqWLBb1SN914s5iL776XIPHgumfoOx F9F3l6JDcLuy7/VwwmAshEGlFXjQ9uo92TI3KJbjt37OFtlDfyBw7dCDwKyPVDxKxB nZ9+XLYo1jMl7ZTyeioNZ08aNkxRNaVkyYr60pmCAkl3/9yabpWpfQCsUl9hVwSlZX Xk4+Ey1tnDU85aXEeiwA3JYpsqrk8xn9pvnqkHljvo/L9RtvajYSgXkpmv9eN3IBv9 i7qh+ba2UzX3k3gLR7NdYEkEqjBz7uQl6A9D1dSy7yy4Vs1QELYW/Id2qDlHgHgRzl bIetdpICbXGZw== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id F127183535; Mon, 25 Apr 2022 15:13:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1650892434; bh=507Pp0Rki8XCJYJjlY7AOLsfSpcszpVAyM9DsRyvbrM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Wsjej+xJ/6dqBB5egBO1ANp8RwQSLAkDp6WzOV7tSFYEu0aGinGjb+SbNryQIW7iw 4Ig5+fPjU5hOzhx4+GN0bmWJtV0w90r1fslLcZ0/JPkcDvOX4iD1mJqgZtKG18hQTZ OATaeVvAEVmUSx/0d2YXFXGaBKoslm7RHNWfKbd9OCWsvMPoUqI3EwaO27N2dfW6IS 6eSX/76YhpN1Rk68hl3RnQbatGLNHQnbZ1EPj3qIVpa9FULy92EYDQMU3Tfx7AhrmA WfpW5EE93iqzlp4pRzigVsZoJkXLF9RaKVOHZlSd8dXuuisqwjAvWde8qX8P2hhrCO x5ZXJhcjgHo2Q== Message-ID: <087d1896-8080-1321-fe1e-007da297d501@denx.de> Date: Mon, 25 Apr 2022 15:13:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/4] ARM: imx: imx8m: Introduce and use UART_BASE_ADDR(n) Content-Language: en-US To: Tom Rini Cc: Fabio Estevam , u-boot@lists.denx.de, Peng Fan , Stefano Babic References: <20220424214406.52658-1-marex@denx.de> <8c8da72e95a3b2d3084ced28605ae5e4@denx.de> <20220425130549.GD6921@bill-the-cat> From: Marek Vasut In-Reply-To: <20220425130549.GD6921@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/25/22 15:05, Tom Rini wrote: > On Mon, Apr 25, 2022 at 03:02:29PM +0200, Marek Vasut wrote: >> On 4/25/22 14:46, Fabio Estevam wrote: >>> Hi Marek, >>> >>> On 24/04/2022 18:44, Marek Vasut wrote: >>>> Introduce helper macro UART_BASE_ADDR(n), which returns Nth UART base >>>> address. Convert all board configurations to this new macro. This is the >>>> first step toward switching CONFIG_MXC_UART_BASE to Kconfig. This is a >>>> clean up, no functional change. >>> >>> As DM_SERIAL is mandatory now, we should get rid of CONFIG_MXC_UART_BASE. >>> >>> I would prefer a patch that removes CONFIG_MXC_UART_BASE instead. >> >> DM is mandatory in SPL too ? I doubt it. > > It is strongly encouraged, but not mandatory. It is not used on I guess > imx27/31/5, but is for all of the imx8 families. So > CONFIG_MXC_UART_BASE still needs to be moved out of board.h files (and > perhaps out of CONFIG namespace since it's not configurable, it's part > of the SoC) and perhaps the path for imx8* is to drop the references > since it's all DM? MX8M SPL is not DM serial either. But I think I will just postpone this cleanup until I have time to finish it.