From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0021C33C9B for ; Tue, 7 Jan 2020 19:19:12 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 878D1208C4 for ; Tue, 7 Jan 2020 19:19:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="KuhBgkhm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 878D1208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 609F910097DBE; Tue, 7 Jan 2020 11:22:31 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=brho@google.com; receiver= Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D47D710097DBB for ; Tue, 7 Jan 2020 11:22:28 -0800 (PST) Received: by mail-pf1-x442.google.com with SMTP id 4so328305pfz.9 for ; Tue, 07 Jan 2020 11:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TU5y0uOd04v29R1ldy4aCdHRn60AIShQAfhIrYqvct4=; b=KuhBgkhmzY+be0c7oA/ma8hxZhuoHjFirs176QvXXz/8TxiRr6YQ8GknYwFMLw1MtL G5mycKgbz64sOLtaaTynzyLMeFAlctWwoDdtIulNgI4aCVpmcAoiQHuYr8f0bWNv+jqv HMu/z7+GvtaFoAMV6thwF4A7WTUJ9Rh4KO08NaZEOaHv52TRRWsWMRLudoMK6W0PHaJx OIPAG5RU+91Q4CX0/TyPnG7ydKx5ImuveytiD5wUcjBK9KGUXWJ4XHpEaDPSpM9CljDW OiMqRWyN7ID3K0FkcOD4TS+Ieou2h7qp9XyN6u4X/M1xbFRYfk3/iyRYvjiQYb5MpBaN fy4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TU5y0uOd04v29R1ldy4aCdHRn60AIShQAfhIrYqvct4=; b=Bjm7S4qKahZf8owl5tyBjPAhbbWGoBZWWHMySQnPgo70CPR8Bq+xMuGY6VUaaVUTtc zG39bZsGsepw40cVNQKlPZpTXLxfMcqjoPrtXc7JyQVFuik3PftbDGbF38N6c9NwpzwH adK3TwnkJOAWMPpyEcv8JIQcicAqzK5NumfaQ0CrFvFXPfhaaewiKJCi/YsRMgvNzkfZ aPfBEpiDpVXS/nWYE6dH79+B/u5R1BWq90K66dmkhrnWZn1RPeunOZ4BcAGKsSHQy5Ai k+J5srKz6lY0utUBzgSbVHYcviNmq8vbyBBw5C3jb9kVj+F/ihP9eHIpnhGwmzw8W2Z4 Nq3g== X-Gm-Message-State: APjAAAVutcBm9uku+z2jS4610Aw0eKhv2bgxQts0oYo+cpb/obREMQ0P q8wxsHrWQF8lJ71j1tpjNts0Fw== X-Google-Smtp-Source: APXvYqz3hHvhtKQxlmnApv3yxgqZQM3teHJBcT4UloZ5gm4T7Df1KmGi/QM9c96hmThP+tfqKucIyA== X-Received: by 2002:a62:f94d:: with SMTP id g13mr825176pfm.60.1578424749010; Tue, 07 Jan 2020 11:19:09 -0800 (PST) Received: from gnomeregan01.cam.corp.google.com ([2620:15c:6:14:50b7:ffca:29c4:6488]) by smtp.googlemail.com with ESMTPSA id i2sm485165pgi.94.2020.01.07.11.19.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2020 11:19:08 -0800 (PST) Subject: Re: [PATCH v5 2/2] kvm: Use huge pages for DAX-backed files To: Sean Christopherson References: <20191212182238.46535-1-brho@google.com> <20191212182238.46535-3-brho@google.com> <06108004-1720-41EB-BCAB-BFA8FEBF4772@oracle.com>

<65FB6CC1-3AD2-4D6F-9481-500BD7037203@oracle.com> <20191213171950.GA31552@linux.intel.com> <20200107190522.GA16987@linux.intel.com> From: Barret Rhoden Message-ID: <08a36944-ad5a-ca49-99b3-d3908ce0658b@google.com> Date: Tue, 7 Jan 2020 14:19:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200107190522.GA16987@linux.intel.com> Content-Language: en-US Message-ID-Hash: MTDOFTOEJDDKXPW3H4YAQEG5CLRIMDXV X-Message-ID-Hash: MTDOFTOEJDDKXPW3H4YAQEG5CLRIMDXV X-MailFrom: brho@google.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Liran Alon , Paolo Bonzini , David Hildenbrand , Alexander Duyck , linux-nvdimm@lists.01.org, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jason.zeng@intel.com X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii"; format="flowed" Content-Transfer-Encoding: 7bit Hi - On 1/7/20 2:05 PM, Sean Christopherson wrote: > On Mon, Dec 16, 2019 at 11:05:26AM -0500, Barret Rhoden wrote: >> On 12/13/19 12:19 PM, Sean Christopherson wrote: >>> Teaching thp_adjust() how to handle 1GB wouldn't be a bad thing. It's >>> unlikely THP itself will support 1GB pages any time soon, but having the >>> logic there wouldn't hurt anything. >>> >> >> Cool. This was my main concern - I didn't want to break THP. >> >> I'll rework the series based on all of your comments. > > Hopefully you haven't put too much effort into the rework, because I want > to commandeer the proposed changes and use them as the basis for a more > aggressive overhaul of KVM's hugepage handling. Ironically, there's a bug > in KVM's THP handling that I _think_ can be avoided by using the DAX > approach of walking the host PTEs. > > I'm in the process of testing, hopefully I'll get a series sent out later > today. If not, I should at least be able to provide an update. Nice timing. I was just about to get back to this, so I haven't put any time in yet. =) Please CC me, and I'll try your patches out on my end. Thanks, Barret _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD01C282DD for ; Tue, 7 Jan 2020 19:19:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 411B1208C4 for ; Tue, 7 Jan 2020 19:19:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KuhBgkhm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728779AbgAGTTK (ORCPT ); Tue, 7 Jan 2020 14:19:10 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38008 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728649AbgAGTTJ (ORCPT ); Tue, 7 Jan 2020 14:19:09 -0500 Received: by mail-pf1-f193.google.com with SMTP id x185so336666pfc.5 for ; Tue, 07 Jan 2020 11:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TU5y0uOd04v29R1ldy4aCdHRn60AIShQAfhIrYqvct4=; b=KuhBgkhmzY+be0c7oA/ma8hxZhuoHjFirs176QvXXz/8TxiRr6YQ8GknYwFMLw1MtL G5mycKgbz64sOLtaaTynzyLMeFAlctWwoDdtIulNgI4aCVpmcAoiQHuYr8f0bWNv+jqv HMu/z7+GvtaFoAMV6thwF4A7WTUJ9Rh4KO08NaZEOaHv52TRRWsWMRLudoMK6W0PHaJx OIPAG5RU+91Q4CX0/TyPnG7ydKx5ImuveytiD5wUcjBK9KGUXWJ4XHpEaDPSpM9CljDW OiMqRWyN7ID3K0FkcOD4TS+Ieou2h7qp9XyN6u4X/M1xbFRYfk3/iyRYvjiQYb5MpBaN fy4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TU5y0uOd04v29R1ldy4aCdHRn60AIShQAfhIrYqvct4=; b=EojqY7JA/DthqWRPbB3Cay0pTrYsMpAmXzwv3PdPZjgyJ3HF+hHgOdtGCvqqVE1ms8 oD50JprDt876cUqJrk9b2rb6ShCHqTASpb3fyFb/AE1MujKWhqLWcL60h/0DWf4neV3K Ujm1PtPC0WgybL6kouOGnZqVJF/QvIw4nilWkXqLAFttDX4FPU3X4WnzaDyRvM4UNJAj nYfe4aAuyWD5aNuIc18/JaU0AdLBk/0WBETmSpjSNnOa84+P8o5+KDZCo9khBPd2yCed Oq4LoTq6UBYufz058QgM6ViCEFq5+WQgfHb7shSivUbg4uFnglDt2RTE1Nsv/FBTysfc G2yQ== X-Gm-Message-State: APjAAAVKMYaJNV/lLzgsExdd4MOww5eceGj1usPn1HIa1Xiq5vDQ/tya zL4bePfdGpAwp6UP7opDY4anYw== X-Google-Smtp-Source: APXvYqz3hHvhtKQxlmnApv3yxgqZQM3teHJBcT4UloZ5gm4T7Df1KmGi/QM9c96hmThP+tfqKucIyA== X-Received: by 2002:a62:f94d:: with SMTP id g13mr825176pfm.60.1578424749010; Tue, 07 Jan 2020 11:19:09 -0800 (PST) Received: from gnomeregan01.cam.corp.google.com ([2620:15c:6:14:50b7:ffca:29c4:6488]) by smtp.googlemail.com with ESMTPSA id i2sm485165pgi.94.2020.01.07.11.19.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2020 11:19:08 -0800 (PST) Subject: Re: [PATCH v5 2/2] kvm: Use huge pages for DAX-backed files To: Sean Christopherson Cc: Liran Alon , Paolo Bonzini , Dan Williams , David Hildenbrand , Dave Jiang , Alexander Duyck , linux-nvdimm@lists.01.org, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jason.zeng@intel.com References: <20191212182238.46535-1-brho@google.com> <20191212182238.46535-3-brho@google.com> <06108004-1720-41EB-BCAB-BFA8FEBF4772@oracle.com>