All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v4, 2/2] test/py: add test for whitelist of variables while importing environment
Date: Wed, 13 Jun 2018 13:02:06 -0600	[thread overview]
Message-ID: <08b27607-b29c-ad27-3533-43aefe0368ba@wwwdotorg.org> (raw)
In-Reply-To: <20180613185312.ulqctp7nw4yzdqtx@qschulz>

On 06/13/2018 12:53 PM, Quentin Schulz wrote:
> Hi Tom,
> 
> On Wed, Jun 13, 2018 at 11:43:32AM -0400, Tom Rini wrote:
>> On Mon, Jun 04, 2018 at 11:47:30AM +0200, Quentin Schulz wrote:
>>
>>> This tests that the importing of an environment with a specified
>>> whitelist works as intended.
>>>
>>> If there are variables passed as parameter to the env import command,
>>>     those only should be imported in the current environment.
>>>
>>> For each variable passed as parameter, if
>>>   - foo is bar in current env and bar2 in exported env, after importing
>>>   exported env, foo shall be bar2,
>>>   - foo does not exist in current env and foo is bar2 in exported env,
>>>   after importing exported env, foo shall be bar2,
>>>   - foo is bar in current env and does not exist in exported env (but is
>>>   passed as parameter), after importing exported env, foo shall be empty,
>>>
>>> Any variable not passed as parameter should be left untouched.
>>>
>>> Two other tests are made to test that size cannot be '-' if the checksum
>>> protection is enabled.
>>>
>>> Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>> Reviewed-by: Stephen Warren <swarren@nvidia.com>
>>
>> This seems to not be working?
>>
>> https://travis-ci.org/trini/u-boot/jobs/391504525
>>
> 
> I just rebased on top of v2018.07-rc1, ran
> make mrproper
> ./test/py/test.py --bd sandbox --build
> 
> and the tests run fine ...

Most likely the failure is due to the test relying on some feature that 
isn't enabled on the board being tested (emulated via qemu); you'll need 
to add something like the following to indicate which feature the test 
relies upon:

@pytest.mark.buildconfigspec('cmd_echo')

All the test commands are in .travis.yml in the top-level of the U-Boot 
source tree. You can see the exact error at the very end of the log that 
Tom linked to.

  reply	other threads:[~2018-06-13 19:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04  9:47 [U-Boot] [PATCH v4 1/2] cmd: nvedit: env import can now import only variables passed as parameters Quentin Schulz
2018-06-04  9:47 ` [U-Boot] [PATCH v4 2/2] test/py: add test for whitelist of variables while importing environment Quentin Schulz
2018-06-07 23:21   ` Stephen Warren
2018-06-08  9:28     ` Quentin Schulz
2018-06-13 15:43   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-06-13 18:53     ` Quentin Schulz
2018-06-13 19:02       ` Stephen Warren [this message]
2018-06-26 12:41         ` Quentin Schulz
2018-06-26 14:44           ` Tom Rini
2018-06-27  7:52             ` Quentin Schulz
2018-06-27 15:23               ` Tom Rini
2018-06-27 16:07                 ` Stephen Warren
2018-06-28 13:42                   ` Quentin Schulz
2018-06-28 13:39                 ` Quentin Schulz
2018-06-28 15:54                   ` Stephen Warren
2018-06-26 15:59           ` Stephen Warren
2018-06-13 20:12       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08b27607-b29c-ad27-3533-43aefe0368ba@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.