* [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" @ 2017-04-03 20:25 Andres Rodriguez [not found] ` <20170403202534.3311-1-andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Andres Rodriguez @ 2017-04-03 20:25 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: alexander.deucher-5C7GfCeVMHo, andresx7-Re5JQEeQqe8AvxtiuMwx3w Commit e579f56 results in a KCQ initialization error for polaris10 cards. Providing the full SET_RESOURCES packet instead of the truncated version fixes the problem. I think this patch may have been one of the stabs at fixing the KCQ suspend/resume errors. I *think* it may no longer be needed if that is the case. Sending this mostly as an FYI to get the patch removed from the 4.12-wip This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index 2d8d7bb..4c3bf51 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct amdgpu_device *adev) return r; } /* set resources */ - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 2)); + amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 6)); amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 (KIQ) */ amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap size:0 */ for (i = 0; i < adev->gfx.num_compute_rings; i++) { struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); -- 2.9.3 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 14+ messages in thread
[parent not found: <20170403202534.3311-1-andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <20170403202534.3311-1-andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-04-04 12:27 ` Tom St Denis [not found] ` <3ae98951-f12f-3860-e10a-00e0be2b9e84-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Tom St Denis @ 2017-04-04 12:27 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 03/04/17 04:25 PM, Andres Rodriguez wrote: > Commit e579f56 results in a KCQ initialization error for polaris10 > cards. Providing the full SET_RESOURCES packet instead of the truncated > version fixes the problem. > > I think this patch may have been one of the stabs at fixing the KCQ > suspend/resume errors. I *think* it may no longer be needed if that is > the case. > > Sending this mostly as an FYI to get the patch removed from the 4.12-wip > > This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. > --- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > index 2d8d7bb..4c3bf51 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct amdgpu_device *adev) > return r; > } > /* set resources */ > - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 2)); > + amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 6)); > amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 (KIQ) */ > amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ > amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ > + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ > + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ > + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ > + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap size:0 */ > for (i = 0; i < adev->gfx.num_compute_rings; i++) { > struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; > uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); > This fixes init issues with my polaris board but there's still a clock problem (CP is pegged at 100% as read by umr) resulting in the GPU clock staying at 1200MHz the entire time. Tom _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <3ae98951-f12f-3860-e10a-00e0be2b9e84-5C7GfCeVMHo@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <3ae98951-f12f-3860-e10a-00e0be2b9e84-5C7GfCeVMHo@public.gmane.org> @ 2017-04-04 19:39 ` Andres Rodriguez [not found] ` <d4fbb81c-be3a-c54a-6d56-17dc4ae27895-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Andres Rodriguez @ 2017-04-04 19:39 UTC (permalink / raw) To: Tom St Denis, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 2017-04-04 08:27 AM, Tom St Denis wrote: > On 03/04/17 04:25 PM, Andres Rodriguez wrote: >> Commit e579f56 results in a KCQ initialization error for polaris10 >> cards. Providing the full SET_RESOURCES packet instead of the truncated >> version fixes the problem. >> >> I think this patch may have been one of the stabs at fixing the KCQ >> suspend/resume errors. I *think* it may no longer be needed if that is >> the case. >> >> Sending this mostly as an FYI to get the patch removed from the 4.12-wip >> >> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. >> --- >> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> index 2d8d7bb..4c3bf51 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct >> amdgpu_device *adev) >> return r; >> } >> /* set resources */ >> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 2)); >> + amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 6)); >> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 >> (KIQ) */ >> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ >> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ >> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ >> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ >> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ >> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap >> size:0 */ >> for (i = 0; i < adev->gfx.num_compute_rings; i++) { >> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; >> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); >> > > This fixes init issues with my polaris board but there's still a clock > problem (CP is pegged at 100% as read by umr) resulting in the GPU clock > staying at 1200MHz the entire time. > Yeah I sent this out because I was having KCQ init issues on my polaris10 card. However, I'm not seeing the CP pegged at 100% as you mentioned. Everything sitting quietly at 0% here. > Tom > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <d4fbb81c-be3a-c54a-6d56-17dc4ae27895-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* RE: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <d4fbb81c-be3a-c54a-6d56-17dc4ae27895-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-04-04 19:46 ` Deucher, Alexander [not found] ` <BN6PR12MB1652D90B12B8A60F1F725AC0F70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Deucher, Alexander @ 2017-04-04 19:46 UTC (permalink / raw) To: 'Andres Rodriguez', StDenis, Tom, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf > Of Andres Rodriguez > Sent: Tuesday, April 04, 2017 3:39 PM > To: StDenis, Tom; amd-gfx@lists.freedesktop.org > Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" > > > > On 2017-04-04 08:27 AM, Tom St Denis wrote: > > On 03/04/17 04:25 PM, Andres Rodriguez wrote: > >> Commit e579f56 results in a KCQ initialization error for polaris10 > >> cards. Providing the full SET_RESOURCES packet instead of the truncated > >> version fixes the problem. > >> > >> I think this patch may have been one of the stabs at fixing the KCQ > >> suspend/resume errors. I *think* it may no longer be needed if that is > >> the case. > >> > >> Sending this mostly as an FYI to get the patch removed from the 4.12-wip > >> > >> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. > >> --- > >> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- > >> 1 file changed, 5 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >> index 2d8d7bb..4c3bf51 100644 > >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct > >> amdgpu_device *adev) > >> return r; > >> } > >> /* set resources */ > >> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 2)); > >> + amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, > 6)); > >> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 > >> (KIQ) */ > >> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ > >> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ > >> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ > >> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ > >> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ > >> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap > >> size:0 */ > >> for (i = 0; i < adev->gfx.num_compute_rings; i++) { > >> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; > >> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); > >> > > > > This fixes init issues with my polaris board but there's still a clock > > problem (CP is pegged at 100% as read by umr) resulting in the GPU clock > > staying at 1200MHz the entire time. > > > > Yeah I sent this out because I was having KCQ init issues on my > polaris10 card. However, I'm not seeing the CP pegged at 100% as you > mentioned. Everything sitting quietly at 0% here. Which firmware are you using? Alex > > > > Tom > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <BN6PR12MB1652D90B12B8A60F1F725AC0F70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <BN6PR12MB1652D90B12B8A60F1F725AC0F70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-04-04 19:59 ` Tom St Denis [not found] ` <CAAzXoR+TJHk1Eo_h0HJGg-KGfON-uLWE7e27Q-95PXyBY3zcOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Tom St Denis @ 2017-04-04 19:59 UTC (permalink / raw) To: Deucher, Alexander, Andres Rodriguez, StDenis, Tom, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 3721 bytes --] I'm using the latest from all open (our internal FC24 repo). I'll fetch the exact later with "umr -c". Tom On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org> wrote: > > -----Original Message----- > > From: amd-gfx [mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org] On Behalf > > Of Andres Rodriguez > > Sent: Tuesday, April 04, 2017 3:39 PM > > To: StDenis, Tom; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" > > > > > > > > On 2017-04-04 08:27 AM, Tom St Denis wrote: > > > On 03/04/17 04:25 PM, Andres Rodriguez wrote: > > >> Commit e579f56 results in a KCQ initialization error for polaris10 > > >> cards. Providing the full SET_RESOURCES packet instead of the > truncated > > >> version fixes the problem. > > >> > > >> I think this patch may have been one of the stabs at fixing the KCQ > > >> suspend/resume errors. I *think* it may no longer be needed if that is > > >> the case. > > >> > > >> Sending this mostly as an FYI to get the patch removed from the > 4.12-wip > > >> > > >> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. > > >> --- > > >> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- > > >> 1 file changed, 5 insertions(+), 1 deletion(-) > > >> > > >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >> index 2d8d7bb..4c3bf51 100644 > > >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct > > >> amdgpu_device *adev) > > >> return r; > > >> } > > >> /* set resources */ > > >> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 2)); > > >> + amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, > > 6)); > > >> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 > > >> (KIQ) */ > > >> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ > > >> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ > > >> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ > > >> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ > > >> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ > > >> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap > > >> size:0 */ > > >> for (i = 0; i < adev->gfx.num_compute_rings; i++) { > > >> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; > > >> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); > > >> > > > > > > This fixes init issues with my polaris board but there's still a clock > > > problem (CP is pegged at 100% as read by umr) resulting in the GPU > clock > > > staying at 1200MHz the entire time. > > > > > > > Yeah I sent this out because I was having KCQ init issues on my > > polaris10 card. However, I'm not seeing the CP pegged at 100% as you > > mentioned. Everything sitting quietly at 0% here. > > Which firmware are you using? > > Alex > > > > > > > > Tom > > > _______________________________________________ > > > amd-gfx mailing list > > > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > [-- Attachment #1.2: Type: text/html, Size: 7241 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <CAAzXoR+TJHk1Eo_h0HJGg-KGfON-uLWE7e27Q-95PXyBY3zcOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <CAAzXoR+TJHk1Eo_h0HJGg-KGfON-uLWE7e27Q-95PXyBY3zcOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-04-04 20:01 ` Andres Rodriguez [not found] ` <32c1f7e8-54a4-8db7-c764-8bae55bf3f94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Andres Rodriguez @ 2017-04-04 20:01 UTC (permalink / raw) To: Tom St Denis, Deucher, Alexander, StDenis, Tom, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW This is my info in case that is useful: umr.version == ea8e49bb15ed fw.VCE == .feature==0 .firmware==0x34040300 fw.UVD == .feature==0 .firmware==0x014f1000 fw.MC == .feature==0 .firmware==0x00000000 fw.ME == .feature==37 .firmware==0x00000094 fw.PFP == .feature==37 .firmware==0x000000dc fw.CE == .feature==37 .firmware==0x00000080 fw.RLC == .feature==1 .firmware==0x0000010e fw.MEC == .feature==37 .firmware==0x000002a2 fw.MEC2 == .feature==37 .firmware==0x000002a2 fw.SOS == .feature==0 .firmware==0x00000000 fw.ASD == .feature==0 .firmware==0x00000000 fw.SMC == .feature==0 .firmware==0x00170f00 fw.SDMA0 == .feature==31 .firmware==0x00000036 fw.SDMA1 == .feature==0 .firmware==0x00000036 asic.instance == 0 gfx.max_shader_engines == 4 gfx.max_tile_pipes == 8 gfx.max_cu_per_sh == 9 gfx.max_sh_per_se == 1 gfx.max_backends_per_se == 2 gfx.max_texture_channel_caches == 8 gfx.max_gprs == 256 gfx.max_gs_threads == 32 gfx.max_hw_contexts == 8 gfx.sc_prim_fifo_size_frontend == 32 gfx.sc_prim_fifo_size_backend == 256 gfx.sc_hiz_tile_fifo_size == 48 gfx.sc_earlyz_tile_fifo_size == 304 gfx.num_tile_pipes == 8 gfx.backend_enable_mask == 255 gfx.mem_max_burst_length_bytes == 256 gfx.mem_row_size_in_kb == 4 gfx.shader_engine_tile_size == 32 gfx.num_gpus == 1 gfx.multi_gpu_tile_size == 64 gfx.mc_arb_ramcfg == 24738 gfx.gb_addr_config == 570494979 gfx.num_rbs == 8 gfx.family = 130, Volcanic Islands gfx.rev_id == 00000001 gfx.external_rev_id == 00000051 gfx.cg_flags == 003fffcd AMD_CG_SUPPORT_GFX_MGCG AMD_CG_SUPPORT_GFX_CGCG AMD_CG_SUPPORT_GFX_CGLS AMD_CG_SUPPORT_GFX_CP_LS AMD_CG_SUPPORT_GFX_RLC_LS AMD_CG_SUPPORT_MC_LS AMD_CG_SUPPORT_MC_MGCG AMD_CG_SUPPORT_SDMA_LS AMD_CG_SUPPORT_SDMA_MGCG AMD_CG_SUPPORT_BIF_LS AMD_CG_SUPPORT_UVD_MGCG AMD_CG_SUPPORT_VCE_MGCG AMD_CG_SUPPORT_HDP_LS AMD_CG_SUPPORT_HDP_MGCG AMD_CG_SUPPORT_ROM_MGCG gfx.pg_flags == 00000000 Regards, Andres On 2017-04-04 03:59 PM, Tom St Denis wrote: > I'm using the latest from all open (our internal FC24 repo). I'll fetch > the exact later with "umr -c". > > Tom > > On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander <Alexander.Deucher@amd.com> > wrote: > >>> -----Original Message----- >>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf >>> Of Andres Rodriguez >>> Sent: Tuesday, April 04, 2017 3:39 PM >>> To: StDenis, Tom; amd-gfx@lists.freedesktop.org >>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" >>> >>> >>> >>> On 2017-04-04 08:27 AM, Tom St Denis wrote: >>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: >>>>> Commit e579f56 results in a KCQ initialization error for polaris10 >>>>> cards. Providing the full SET_RESOURCES packet instead of the >> truncated >>>>> version fixes the problem. >>>>> >>>>> I think this patch may have been one of the stabs at fixing the KCQ >>>>> suspend/resume errors. I *think* it may no longer be needed if that is >>>>> the case. >>>>> >>>>> Sending this mostly as an FYI to get the patch removed from the >> 4.12-wip >>>>> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. >>>>> --- >>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- >>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>> index 2d8d7bb..4c3bf51 100644 >>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct >>>>> amdgpu_device *adev) >>>>> return r; >>>>> } >>>>> /* set resources */ >>>>> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 2)); >>>>> + amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, >>> 6)); >>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 >>>>> (KIQ) */ >>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ >>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ >>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap >>>>> size:0 */ >>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { >>>>> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; >>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); >>>>> >>>> This fixes init issues with my polaris board but there's still a clock >>>> problem (CP is pegged at 100% as read by umr) resulting in the GPU >> clock >>>> staying at 1200MHz the entire time. >>>> >>> Yeah I sent this out because I was having KCQ init issues on my >>> polaris10 card. However, I'm not seeing the CP pegged at 100% as you >>> mentioned. Everything sitting quietly at 0% here. >> Which firmware are you using? >> >> Alex >> >>> >>>> Tom >>>> _______________________________________________ >>>> amd-gfx mailing list >>>> amd-gfx@lists.freedesktop.org >>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>> _______________________________________________ >>> amd-gfx mailing list >>> amd-gfx@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <32c1f7e8-54a4-8db7-c764-8bae55bf3f94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* RE: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <32c1f7e8-54a4-8db7-c764-8bae55bf3f94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-04-04 20:03 ` Deucher, Alexander [not found] ` <BN6PR12MB1652C9E0D15D794E02FAB2ADF70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Deucher, Alexander @ 2017-04-04 20:03 UTC (permalink / raw) To: 'Andres Rodriguez', Tom St Denis, StDenis, Tom, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW > -----Original Message----- > From: Andres Rodriguez [mailto:andresx7@gmail.com] > Sent: Tuesday, April 04, 2017 4:01 PM > To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd- > gfx@lists.freedesktop.org > Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" > > This is my info in case that is useful: > > umr.version == ea8e49bb15ed > > fw.VCE == .feature==0 .firmware==0x34040300 > fw.UVD == .feature==0 .firmware==0x014f1000 > fw.MC == .feature==0 .firmware==0x00000000 > fw.ME == .feature==37 .firmware==0x00000094 > fw.PFP == .feature==37 .firmware==0x000000dc > fw.CE == .feature==37 .firmware==0x00000080 > fw.RLC == .feature==1 .firmware==0x0000010e > fw.MEC == .feature==37 .firmware==0x000002a2 > fw.MEC2 == .feature==37 .firmware==0x000002a2 > fw.SOS == .feature==0 .firmware==0x00000000 > fw.ASD == .feature==0 .firmware==0x00000000 > fw.SMC == .feature==0 .firmware==0x00170f00 > fw.SDMA0 == .feature==31 .firmware==0x00000036 > fw.SDMA1 == .feature==0 .firmware==0x00000036 > > asic.instance == 0 > > > gfx.max_shader_engines == 4 > gfx.max_tile_pipes == 8 > gfx.max_cu_per_sh == 9 > gfx.max_sh_per_se == 1 > gfx.max_backends_per_se == 2 > gfx.max_texture_channel_caches == 8 > gfx.max_gprs == 256 > gfx.max_gs_threads == 32 > gfx.max_hw_contexts == 8 > gfx.sc_prim_fifo_size_frontend == 32 > gfx.sc_prim_fifo_size_backend == 256 > gfx.sc_hiz_tile_fifo_size == 48 > gfx.sc_earlyz_tile_fifo_size == 304 > gfx.num_tile_pipes == 8 > gfx.backend_enable_mask == 255 > gfx.mem_max_burst_length_bytes == 256 > gfx.mem_row_size_in_kb == 4 > gfx.shader_engine_tile_size == 32 > gfx.num_gpus == 1 > gfx.multi_gpu_tile_size == 64 > gfx.mc_arb_ramcfg == 24738 > gfx.gb_addr_config == 570494979 > gfx.num_rbs == 8 > gfx.family = 130, Volcanic Islands > gfx.rev_id == 00000001 > gfx.external_rev_id == 00000051 > gfx.cg_flags == 003fffcd > AMD_CG_SUPPORT_GFX_MGCG > AMD_CG_SUPPORT_GFX_CGCG > AMD_CG_SUPPORT_GFX_CGLS > AMD_CG_SUPPORT_GFX_CP_LS > AMD_CG_SUPPORT_GFX_RLC_LS > AMD_CG_SUPPORT_MC_LS > AMD_CG_SUPPORT_MC_MGCG > AMD_CG_SUPPORT_SDMA_LS > AMD_CG_SUPPORT_SDMA_MGCG > AMD_CG_SUPPORT_BIF_LS > AMD_CG_SUPPORT_UVD_MGCG > AMD_CG_SUPPORT_VCE_MGCG > AMD_CG_SUPPORT_HDP_LS > AMD_CG_SUPPORT_HDP_MGCG > AMD_CG_SUPPORT_ROM_MGCG > gfx.pg_flags == 00000000 Is this the stock firmware from upstream or the stuff I pointed you to yesterday on my fdo site? Alex > > Regards, > Andres > > On 2017-04-04 03:59 PM, Tom St Denis wrote: > > I'm using the latest from all open (our internal FC24 repo). I'll fetch > > the exact later with "umr -c". > > > > Tom > > > > On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander > <Alexander.Deucher@amd.com> > > wrote: > > > >>> -----Original Message----- > >>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On > Behalf > >>> Of Andres Rodriguez > >>> Sent: Tuesday, April 04, 2017 3:39 PM > >>> To: StDenis, Tom; amd-gfx@lists.freedesktop.org > >>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES > packet" > >>> > >>> > >>> > >>> On 2017-04-04 08:27 AM, Tom St Denis wrote: > >>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: > >>>>> Commit e579f56 results in a KCQ initialization error for polaris10 > >>>>> cards. Providing the full SET_RESOURCES packet instead of the > >> truncated > >>>>> version fixes the problem. > >>>>> > >>>>> I think this patch may have been one of the stabs at fixing the KCQ > >>>>> suspend/resume errors. I *think* it may no longer be needed if that > is > >>>>> the case. > >>>>> > >>>>> Sending this mostly as an FYI to get the patch removed from the > >> 4.12-wip > >>>>> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. > >>>>> --- > >>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- > >>>>> 1 file changed, 5 insertions(+), 1 deletion(-) > >>>>> > >>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >>>>> index 2d8d7bb..4c3bf51 100644 > >>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >>>>> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct > >>>>> amdgpu_device *adev) > >>>>> return r; > >>>>> } > >>>>> /* set resources */ > >>>>> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, > 2)); > >>>>> + amdgpu_ring_write(kiq_ring, > PACKET3(PACKET3_SET_RESOURCES, > >>> 6)); > >>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 > >>>>> (KIQ) */ > >>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ > >>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ > >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ > >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ > >>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ > >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap > >>>>> size:0 */ > >>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { > >>>>> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; > >>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); > >>>>> > >>>> This fixes init issues with my polaris board but there's still a clock > >>>> problem (CP is pegged at 100% as read by umr) resulting in the GPU > >> clock > >>>> staying at 1200MHz the entire time. > >>>> > >>> Yeah I sent this out because I was having KCQ init issues on my > >>> polaris10 card. However, I'm not seeing the CP pegged at 100% as you > >>> mentioned. Everything sitting quietly at 0% here. > >> Which firmware are you using? > >> > >> Alex > >> > >>> > >>>> Tom > >>>> _______________________________________________ > >>>> amd-gfx mailing list > >>>> amd-gfx@lists.freedesktop.org > >>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > >>> _______________________________________________ > >>> amd-gfx mailing list > >>> amd-gfx@lists.freedesktop.org > >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > >> _______________________________________________ > >> amd-gfx mailing list > >> amd-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > >> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <BN6PR12MB1652C9E0D15D794E02FAB2ADF70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <BN6PR12MB1652C9E0D15D794E02FAB2ADF70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-04-04 20:17 ` Andres Rodriguez [not found] ` <CAFQ_0eH8wU1NOfj5TXR+SKWAbFcRqqS4mK-xEFWuSG82V-zozg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Andres Rodriguez @ 2017-04-04 20:17 UTC (permalink / raw) To: Deucher, Alexander Cc: StDenis, Tom, Tom St Denis, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW This should be the the linux-firmware repository @ commit 6d3bc8886517d171068fd1263176b8b5c51df204 I reverted back to that firmware since I didn't want to deal with possible bugs when testing my patches. Regards, Andres On Tue, Apr 4, 2017 at 4:03 PM, Deucher, Alexander <Alexander.Deucher@amd.com> wrote: >> -----Original Message----- >> From: Andres Rodriguez [mailto:andresx7@gmail.com] >> Sent: Tuesday, April 04, 2017 4:01 PM >> To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd- >> gfx@lists.freedesktop.org >> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" >> >> This is my info in case that is useful: >> >> umr.version == ea8e49bb15ed >> >> fw.VCE == .feature==0 .firmware==0x34040300 >> fw.UVD == .feature==0 .firmware==0x014f1000 >> fw.MC == .feature==0 .firmware==0x00000000 >> fw.ME == .feature==37 .firmware==0x00000094 >> fw.PFP == .feature==37 .firmware==0x000000dc >> fw.CE == .feature==37 .firmware==0x00000080 >> fw.RLC == .feature==1 .firmware==0x0000010e >> fw.MEC == .feature==37 .firmware==0x000002a2 >> fw.MEC2 == .feature==37 .firmware==0x000002a2 >> fw.SOS == .feature==0 .firmware==0x00000000 >> fw.ASD == .feature==0 .firmware==0x00000000 >> fw.SMC == .feature==0 .firmware==0x00170f00 >> fw.SDMA0 == .feature==31 .firmware==0x00000036 >> fw.SDMA1 == .feature==0 .firmware==0x00000036 >> >> asic.instance == 0 >> >> >> gfx.max_shader_engines == 4 >> gfx.max_tile_pipes == 8 >> gfx.max_cu_per_sh == 9 >> gfx.max_sh_per_se == 1 >> gfx.max_backends_per_se == 2 >> gfx.max_texture_channel_caches == 8 >> gfx.max_gprs == 256 >> gfx.max_gs_threads == 32 >> gfx.max_hw_contexts == 8 >> gfx.sc_prim_fifo_size_frontend == 32 >> gfx.sc_prim_fifo_size_backend == 256 >> gfx.sc_hiz_tile_fifo_size == 48 >> gfx.sc_earlyz_tile_fifo_size == 304 >> gfx.num_tile_pipes == 8 >> gfx.backend_enable_mask == 255 >> gfx.mem_max_burst_length_bytes == 256 >> gfx.mem_row_size_in_kb == 4 >> gfx.shader_engine_tile_size == 32 >> gfx.num_gpus == 1 >> gfx.multi_gpu_tile_size == 64 >> gfx.mc_arb_ramcfg == 24738 >> gfx.gb_addr_config == 570494979 >> gfx.num_rbs == 8 >> gfx.family = 130, Volcanic Islands >> gfx.rev_id == 00000001 >> gfx.external_rev_id == 00000051 >> gfx.cg_flags == 003fffcd >> AMD_CG_SUPPORT_GFX_MGCG >> AMD_CG_SUPPORT_GFX_CGCG >> AMD_CG_SUPPORT_GFX_CGLS >> AMD_CG_SUPPORT_GFX_CP_LS >> AMD_CG_SUPPORT_GFX_RLC_LS >> AMD_CG_SUPPORT_MC_LS >> AMD_CG_SUPPORT_MC_MGCG >> AMD_CG_SUPPORT_SDMA_LS >> AMD_CG_SUPPORT_SDMA_MGCG >> AMD_CG_SUPPORT_BIF_LS >> AMD_CG_SUPPORT_UVD_MGCG >> AMD_CG_SUPPORT_VCE_MGCG >> AMD_CG_SUPPORT_HDP_LS >> AMD_CG_SUPPORT_HDP_MGCG >> AMD_CG_SUPPORT_ROM_MGCG >> gfx.pg_flags == 00000000 > > Is this the stock firmware from upstream or the stuff I pointed you to yesterday on my fdo site? > > Alex > >> >> Regards, >> Andres >> >> On 2017-04-04 03:59 PM, Tom St Denis wrote: >> > I'm using the latest from all open (our internal FC24 repo). I'll fetch >> > the exact later with "umr -c". >> > >> > Tom >> > >> > On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander >> <Alexander.Deucher@amd.com> >> > wrote: >> > >> >>> -----Original Message----- >> >>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On >> Behalf >> >>> Of Andres Rodriguez >> >>> Sent: Tuesday, April 04, 2017 3:39 PM >> >>> To: StDenis, Tom; amd-gfx@lists.freedesktop.org >> >>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES >> packet" >> >>> >> >>> >> >>> >> >>> On 2017-04-04 08:27 AM, Tom St Denis wrote: >> >>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: >> >>>>> Commit e579f56 results in a KCQ initialization error for polaris10 >> >>>>> cards. Providing the full SET_RESOURCES packet instead of the >> >> truncated >> >>>>> version fixes the problem. >> >>>>> >> >>>>> I think this patch may have been one of the stabs at fixing the KCQ >> >>>>> suspend/resume errors. I *think* it may no longer be needed if that >> is >> >>>>> the case. >> >>>>> >> >>>>> Sending this mostly as an FYI to get the patch removed from the >> >> 4.12-wip >> >>>>> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. >> >>>>> --- >> >>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- >> >>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >> >>>>> >> >>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> >>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> >>>>> index 2d8d7bb..4c3bf51 100644 >> >>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> >>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> >>>>> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct >> >>>>> amdgpu_device *adev) >> >>>>> return r; >> >>>>> } >> >>>>> /* set resources */ >> >>>>> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, >> 2)); >> >>>>> + amdgpu_ring_write(kiq_ring, >> PACKET3(PACKET3_SET_RESOURCES, >> >>> 6)); >> >>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 >> >>>>> (KIQ) */ >> >>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ >> >>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ >> >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ >> >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ >> >>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ >> >>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap >> >>>>> size:0 */ >> >>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { >> >>>>> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; >> >>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); >> >>>>> >> >>>> This fixes init issues with my polaris board but there's still a clock >> >>>> problem (CP is pegged at 100% as read by umr) resulting in the GPU >> >> clock >> >>>> staying at 1200MHz the entire time. >> >>>> >> >>> Yeah I sent this out because I was having KCQ init issues on my >> >>> polaris10 card. However, I'm not seeing the CP pegged at 100% as you >> >>> mentioned. Everything sitting quietly at 0% here. >> >> Which firmware are you using? >> >> >> >> Alex >> >> >> >>> >> >>>> Tom >> >>>> _______________________________________________ >> >>>> amd-gfx mailing list >> >>>> amd-gfx@lists.freedesktop.org >> >>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >> >>> _______________________________________________ >> >>> amd-gfx mailing list >> >>> amd-gfx@lists.freedesktop.org >> >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >> >> _______________________________________________ >> >> amd-gfx mailing list >> >> amd-gfx@lists.freedesktop.org >> >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >> >> > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <CAFQ_0eH8wU1NOfj5TXR+SKWAbFcRqqS4mK-xEFWuSG82V-zozg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <CAFQ_0eH8wU1NOfj5TXR+SKWAbFcRqqS4mK-xEFWuSG82V-zozg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-04-05 11:30 ` Tom St Denis [not found] ` <08b6ee6a-f201-272c-d812-7f7404a51863-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Tom St Denis @ 2017-04-05 11:30 UTC (permalink / raw) To: Andres Rodriguez, Deucher, Alexander Cc: Tom St Denis, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW My firmware is fw.VCE == .feature==0 .firmware==0x34040300 fw.UVD == .feature==0 .firmware==0x015b0b00 fw.MC == .feature==0 .firmware==0x00000000 fw.ME == .feature==46 .firmware==0x000000a1 fw.PFP == .feature==46 .firmware==0x000000eb fw.CE == .feature==46 .firmware==0x00000086 fw.RLC == .feature==1 .firmware==0x0000009c fw.MEC == .feature==46 .firmware==0x000002c1 fw.MEC2 == .feature==46 .firmware==0x000002c1 fw.SOS == .feature==0 .firmware==0x00000000 fw.ASD == .feature==0 .firmware==0x00000000 fw.SMC == .feature==0 .firmware==0x00000000 fw.SDMA0 == .feature==0 .firmware==0x00000022 fw.SDMA1 == .feature==0 .firmware==0x00000022 It seems like our all-open is behind what he has for SDMA, SMC, RLC but ahead for others? Bizarre. Tom On 04/04/17 04:17 PM, Andres Rodriguez wrote: > This should be the the linux-firmware repository @ commit > 6d3bc8886517d171068fd1263176b8b5c51df204 > > I reverted back to that firmware since I didn't want to deal with > possible bugs when testing my patches. > > Regards, > Andres > > On Tue, Apr 4, 2017 at 4:03 PM, Deucher, Alexander > <Alexander.Deucher@amd.com> wrote: >>> -----Original Message----- >>> From: Andres Rodriguez [mailto:andresx7@gmail.com] >>> Sent: Tuesday, April 04, 2017 4:01 PM >>> To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd- >>> gfx@lists.freedesktop.org >>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" >>> >>> This is my info in case that is useful: >>> >>> umr.version == ea8e49bb15ed >>> >>> fw.VCE == .feature==0 .firmware==0x34040300 >>> fw.UVD == .feature==0 .firmware==0x014f1000 >>> fw.MC == .feature==0 .firmware==0x00000000 >>> fw.ME == .feature==37 .firmware==0x00000094 >>> fw.PFP == .feature==37 .firmware==0x000000dc >>> fw.CE == .feature==37 .firmware==0x00000080 >>> fw.RLC == .feature==1 .firmware==0x0000010e >>> fw.MEC == .feature==37 .firmware==0x000002a2 >>> fw.MEC2 == .feature==37 .firmware==0x000002a2 >>> fw.SOS == .feature==0 .firmware==0x00000000 >>> fw.ASD == .feature==0 .firmware==0x00000000 >>> fw.SMC == .feature==0 .firmware==0x00170f00 >>> fw.SDMA0 == .feature==31 .firmware==0x00000036 >>> fw.SDMA1 == .feature==0 .firmware==0x00000036 >>> >>> asic.instance == 0 >>> >>> >>> gfx.max_shader_engines == 4 >>> gfx.max_tile_pipes == 8 >>> gfx.max_cu_per_sh == 9 >>> gfx.max_sh_per_se == 1 >>> gfx.max_backends_per_se == 2 >>> gfx.max_texture_channel_caches == 8 >>> gfx.max_gprs == 256 >>> gfx.max_gs_threads == 32 >>> gfx.max_hw_contexts == 8 >>> gfx.sc_prim_fifo_size_frontend == 32 >>> gfx.sc_prim_fifo_size_backend == 256 >>> gfx.sc_hiz_tile_fifo_size == 48 >>> gfx.sc_earlyz_tile_fifo_size == 304 >>> gfx.num_tile_pipes == 8 >>> gfx.backend_enable_mask == 255 >>> gfx.mem_max_burst_length_bytes == 256 >>> gfx.mem_row_size_in_kb == 4 >>> gfx.shader_engine_tile_size == 32 >>> gfx.num_gpus == 1 >>> gfx.multi_gpu_tile_size == 64 >>> gfx.mc_arb_ramcfg == 24738 >>> gfx.gb_addr_config == 570494979 >>> gfx.num_rbs == 8 >>> gfx.family = 130, Volcanic Islands >>> gfx.rev_id == 00000001 >>> gfx.external_rev_id == 00000051 >>> gfx.cg_flags == 003fffcd >>> AMD_CG_SUPPORT_GFX_MGCG >>> AMD_CG_SUPPORT_GFX_CGCG >>> AMD_CG_SUPPORT_GFX_CGLS >>> AMD_CG_SUPPORT_GFX_CP_LS >>> AMD_CG_SUPPORT_GFX_RLC_LS >>> AMD_CG_SUPPORT_MC_LS >>> AMD_CG_SUPPORT_MC_MGCG >>> AMD_CG_SUPPORT_SDMA_LS >>> AMD_CG_SUPPORT_SDMA_MGCG >>> AMD_CG_SUPPORT_BIF_LS >>> AMD_CG_SUPPORT_UVD_MGCG >>> AMD_CG_SUPPORT_VCE_MGCG >>> AMD_CG_SUPPORT_HDP_LS >>> AMD_CG_SUPPORT_HDP_MGCG >>> AMD_CG_SUPPORT_ROM_MGCG >>> gfx.pg_flags == 00000000 >> >> Is this the stock firmware from upstream or the stuff I pointed you to yesterday on my fdo site? >> >> Alex >> >>> >>> Regards, >>> Andres >>> >>> On 2017-04-04 03:59 PM, Tom St Denis wrote: >>>> I'm using the latest from all open (our internal FC24 repo). I'll fetch >>>> the exact later with "umr -c". >>>> >>>> Tom >>>> >>>> On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander >>> <Alexander.Deucher@amd.com> >>>> wrote: >>>> >>>>>> -----Original Message----- >>>>>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On >>> Behalf >>>>>> Of Andres Rodriguez >>>>>> Sent: Tuesday, April 04, 2017 3:39 PM >>>>>> To: StDenis, Tom; amd-gfx@lists.freedesktop.org >>>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES >>> packet" >>>>>> >>>>>> >>>>>> >>>>>> On 2017-04-04 08:27 AM, Tom St Denis wrote: >>>>>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: >>>>>>>> Commit e579f56 results in a KCQ initialization error for polaris10 >>>>>>>> cards. Providing the full SET_RESOURCES packet instead of the >>>>> truncated >>>>>>>> version fixes the problem. >>>>>>>> >>>>>>>> I think this patch may have been one of the stabs at fixing the KCQ >>>>>>>> suspend/resume errors. I *think* it may no longer be needed if that >>> is >>>>>>>> the case. >>>>>>>> >>>>>>>> Sending this mostly as an FYI to get the patch removed from the >>>>> 4.12-wip >>>>>>>> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. >>>>>>>> --- >>>>>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- >>>>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>> index 2d8d7bb..4c3bf51 100644 >>>>>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct >>>>>>>> amdgpu_device *adev) >>>>>>>> return r; >>>>>>>> } >>>>>>>> /* set resources */ >>>>>>>> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, >>> 2)); >>>>>>>> + amdgpu_ring_write(kiq_ring, >>> PACKET3(PACKET3_SET_RESOURCES, >>>>>> 6)); >>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0 >>>>>>>> (KIQ) */ >>>>>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */ >>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ >>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ >>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ >>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ >>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap >>>>>>>> size:0 */ >>>>>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { >>>>>>>> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; >>>>>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); >>>>>>>> >>>>>>> This fixes init issues with my polaris board but there's still a clock >>>>>>> problem (CP is pegged at 100% as read by umr) resulting in the GPU >>>>> clock >>>>>>> staying at 1200MHz the entire time. >>>>>>> >>>>>> Yeah I sent this out because I was having KCQ init issues on my >>>>>> polaris10 card. However, I'm not seeing the CP pegged at 100% as you >>>>>> mentioned. Everything sitting quietly at 0% here. >>>>> Which firmware are you using? >>>>> >>>>> Alex >>>>> >>>>>> >>>>>>> Tom >>>>>>> _______________________________________________ >>>>>>> amd-gfx mailing list >>>>>>> amd-gfx@lists.freedesktop.org >>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>>> _______________________________________________ >>>>>> amd-gfx mailing list >>>>>> amd-gfx@lists.freedesktop.org >>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>> _______________________________________________ >>>>> amd-gfx mailing list >>>>> amd-gfx@lists.freedesktop.org >>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>> >> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <08b6ee6a-f201-272c-d812-7f7404a51863-5C7GfCeVMHo@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <08b6ee6a-f201-272c-d812-7f7404a51863-5C7GfCeVMHo@public.gmane.org> @ 2017-04-05 13:06 ` Alex Deucher [not found] ` <CADnq5_O7KZy08QQ2P0mqGMkOdFtFYRh5jrJx_Gfm5Ahxvse8Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Alex Deucher @ 2017-04-05 13:06 UTC (permalink / raw) To: Tom St Denis Cc: Deucher, Alexander, Tom St Denis, Andres Rodriguez, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Wed, Apr 5, 2017 at 7:30 AM, Tom St Denis <tom.stdenis@amd.com> wrote: > My firmware is > > fw.VCE == .feature==0 .firmware==0x34040300 > fw.UVD == .feature==0 .firmware==0x015b0b00 > fw.MC == .feature==0 .firmware==0x00000000 > fw.ME == .feature==46 .firmware==0x000000a1 > fw.PFP == .feature==46 .firmware==0x000000eb > fw.CE == .feature==46 .firmware==0x00000086 > fw.RLC == .feature==1 .firmware==0x0000009c > fw.MEC == .feature==46 .firmware==0x000002c1 > fw.MEC2 == .feature==46 .firmware==0x000002c1 > fw.SOS == .feature==0 .firmware==0x00000000 > fw.ASD == .feature==0 .firmware==0x00000000 > fw.SMC == .feature==0 .firmware==0x00000000 > fw.SDMA0 == .feature==0 .firmware==0x00000022 > fw.SDMA1 == .feature==0 .firmware==0x00000022 > > It seems like our all-open is behind what he has for SDMA, SMC, RLC but > ahead for others? Bizarre. Can you try the upstream ucode? That is what Andres is using. https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git Alex > > Tom > > > On 04/04/17 04:17 PM, Andres Rodriguez wrote: >> >> This should be the the linux-firmware repository @ commit >> 6d3bc8886517d171068fd1263176b8b5c51df204 >> >> I reverted back to that firmware since I didn't want to deal with >> possible bugs when testing my patches. >> >> Regards, >> Andres >> >> On Tue, Apr 4, 2017 at 4:03 PM, Deucher, Alexander >> <Alexander.Deucher@amd.com> wrote: >>>> >>>> -----Original Message----- >>>> From: Andres Rodriguez [mailto:andresx7@gmail.com] >>>> Sent: Tuesday, April 04, 2017 4:01 PM >>>> To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd- >>>> gfx@lists.freedesktop.org >>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" >>>> >>>> This is my info in case that is useful: >>>> >>>> umr.version == ea8e49bb15ed >>>> >>>> fw.VCE == .feature==0 .firmware==0x34040300 >>>> fw.UVD == .feature==0 .firmware==0x014f1000 >>>> fw.MC == .feature==0 .firmware==0x00000000 >>>> fw.ME == .feature==37 .firmware==0x00000094 >>>> fw.PFP == .feature==37 .firmware==0x000000dc >>>> fw.CE == .feature==37 .firmware==0x00000080 >>>> fw.RLC == .feature==1 .firmware==0x0000010e >>>> fw.MEC == .feature==37 .firmware==0x000002a2 >>>> fw.MEC2 == .feature==37 .firmware==0x000002a2 >>>> fw.SOS == .feature==0 .firmware==0x00000000 >>>> fw.ASD == .feature==0 .firmware==0x00000000 >>>> fw.SMC == .feature==0 .firmware==0x00170f00 >>>> fw.SDMA0 == .feature==31 .firmware==0x00000036 >>>> fw.SDMA1 == .feature==0 .firmware==0x00000036 >>>> >>>> asic.instance == 0 >>>> >>>> >>>> gfx.max_shader_engines == 4 >>>> gfx.max_tile_pipes == 8 >>>> gfx.max_cu_per_sh == 9 >>>> gfx.max_sh_per_se == 1 >>>> gfx.max_backends_per_se == 2 >>>> gfx.max_texture_channel_caches == 8 >>>> gfx.max_gprs == 256 >>>> gfx.max_gs_threads == 32 >>>> gfx.max_hw_contexts == 8 >>>> gfx.sc_prim_fifo_size_frontend == 32 >>>> gfx.sc_prim_fifo_size_backend == 256 >>>> gfx.sc_hiz_tile_fifo_size == 48 >>>> gfx.sc_earlyz_tile_fifo_size == 304 >>>> gfx.num_tile_pipes == 8 >>>> gfx.backend_enable_mask == 255 >>>> gfx.mem_max_burst_length_bytes == 256 >>>> gfx.mem_row_size_in_kb == 4 >>>> gfx.shader_engine_tile_size == 32 >>>> gfx.num_gpus == 1 >>>> gfx.multi_gpu_tile_size == 64 >>>> gfx.mc_arb_ramcfg == 24738 >>>> gfx.gb_addr_config == 570494979 >>>> gfx.num_rbs == 8 >>>> gfx.family = 130, Volcanic Islands >>>> gfx.rev_id == 00000001 >>>> gfx.external_rev_id == 00000051 >>>> gfx.cg_flags == 003fffcd >>>> AMD_CG_SUPPORT_GFX_MGCG >>>> AMD_CG_SUPPORT_GFX_CGCG >>>> AMD_CG_SUPPORT_GFX_CGLS >>>> AMD_CG_SUPPORT_GFX_CP_LS >>>> AMD_CG_SUPPORT_GFX_RLC_LS >>>> AMD_CG_SUPPORT_MC_LS >>>> AMD_CG_SUPPORT_MC_MGCG >>>> AMD_CG_SUPPORT_SDMA_LS >>>> AMD_CG_SUPPORT_SDMA_MGCG >>>> AMD_CG_SUPPORT_BIF_LS >>>> AMD_CG_SUPPORT_UVD_MGCG >>>> AMD_CG_SUPPORT_VCE_MGCG >>>> AMD_CG_SUPPORT_HDP_LS >>>> AMD_CG_SUPPORT_HDP_MGCG >>>> AMD_CG_SUPPORT_ROM_MGCG >>>> gfx.pg_flags == 00000000 >>> >>> >>> Is this the stock firmware from upstream or the stuff I pointed you to >>> yesterday on my fdo site? >>> >>> Alex >>> >>>> >>>> Regards, >>>> Andres >>>> >>>> On 2017-04-04 03:59 PM, Tom St Denis wrote: >>>>> >>>>> I'm using the latest from all open (our internal FC24 repo). I'll >>>>> fetch >>>>> the exact later with "umr -c". >>>>> >>>>> Tom >>>>> >>>>> On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander >>>> >>>> <Alexander.Deucher@amd.com> >>>>> >>>>> wrote: >>>>> >>>>>>> -----Original Message----- >>>>>>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On >>>> >>>> Behalf >>>>>>> >>>>>>> Of Andres Rodriguez >>>>>>> Sent: Tuesday, April 04, 2017 3:39 PM >>>>>>> To: StDenis, Tom; amd-gfx@lists.freedesktop.org >>>>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES >>>> >>>> packet" >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 2017-04-04 08:27 AM, Tom St Denis wrote: >>>>>>>> >>>>>>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: >>>>>>>>> >>>>>>>>> Commit e579f56 results in a KCQ initialization error for polaris10 >>>>>>>>> cards. Providing the full SET_RESOURCES packet instead of the >>>>>> >>>>>> truncated >>>>>>>>> >>>>>>>>> version fixes the problem. >>>>>>>>> >>>>>>>>> I think this patch may have been one of the stabs at fixing the KCQ >>>>>>>>> suspend/resume errors. I *think* it may no longer be needed if that >>>> >>>> is >>>>>>>>> >>>>>>>>> the case. >>>>>>>>> >>>>>>>>> Sending this mostly as an FYI to get the patch removed from the >>>>>> >>>>>> 4.12-wip >>>>>>>>> >>>>>>>>> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. >>>>>>>>> --- >>>>>>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- >>>>>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>>>>>>> >>>>>>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>>> index 2d8d7bb..4c3bf51 100644 >>>>>>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>>> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct >>>>>>>>> amdgpu_device *adev) >>>>>>>>> return r; >>>>>>>>> } >>>>>>>>> /* set resources */ >>>>>>>>> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, >>>> >>>> 2)); >>>>>>>>> >>>>>>>>> + amdgpu_ring_write(kiq_ring, >>>> >>>> PACKET3(PACKET3_SET_RESOURCES, >>>>>>> >>>>>>> 6)); >>>>>>>>> >>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 >>>>>>>>> queue_type:0 >>>>>>>>> (KIQ) */ >>>>>>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo >>>>>>>>> */ >>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ >>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ >>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ >>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ >>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds >>>>>>>>> heap >>>>>>>>> size:0 */ >>>>>>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { >>>>>>>>> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; >>>>>>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); >>>>>>>>> >>>>>>>> This fixes init issues with my polaris board but there's still a >>>>>>>> clock >>>>>>>> problem (CP is pegged at 100% as read by umr) resulting in the GPU >>>>>> >>>>>> clock >>>>>>>> >>>>>>>> staying at 1200MHz the entire time. >>>>>>>> >>>>>>> Yeah I sent this out because I was having KCQ init issues on my >>>>>>> polaris10 card. However, I'm not seeing the CP pegged at 100% as you >>>>>>> mentioned. Everything sitting quietly at 0% here. >>>>>> >>>>>> Which firmware are you using? >>>>>> >>>>>> Alex >>>>>> >>>>>>> >>>>>>>> Tom >>>>>>>> _______________________________________________ >>>>>>>> amd-gfx mailing list >>>>>>>> amd-gfx@lists.freedesktop.org >>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>>>> >>>>>>> _______________________________________________ >>>>>>> amd-gfx mailing list >>>>>>> amd-gfx@lists.freedesktop.org >>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>>> >>>>>> _______________________________________________ >>>>>> amd-gfx mailing list >>>>>> amd-gfx@lists.freedesktop.org >>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>>> >>> > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <CADnq5_O7KZy08QQ2P0mqGMkOdFtFYRh5jrJx_Gfm5Ahxvse8Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <CADnq5_O7KZy08QQ2P0mqGMkOdFtFYRh5jrJx_Gfm5Ahxvse8Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-04-05 13:14 ` Tom St Denis [not found] ` <682c9bb0-19d6-f64a-84d1-73dd77824aa4-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Tom St Denis @ 2017-04-05 13:14 UTC (permalink / raw) To: Alex Deucher Cc: Deucher, Alexander, Tom St Denis, Andres Rodriguez, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 05/04/17 09:06 AM, Alex Deucher wrote: > On Wed, Apr 5, 2017 at 7:30 AM, Tom St Denis <tom.stdenis@amd.com> wrote: >> My firmware is >> >> fw.VCE == .feature==0 .firmware==0x34040300 >> fw.UVD == .feature==0 .firmware==0x015b0b00 >> fw.MC == .feature==0 .firmware==0x00000000 >> fw.ME == .feature==46 .firmware==0x000000a1 >> fw.PFP == .feature==46 .firmware==0x000000eb >> fw.CE == .feature==46 .firmware==0x00000086 >> fw.RLC == .feature==1 .firmware==0x0000009c >> fw.MEC == .feature==46 .firmware==0x000002c1 >> fw.MEC2 == .feature==46 .firmware==0x000002c1 >> fw.SOS == .feature==0 .firmware==0x00000000 >> fw.ASD == .feature==0 .firmware==0x00000000 >> fw.SMC == .feature==0 .firmware==0x00000000 >> fw.SDMA0 == .feature==0 .firmware==0x00000022 >> fw.SDMA1 == .feature==0 .firmware==0x00000022 >> >> It seems like our all-open is behind what he has for SDMA, SMC, RLC but >> ahead for others? Bizarre. > > Can you try the upstream ucode? That is what Andres is using. > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git Copying the tip of master from that to my /lib/firmware/ results in the same firmware versions being loaded. > > Alex > >> >> Tom >> >> >> On 04/04/17 04:17 PM, Andres Rodriguez wrote: >>> >>> This should be the the linux-firmware repository @ commit >>> 6d3bc8886517d171068fd1263176b8b5c51df204 >>> >>> I reverted back to that firmware since I didn't want to deal with >>> possible bugs when testing my patches. >>> >>> Regards, >>> Andres >>> >>> On Tue, Apr 4, 2017 at 4:03 PM, Deucher, Alexander >>> <Alexander.Deucher@amd.com> wrote: >>>>> >>>>> -----Original Message----- >>>>> From: Andres Rodriguez [mailto:andresx7@gmail.com] >>>>> Sent: Tuesday, April 04, 2017 4:01 PM >>>>> To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd- >>>>> gfx@lists.freedesktop.org >>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" >>>>> >>>>> This is my info in case that is useful: >>>>> >>>>> umr.version == ea8e49bb15ed >>>>> >>>>> fw.VCE == .feature==0 .firmware==0x34040300 >>>>> fw.UVD == .feature==0 .firmware==0x014f1000 >>>>> fw.MC == .feature==0 .firmware==0x00000000 >>>>> fw.ME == .feature==37 .firmware==0x00000094 >>>>> fw.PFP == .feature==37 .firmware==0x000000dc >>>>> fw.CE == .feature==37 .firmware==0x00000080 >>>>> fw.RLC == .feature==1 .firmware==0x0000010e >>>>> fw.MEC == .feature==37 .firmware==0x000002a2 >>>>> fw.MEC2 == .feature==37 .firmware==0x000002a2 >>>>> fw.SOS == .feature==0 .firmware==0x00000000 >>>>> fw.ASD == .feature==0 .firmware==0x00000000 >>>>> fw.SMC == .feature==0 .firmware==0x00170f00 >>>>> fw.SDMA0 == .feature==31 .firmware==0x00000036 >>>>> fw.SDMA1 == .feature==0 .firmware==0x00000036 >>>>> >>>>> asic.instance == 0 >>>>> >>>>> >>>>> gfx.max_shader_engines == 4 >>>>> gfx.max_tile_pipes == 8 >>>>> gfx.max_cu_per_sh == 9 >>>>> gfx.max_sh_per_se == 1 >>>>> gfx.max_backends_per_se == 2 >>>>> gfx.max_texture_channel_caches == 8 >>>>> gfx.max_gprs == 256 >>>>> gfx.max_gs_threads == 32 >>>>> gfx.max_hw_contexts == 8 >>>>> gfx.sc_prim_fifo_size_frontend == 32 >>>>> gfx.sc_prim_fifo_size_backend == 256 >>>>> gfx.sc_hiz_tile_fifo_size == 48 >>>>> gfx.sc_earlyz_tile_fifo_size == 304 >>>>> gfx.num_tile_pipes == 8 >>>>> gfx.backend_enable_mask == 255 >>>>> gfx.mem_max_burst_length_bytes == 256 >>>>> gfx.mem_row_size_in_kb == 4 >>>>> gfx.shader_engine_tile_size == 32 >>>>> gfx.num_gpus == 1 >>>>> gfx.multi_gpu_tile_size == 64 >>>>> gfx.mc_arb_ramcfg == 24738 >>>>> gfx.gb_addr_config == 570494979 >>>>> gfx.num_rbs == 8 >>>>> gfx.family = 130, Volcanic Islands >>>>> gfx.rev_id == 00000001 >>>>> gfx.external_rev_id == 00000051 >>>>> gfx.cg_flags == 003fffcd >>>>> AMD_CG_SUPPORT_GFX_MGCG >>>>> AMD_CG_SUPPORT_GFX_CGCG >>>>> AMD_CG_SUPPORT_GFX_CGLS >>>>> AMD_CG_SUPPORT_GFX_CP_LS >>>>> AMD_CG_SUPPORT_GFX_RLC_LS >>>>> AMD_CG_SUPPORT_MC_LS >>>>> AMD_CG_SUPPORT_MC_MGCG >>>>> AMD_CG_SUPPORT_SDMA_LS >>>>> AMD_CG_SUPPORT_SDMA_MGCG >>>>> AMD_CG_SUPPORT_BIF_LS >>>>> AMD_CG_SUPPORT_UVD_MGCG >>>>> AMD_CG_SUPPORT_VCE_MGCG >>>>> AMD_CG_SUPPORT_HDP_LS >>>>> AMD_CG_SUPPORT_HDP_MGCG >>>>> AMD_CG_SUPPORT_ROM_MGCG >>>>> gfx.pg_flags == 00000000 >>>> >>>> >>>> Is this the stock firmware from upstream or the stuff I pointed you to >>>> yesterday on my fdo site? >>>> >>>> Alex >>>> >>>>> >>>>> Regards, >>>>> Andres >>>>> >>>>> On 2017-04-04 03:59 PM, Tom St Denis wrote: >>>>>> >>>>>> I'm using the latest from all open (our internal FC24 repo). I'll >>>>>> fetch >>>>>> the exact later with "umr -c". >>>>>> >>>>>> Tom >>>>>> >>>>>> On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander >>>>> >>>>> <Alexander.Deucher@amd.com> >>>>>> >>>>>> wrote: >>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On >>>>> >>>>> Behalf >>>>>>>> >>>>>>>> Of Andres Rodriguez >>>>>>>> Sent: Tuesday, April 04, 2017 3:39 PM >>>>>>>> To: StDenis, Tom; amd-gfx@lists.freedesktop.org >>>>>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES >>>>> >>>>> packet" >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 2017-04-04 08:27 AM, Tom St Denis wrote: >>>>>>>>> >>>>>>>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: >>>>>>>>>> >>>>>>>>>> Commit e579f56 results in a KCQ initialization error for polaris10 >>>>>>>>>> cards. Providing the full SET_RESOURCES packet instead of the >>>>>>> >>>>>>> truncated >>>>>>>>>> >>>>>>>>>> version fixes the problem. >>>>>>>>>> >>>>>>>>>> I think this patch may have been one of the stabs at fixing the KCQ >>>>>>>>>> suspend/resume errors. I *think* it may no longer be needed if that >>>>> >>>>> is >>>>>>>>>> >>>>>>>>>> the case. >>>>>>>>>> >>>>>>>>>> Sending this mostly as an FYI to get the patch removed from the >>>>>>> >>>>>>> 4.12-wip >>>>>>>>>> >>>>>>>>>> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f. >>>>>>>>>> --- >>>>>>>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- >>>>>>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>>>>>>>> >>>>>>>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>>>> index 2d8d7bb..4c3bf51 100644 >>>>>>>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >>>>>>>>>> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct >>>>>>>>>> amdgpu_device *adev) >>>>>>>>>> return r; >>>>>>>>>> } >>>>>>>>>> /* set resources */ >>>>>>>>>> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, >>>>> >>>>> 2)); >>>>>>>>>> >>>>>>>>>> + amdgpu_ring_write(kiq_ring, >>>>> >>>>> PACKET3(PACKET3_SET_RESOURCES, >>>>>>>> >>>>>>>> 6)); >>>>>>>>>> >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 >>>>>>>>>> queue_type:0 >>>>>>>>>> (KIQ) */ >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo >>>>>>>>>> */ >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds >>>>>>>>>> heap >>>>>>>>>> size:0 */ >>>>>>>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { >>>>>>>>>> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; >>>>>>>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj); >>>>>>>>>> >>>>>>>>> This fixes init issues with my polaris board but there's still a >>>>>>>>> clock >>>>>>>>> problem (CP is pegged at 100% as read by umr) resulting in the GPU >>>>>>> >>>>>>> clock >>>>>>>>> >>>>>>>>> staying at 1200MHz the entire time. >>>>>>>>> >>>>>>>> Yeah I sent this out because I was having KCQ init issues on my >>>>>>>> polaris10 card. However, I'm not seeing the CP pegged at 100% as you >>>>>>>> mentioned. Everything sitting quietly at 0% here. >>>>>>> >>>>>>> Which firmware are you using? >>>>>>> >>>>>>> Alex >>>>>>> >>>>>>>> >>>>>>>>> Tom >>>>>>>>> _______________________________________________ >>>>>>>>> amd-gfx mailing list >>>>>>>>> amd-gfx@lists.freedesktop.org >>>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> amd-gfx mailing list >>>>>>>> amd-gfx@lists.freedesktop.org >>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>>>> >>>>>>> _______________________________________________ >>>>>>> amd-gfx mailing list >>>>>>> amd-gfx@lists.freedesktop.org >>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>>>>>> >>>> >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <682c9bb0-19d6-f64a-84d1-73dd77824aa4-5C7GfCeVMHo@public.gmane.org>]
* RE: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <682c9bb0-19d6-f64a-84d1-73dd77824aa4-5C7GfCeVMHo@public.gmane.org> @ 2017-04-05 13:56 ` Deucher, Alexander [not found] ` <BN6PR12MB1652D439580DE76681B0EFA7F70A0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Deucher, Alexander @ 2017-04-05 13:56 UTC (permalink / raw) To: StDenis, Tom, Alex Deucher Cc: Tom St Denis, Andres Rodriguez, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW > -----Original Message----- > From: StDenis, Tom > Sent: Wednesday, April 05, 2017 9:14 AM > To: Alex Deucher > Cc: Andres Rodriguez; Deucher, Alexander; Tom St Denis; amd- > gfx@lists.freedesktop.org > Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" > > On 05/04/17 09:06 AM, Alex Deucher wrote: > > On Wed, Apr 5, 2017 at 7:30 AM, Tom St Denis <tom.stdenis@amd.com> > wrote: > >> My firmware is > >> > >> fw.VCE == .feature==0 .firmware==0x34040300 > >> fw.UVD == .feature==0 .firmware==0x015b0b00 > >> fw.MC == .feature==0 .firmware==0x00000000 > >> fw.ME == .feature==46 .firmware==0x000000a1 > >> fw.PFP == .feature==46 .firmware==0x000000eb > >> fw.CE == .feature==46 .firmware==0x00000086 > >> fw.RLC == .feature==1 .firmware==0x0000009c > >> fw.MEC == .feature==46 .firmware==0x000002c1 > >> fw.MEC2 == .feature==46 .firmware==0x000002c1 > >> fw.SOS == .feature==0 .firmware==0x00000000 > >> fw.ASD == .feature==0 .firmware==0x00000000 > >> fw.SMC == .feature==0 .firmware==0x00000000 > >> fw.SDMA0 == .feature==0 .firmware==0x00000022 > >> fw.SDMA1 == .feature==0 .firmware==0x00000022 > >> > >> It seems like our all-open is behind what he has for SDMA, SMC, RLC but > >> ahead for others? Bizarre. > > > > Can you try the upstream ucode? That is what Andres is using. > > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux- > firmware.git > > Copying the tip of master from that to my /lib/firmware/ results in the > same firmware versions being loaded. > Same as you or same as Andres? Alex > > > > Alex > > > >> > >> Tom > >> > >> > >> On 04/04/17 04:17 PM, Andres Rodriguez wrote: > >>> > >>> This should be the the linux-firmware repository @ commit > >>> 6d3bc8886517d171068fd1263176b8b5c51df204 > >>> > >>> I reverted back to that firmware since I didn't want to deal with > >>> possible bugs when testing my patches. > >>> > >>> Regards, > >>> Andres > >>> > >>> On Tue, Apr 4, 2017 at 4:03 PM, Deucher, Alexander > >>> <Alexander.Deucher@amd.com> wrote: > >>>>> > >>>>> -----Original Message----- > >>>>> From: Andres Rodriguez [mailto:andresx7@gmail.com] > >>>>> Sent: Tuesday, April 04, 2017 4:01 PM > >>>>> To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd- > >>>>> gfx@lists.freedesktop.org > >>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES > packet" > >>>>> > >>>>> This is my info in case that is useful: > >>>>> > >>>>> umr.version == ea8e49bb15ed > >>>>> > >>>>> fw.VCE == .feature==0 .firmware==0x34040300 > >>>>> fw.UVD == .feature==0 .firmware==0x014f1000 > >>>>> fw.MC == .feature==0 .firmware==0x00000000 > >>>>> fw.ME == .feature==37 .firmware==0x00000094 > >>>>> fw.PFP == .feature==37 .firmware==0x000000dc > >>>>> fw.CE == .feature==37 .firmware==0x00000080 > >>>>> fw.RLC == .feature==1 .firmware==0x0000010e > >>>>> fw.MEC == .feature==37 .firmware==0x000002a2 > >>>>> fw.MEC2 == .feature==37 .firmware==0x000002a2 > >>>>> fw.SOS == .feature==0 .firmware==0x00000000 > >>>>> fw.ASD == .feature==0 .firmware==0x00000000 > >>>>> fw.SMC == .feature==0 .firmware==0x00170f00 > >>>>> fw.SDMA0 == .feature==31 .firmware==0x00000036 > >>>>> fw.SDMA1 == .feature==0 .firmware==0x00000036 > >>>>> > >>>>> asic.instance == 0 > >>>>> > >>>>> > >>>>> gfx.max_shader_engines == 4 > >>>>> gfx.max_tile_pipes == 8 > >>>>> gfx.max_cu_per_sh == 9 > >>>>> gfx.max_sh_per_se == 1 > >>>>> gfx.max_backends_per_se == 2 > >>>>> gfx.max_texture_channel_caches == 8 > >>>>> gfx.max_gprs == 256 > >>>>> gfx.max_gs_threads == 32 > >>>>> gfx.max_hw_contexts == 8 > >>>>> gfx.sc_prim_fifo_size_frontend == 32 > >>>>> gfx.sc_prim_fifo_size_backend == 256 > >>>>> gfx.sc_hiz_tile_fifo_size == 48 > >>>>> gfx.sc_earlyz_tile_fifo_size == 304 > >>>>> gfx.num_tile_pipes == 8 > >>>>> gfx.backend_enable_mask == 255 > >>>>> gfx.mem_max_burst_length_bytes == 256 > >>>>> gfx.mem_row_size_in_kb == 4 > >>>>> gfx.shader_engine_tile_size == 32 > >>>>> gfx.num_gpus == 1 > >>>>> gfx.multi_gpu_tile_size == 64 > >>>>> gfx.mc_arb_ramcfg == 24738 > >>>>> gfx.gb_addr_config == 570494979 > >>>>> gfx.num_rbs == 8 > >>>>> gfx.family = 130, Volcanic Islands > >>>>> gfx.rev_id == 00000001 > >>>>> gfx.external_rev_id == 00000051 > >>>>> gfx.cg_flags == 003fffcd > >>>>> AMD_CG_SUPPORT_GFX_MGCG > >>>>> AMD_CG_SUPPORT_GFX_CGCG > >>>>> AMD_CG_SUPPORT_GFX_CGLS > >>>>> AMD_CG_SUPPORT_GFX_CP_LS > >>>>> AMD_CG_SUPPORT_GFX_RLC_LS > >>>>> AMD_CG_SUPPORT_MC_LS > >>>>> AMD_CG_SUPPORT_MC_MGCG > >>>>> AMD_CG_SUPPORT_SDMA_LS > >>>>> AMD_CG_SUPPORT_SDMA_MGCG > >>>>> AMD_CG_SUPPORT_BIF_LS > >>>>> AMD_CG_SUPPORT_UVD_MGCG > >>>>> AMD_CG_SUPPORT_VCE_MGCG > >>>>> AMD_CG_SUPPORT_HDP_LS > >>>>> AMD_CG_SUPPORT_HDP_MGCG > >>>>> AMD_CG_SUPPORT_ROM_MGCG > >>>>> gfx.pg_flags == 00000000 > >>>> > >>>> > >>>> Is this the stock firmware from upstream or the stuff I pointed you to > >>>> yesterday on my fdo site? > >>>> > >>>> Alex > >>>> > >>>>> > >>>>> Regards, > >>>>> Andres > >>>>> > >>>>> On 2017-04-04 03:59 PM, Tom St Denis wrote: > >>>>>> > >>>>>> I'm using the latest from all open (our internal FC24 repo). I'll > >>>>>> fetch > >>>>>> the exact later with "umr -c". > >>>>>> > >>>>>> Tom > >>>>>> > >>>>>> On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander > >>>>> > >>>>> <Alexander.Deucher@amd.com> > >>>>>> > >>>>>> wrote: > >>>>>> > >>>>>>>> -----Original Message----- > >>>>>>>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] > On > >>>>> > >>>>> Behalf > >>>>>>>> > >>>>>>>> Of Andres Rodriguez > >>>>>>>> Sent: Tuesday, April 04, 2017 3:39 PM > >>>>>>>> To: StDenis, Tom; amd-gfx@lists.freedesktop.org > >>>>>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES > >>>>> > >>>>> packet" > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> On 2017-04-04 08:27 AM, Tom St Denis wrote: > >>>>>>>>> > >>>>>>>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: > >>>>>>>>>> > >>>>>>>>>> Commit e579f56 results in a KCQ initialization error for polaris10 > >>>>>>>>>> cards. Providing the full SET_RESOURCES packet instead of the > >>>>>>> > >>>>>>> truncated > >>>>>>>>>> > >>>>>>>>>> version fixes the problem. > >>>>>>>>>> > >>>>>>>>>> I think this patch may have been one of the stabs at fixing the > KCQ > >>>>>>>>>> suspend/resume errors. I *think* it may no longer be needed > if that > >>>>> > >>>>> is > >>>>>>>>>> > >>>>>>>>>> the case. > >>>>>>>>>> > >>>>>>>>>> Sending this mostly as an FYI to get the patch removed from > the > >>>>>>> > >>>>>>> 4.12-wip > >>>>>>>>>> > >>>>>>>>>> This reverts commit > e579f564c333a7eaddf7e12b1b8414410c36e80f. > >>>>>>>>>> --- > >>>>>>>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- > >>>>>>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) > >>>>>>>>>> > >>>>>>>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >>>>>>>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >>>>>>>>>> index 2d8d7bb..4c3bf51 100644 > >>>>>>>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >>>>>>>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > >>>>>>>>>> @@ -4647,10 +4647,14 @@ static int > gfx_v8_0_kiq_kcq_enable(struct > >>>>>>>>>> amdgpu_device *adev) > >>>>>>>>>> return r; > >>>>>>>>>> } > >>>>>>>>>> /* set resources */ > >>>>>>>>>> - amdgpu_ring_write(kiq_ring, > PACKET3(PACKET3_SET_RESOURCES, > >>>>> > >>>>> 2)); > >>>>>>>>>> > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, > >>>>> > >>>>> PACKET3(PACKET3_SET_RESOURCES, > >>>>>>>> > >>>>>>>> 6)); > >>>>>>>>>> > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 > >>>>>>>>>> queue_type:0 > >>>>>>>>>> (KIQ) */ > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask > lo > >>>>>>>>>> */ > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds > >>>>>>>>>> heap > >>>>>>>>>> size:0 */ > >>>>>>>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { > >>>>>>>>>> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; > >>>>>>>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring- > >mqd_obj); > >>>>>>>>>> > >>>>>>>>> This fixes init issues with my polaris board but there's still a > >>>>>>>>> clock > >>>>>>>>> problem (CP is pegged at 100% as read by umr) resulting in the > GPU > >>>>>>> > >>>>>>> clock > >>>>>>>>> > >>>>>>>>> staying at 1200MHz the entire time. > >>>>>>>>> > >>>>>>>> Yeah I sent this out because I was having KCQ init issues on my > >>>>>>>> polaris10 card. However, I'm not seeing the CP pegged at 100% as > you > >>>>>>>> mentioned. Everything sitting quietly at 0% here. > >>>>>>> > >>>>>>> Which firmware are you using? > >>>>>>> > >>>>>>> Alex > >>>>>>> > >>>>>>>> > >>>>>>>>> Tom > >>>>>>>>> _______________________________________________ > >>>>>>>>> amd-gfx mailing list > >>>>>>>>> amd-gfx@lists.freedesktop.org > >>>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > >>>>>>>> > >>>>>>>> _______________________________________________ > >>>>>>>> amd-gfx mailing list > >>>>>>>> amd-gfx@lists.freedesktop.org > >>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > >>>>>>> > >>>>>>> _______________________________________________ > >>>>>>> amd-gfx mailing list > >>>>>>> amd-gfx@lists.freedesktop.org > >>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > >>>>>>> > >>>> > >> > >> _______________________________________________ > >> amd-gfx mailing list > >> amd-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <BN6PR12MB1652D439580DE76681B0EFA7F70A0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* RE: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <BN6PR12MB1652D439580DE76681B0EFA7F70A0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-04-05 15:34 ` Andres Rodriguez [not found] ` <CAFQ_0eHiU=HNCpPA=2+Op0944anFsb1w-=Q3923LXPY02Pia3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 14+ messages in thread From: Andres Rodriguez @ 2017-04-05 15:34 UTC (permalink / raw) To: Deucher, Alexander; +Cc: StDenis, Tom, Alex Deucher, Tom St Denis, amd-gfx list [-- Attachment #1.1: Type: text/plain, Size: 11385 bytes --] Hey Tom, If it's the same as your old firmware you might be missing an extra step. I usually just run the kernel 'make install' as that usually take care of the distro specific quirks. Regards, Andres On Apr 5, 2017 9:56 AM, "Deucher, Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org> wrote: > > -----Original Message----- > > From: StDenis, Tom > > Sent: Wednesday, April 05, 2017 9:14 AM > > To: Alex Deucher > > Cc: Andres Rodriguez; Deucher, Alexander; Tom St Denis; amd- > > gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" > > > > On 05/04/17 09:06 AM, Alex Deucher wrote: > > > On Wed, Apr 5, 2017 at 7:30 AM, Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org> > > wrote: > > >> My firmware is > > >> > > >> fw.VCE == .feature==0 .firmware==0x34040300 > > >> fw.UVD == .feature==0 .firmware==0x015b0b00 > > >> fw.MC == .feature==0 .firmware==0x00000000 > > >> fw.ME == .feature==46 .firmware==0x000000a1 > > >> fw.PFP == .feature==46 .firmware==0x000000eb > > >> fw.CE == .feature==46 .firmware==0x00000086 > > >> fw.RLC == .feature==1 .firmware==0x0000009c > > >> fw.MEC == .feature==46 .firmware==0x000002c1 > > >> fw.MEC2 == .feature==46 .firmware==0x000002c1 > > >> fw.SOS == .feature==0 .firmware==0x00000000 > > >> fw.ASD == .feature==0 .firmware==0x00000000 > > >> fw.SMC == .feature==0 .firmware==0x00000000 > > >> fw.SDMA0 == .feature==0 .firmware==0x00000022 > > >> fw.SDMA1 == .feature==0 .firmware==0x00000022 > > >> > > >> It seems like our all-open is behind what he has for SDMA, SMC, RLC > but > > >> ahead for others? Bizarre. > > > > > > Can you try the upstream ucode? That is what Andres is using. > > > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux- > > firmware.git > > > > Copying the tip of master from that to my /lib/firmware/ results in the > > same firmware versions being loaded. > > > > Same as you or same as Andres? > > Alex > > > > > > > Alex > > > > > >> > > >> Tom > > >> > > >> > > >> On 04/04/17 04:17 PM, Andres Rodriguez wrote: > > >>> > > >>> This should be the the linux-firmware repository @ commit > > >>> 6d3bc8886517d171068fd1263176b8b5c51df204 > > >>> > > >>> I reverted back to that firmware since I didn't want to deal with > > >>> possible bugs when testing my patches. > > >>> > > >>> Regards, > > >>> Andres > > >>> > > >>> On Tue, Apr 4, 2017 at 4:03 PM, Deucher, Alexander > > >>> <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org> wrote: > > >>>>> > > >>>>> -----Original Message----- > > >>>>> From: Andres Rodriguez [mailto:andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org] > > >>>>> Sent: Tuesday, April 04, 2017 4:01 PM > > >>>>> To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd- > > >>>>> gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > >>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES > > packet" > > >>>>> > > >>>>> This is my info in case that is useful: > > >>>>> > > >>>>> umr.version == ea8e49bb15ed > > >>>>> > > >>>>> fw.VCE == .feature==0 .firmware==0x34040300 > > >>>>> fw.UVD == .feature==0 .firmware==0x014f1000 > > >>>>> fw.MC == .feature==0 .firmware==0x00000000 > > >>>>> fw.ME == .feature==37 .firmware==0x00000094 > > >>>>> fw.PFP == .feature==37 .firmware==0x000000dc > > >>>>> fw.CE == .feature==37 .firmware==0x00000080 > > >>>>> fw.RLC == .feature==1 .firmware==0x0000010e > > >>>>> fw.MEC == .feature==37 .firmware==0x000002a2 > > >>>>> fw.MEC2 == .feature==37 .firmware==0x000002a2 > > >>>>> fw.SOS == .feature==0 .firmware==0x00000000 > > >>>>> fw.ASD == .feature==0 .firmware==0x00000000 > > >>>>> fw.SMC == .feature==0 .firmware==0x00170f00 > > >>>>> fw.SDMA0 == .feature==31 .firmware==0x00000036 > > >>>>> fw.SDMA1 == .feature==0 .firmware==0x00000036 > > >>>>> > > >>>>> asic.instance == 0 > > >>>>> > > >>>>> > > >>>>> gfx.max_shader_engines == 4 > > >>>>> gfx.max_tile_pipes == 8 > > >>>>> gfx.max_cu_per_sh == 9 > > >>>>> gfx.max_sh_per_se == 1 > > >>>>> gfx.max_backends_per_se == 2 > > >>>>> gfx.max_texture_channel_caches == 8 > > >>>>> gfx.max_gprs == 256 > > >>>>> gfx.max_gs_threads == 32 > > >>>>> gfx.max_hw_contexts == 8 > > >>>>> gfx.sc_prim_fifo_size_frontend == 32 > > >>>>> gfx.sc_prim_fifo_size_backend == 256 > > >>>>> gfx.sc_hiz_tile_fifo_size == 48 > > >>>>> gfx.sc_earlyz_tile_fifo_size == 304 > > >>>>> gfx.num_tile_pipes == 8 > > >>>>> gfx.backend_enable_mask == 255 > > >>>>> gfx.mem_max_burst_length_bytes == 256 > > >>>>> gfx.mem_row_size_in_kb == 4 > > >>>>> gfx.shader_engine_tile_size == 32 > > >>>>> gfx.num_gpus == 1 > > >>>>> gfx.multi_gpu_tile_size == 64 > > >>>>> gfx.mc_arb_ramcfg == 24738 > > >>>>> gfx.gb_addr_config == 570494979 > > >>>>> gfx.num_rbs == 8 > > >>>>> gfx.family = 130, Volcanic Islands > > >>>>> gfx.rev_id == 00000001 > > >>>>> gfx.external_rev_id == 00000051 > > >>>>> gfx.cg_flags == 003fffcd > > >>>>> AMD_CG_SUPPORT_GFX_MGCG > > >>>>> AMD_CG_SUPPORT_GFX_CGCG > > >>>>> AMD_CG_SUPPORT_GFX_CGLS > > >>>>> AMD_CG_SUPPORT_GFX_CP_LS > > >>>>> AMD_CG_SUPPORT_GFX_RLC_LS > > >>>>> AMD_CG_SUPPORT_MC_LS > > >>>>> AMD_CG_SUPPORT_MC_MGCG > > >>>>> AMD_CG_SUPPORT_SDMA_LS > > >>>>> AMD_CG_SUPPORT_SDMA_MGCG > > >>>>> AMD_CG_SUPPORT_BIF_LS > > >>>>> AMD_CG_SUPPORT_UVD_MGCG > > >>>>> AMD_CG_SUPPORT_VCE_MGCG > > >>>>> AMD_CG_SUPPORT_HDP_LS > > >>>>> AMD_CG_SUPPORT_HDP_MGCG > > >>>>> AMD_CG_SUPPORT_ROM_MGCG > > >>>>> gfx.pg_flags == 00000000 > > >>>> > > >>>> > > >>>> Is this the stock firmware from upstream or the stuff I pointed you > to > > >>>> yesterday on my fdo site? > > >>>> > > >>>> Alex > > >>>> > > >>>>> > > >>>>> Regards, > > >>>>> Andres > > >>>>> > > >>>>> On 2017-04-04 03:59 PM, Tom St Denis wrote: > > >>>>>> > > >>>>>> I'm using the latest from all open (our internal FC24 repo). I'll > > >>>>>> fetch > > >>>>>> the exact later with "umr -c". > > >>>>>> > > >>>>>> Tom > > >>>>>> > > >>>>>> On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander > > >>>>> > > >>>>> <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org> > > >>>>>> > > >>>>>> wrote: > > >>>>>> > > >>>>>>>> -----Original Message----- > > >>>>>>>> From: amd-gfx [mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org] > > On > > >>>>> > > >>>>> Behalf > > >>>>>>>> > > >>>>>>>> Of Andres Rodriguez > > >>>>>>>> Sent: Tuesday, April 04, 2017 3:39 PM > > >>>>>>>> To: StDenis, Tom; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > >>>>>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES > > >>>>> > > >>>>> packet" > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> On 2017-04-04 08:27 AM, Tom St Denis wrote: > > >>>>>>>>> > > >>>>>>>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: > > >>>>>>>>>> > > >>>>>>>>>> Commit e579f56 results in a KCQ initialization error for > polaris10 > > >>>>>>>>>> cards. Providing the full SET_RESOURCES packet instead of the > > >>>>>>> > > >>>>>>> truncated > > >>>>>>>>>> > > >>>>>>>>>> version fixes the problem. > > >>>>>>>>>> > > >>>>>>>>>> I think this patch may have been one of the stabs at fixing > the > > KCQ > > >>>>>>>>>> suspend/resume errors. I *think* it may no longer be needed > > if that > > >>>>> > > >>>>> is > > >>>>>>>>>> > > >>>>>>>>>> the case. > > >>>>>>>>>> > > >>>>>>>>>> Sending this mostly as an FYI to get the patch removed from > > the > > >>>>>>> > > >>>>>>> 4.12-wip > > >>>>>>>>>> > > >>>>>>>>>> This reverts commit > > e579f564c333a7eaddf7e12b1b8414410c36e80f. > > >>>>>>>>>> --- > > >>>>>>>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- > > >>>>>>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) > > >>>>>>>>>> > > >>>>>>>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >>>>>>>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >>>>>>>>>> index 2d8d7bb..4c3bf51 100644 > > >>>>>>>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >>>>>>>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >>>>>>>>>> @@ -4647,10 +4647,14 @@ static int > > gfx_v8_0_kiq_kcq_enable(struct > > >>>>>>>>>> amdgpu_device *adev) > > >>>>>>>>>> return r; > > >>>>>>>>>> } > > >>>>>>>>>> /* set resources */ > > >>>>>>>>>> - amdgpu_ring_write(kiq_ring, > > PACKET3(PACKET3_SET_RESOURCES, > > >>>>> > > >>>>> 2)); > > >>>>>>>>>> > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, > > >>>>> > > >>>>> PACKET3(PACKET3_SET_RESOURCES, > > >>>>>>>> > > >>>>>>>> 6)); > > >>>>>>>>>> > > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 > > >>>>>>>>>> queue_type:0 > > >>>>>>>>>> (KIQ) */ > > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue > mask > > lo > > >>>>>>>>>> */ > > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */ > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, > gds > > >>>>>>>>>> heap > > >>>>>>>>>> size:0 */ > > >>>>>>>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { > > >>>>>>>>>> struct amdgpu_ring *ring = > &adev->gfx.compute_ring[i]; > > >>>>>>>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring- > > >mqd_obj); > > >>>>>>>>>> > > >>>>>>>>> This fixes init issues with my polaris board but there's still > a > > >>>>>>>>> clock > > >>>>>>>>> problem (CP is pegged at 100% as read by umr) resulting in the > > GPU > > >>>>>>> > > >>>>>>> clock > > >>>>>>>>> > > >>>>>>>>> staying at 1200MHz the entire time. > > >>>>>>>>> > > >>>>>>>> Yeah I sent this out because I was having KCQ init issues on my > > >>>>>>>> polaris10 card. However, I'm not seeing the CP pegged at 100% as > > you > > >>>>>>>> mentioned. Everything sitting quietly at 0% here. > > >>>>>>> > > >>>>>>> Which firmware are you using? > > >>>>>>> > > >>>>>>> Alex > > >>>>>>> > > >>>>>>>> > > >>>>>>>>> Tom > > >>>>>>>>> _______________________________________________ > > >>>>>>>>> amd-gfx mailing list > > >>>>>>>>> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > >>>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > >>>>>>>> > > >>>>>>>> _______________________________________________ > > >>>>>>>> amd-gfx mailing list > > >>>>>>>> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > >>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > >>>>>>> > > >>>>>>> _______________________________________________ > > >>>>>>> amd-gfx mailing list > > >>>>>>> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > >>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > >>>>>>> > > >>>> > > >> > > >> _______________________________________________ > > >> amd-gfx mailing list > > >> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > [-- Attachment #1.2: Type: text/html, Size: 19999 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <CAFQ_0eHiU=HNCpPA=2+Op0944anFsb1w-=Q3923LXPY02Pia3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" [not found] ` <CAFQ_0eHiU=HNCpPA=2+Op0944anFsb1w-=Q3923LXPY02Pia3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-04-05 16:49 ` Tom St Denis 0 siblings, 0 replies; 14+ messages in thread From: Tom St Denis @ 2017-04-05 16:49 UTC (permalink / raw) To: Andres Rodriguez, Deucher, Alexander Cc: Alex Deucher, Tom St Denis, amd-gfx list On 05/04/17 11:34 AM, Andres Rodriguez wrote: > Hey Tom, > > If it's the same as your old firmware you might be missing an extra > step. I usually just run the kernel 'make install' as that usually take > care of the distro specific quirks. I manually load the module but for sanity I did a make install and it didn't change the rlc/smc versions. Tom > On Apr 5, 2017 9:56 AM, "Deucher, Alexander" <Alexander.Deucher@amd.com > <mailto:Alexander.Deucher@amd.com>> wrote: > > > -----Original Message----- > > From: StDenis, Tom > > Sent: Wednesday, April 05, 2017 9:14 AM > > To: Alex Deucher > > Cc: Andres Rodriguez; Deucher, Alexander; Tom St Denis; amd- > > gfx@lists.freedesktop.org <mailto:gfx@lists.freedesktop.org> > > Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" > > > > On 05/04/17 09:06 AM, Alex Deucher wrote: > > > On Wed, Apr 5, 2017 at 7:30 AM, Tom St Denis > <tom.stdenis@amd.com <mailto:tom.stdenis@amd.com>> > > wrote: > > >> My firmware is > > >> > > >> fw.VCE == .feature==0 .firmware==0x34040300 > > >> fw.UVD == .feature==0 .firmware==0x015b0b00 > > >> fw.MC == .feature==0 .firmware==0x00000000 > > >> fw.ME == .feature==46 .firmware==0x000000a1 > > >> fw.PFP == .feature==46 .firmware==0x000000eb > > >> fw.CE == .feature==46 .firmware==0x00000086 > > >> fw.RLC == .feature==1 .firmware==0x0000009c > > >> fw.MEC == .feature==46 .firmware==0x000002c1 > > >> fw.MEC2 == .feature==46 .firmware==0x000002c1 > > >> fw.SOS == .feature==0 .firmware==0x00000000 > > >> fw.ASD == .feature==0 .firmware==0x00000000 > > >> fw.SMC == .feature==0 .firmware==0x00000000 > > >> fw.SDMA0 == .feature==0 .firmware==0x00000022 > > >> fw.SDMA1 == .feature==0 .firmware==0x00000022 > > >> > > >> It seems like our all-open is behind what he has for SDMA, SMC, > RLC but > > >> ahead for others? Bizarre. > > > > > > Can you try the upstream ucode? That is what Andres is using. > > > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux- > <https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-> > > firmware.git > > > > Copying the tip of master from that to my /lib/firmware/ results > in the > > same firmware versions being loaded. > > > > Same as you or same as Andres? > > Alex > > > > > > > Alex > > > > > >> > > >> Tom > > >> > > >> > > >> On 04/04/17 04:17 PM, Andres Rodriguez wrote: > > >>> > > >>> This should be the the linux-firmware repository @ commit > > >>> 6d3bc8886517d171068fd1263176b8b5c51df204 > > >>> > > >>> I reverted back to that firmware since I didn't want to deal with > > >>> possible bugs when testing my patches. > > >>> > > >>> Regards, > > >>> Andres > > >>> > > >>> On Tue, Apr 4, 2017 at 4:03 PM, Deucher, Alexander > > >>> <Alexander.Deucher@amd.com <mailto:Alexander.Deucher@amd.com>> > wrote: > > >>>>> > > >>>>> -----Original Message----- > > >>>>> From: Andres Rodriguez [mailto:andresx7@gmail.com > <mailto:andresx7@gmail.com>] > > >>>>> Sent: Tuesday, April 04, 2017 4:01 PM > > >>>>> To: Tom St Denis; Deucher, Alexander; StDenis, Tom; amd- > > >>>>> gfx@lists.freedesktop.org <mailto:gfx@lists.freedesktop.org> > > >>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES > > packet" > > >>>>> > > >>>>> This is my info in case that is useful: > > >>>>> > > >>>>> umr.version == ea8e49bb15ed > > >>>>> > > >>>>> fw.VCE == .feature==0 .firmware==0x34040300 > > >>>>> fw.UVD == .feature==0 .firmware==0x014f1000 > > >>>>> fw.MC == .feature==0 .firmware==0x00000000 > > >>>>> fw.ME == .feature==37 .firmware==0x00000094 > > >>>>> fw.PFP == .feature==37 .firmware==0x000000dc > > >>>>> fw.CE == .feature==37 .firmware==0x00000080 > > >>>>> fw.RLC == .feature==1 .firmware==0x0000010e > > >>>>> fw.MEC == .feature==37 .firmware==0x000002a2 > > >>>>> fw.MEC2 == .feature==37 .firmware==0x000002a2 > > >>>>> fw.SOS == .feature==0 .firmware==0x00000000 > > >>>>> fw.ASD == .feature==0 .firmware==0x00000000 > > >>>>> fw.SMC == .feature==0 .firmware==0x00170f00 > > >>>>> fw.SDMA0 == .feature==31 .firmware==0x00000036 > > >>>>> fw.SDMA1 == .feature==0 .firmware==0x00000036 > > >>>>> > > >>>>> asic.instance == 0 > > >>>>> > > >>>>> > > >>>>> gfx.max_shader_engines == 4 > > >>>>> gfx.max_tile_pipes == 8 > > >>>>> gfx.max_cu_per_sh == 9 > > >>>>> gfx.max_sh_per_se == 1 > > >>>>> gfx.max_backends_per_se == 2 > > >>>>> gfx.max_texture_channel_caches == 8 > > >>>>> gfx.max_gprs == 256 > > >>>>> gfx.max_gs_threads == 32 > > >>>>> gfx.max_hw_contexts == 8 > > >>>>> gfx.sc_prim_fifo_size_frontend == 32 > > >>>>> gfx.sc_prim_fifo_size_backend == 256 > > >>>>> gfx.sc_hiz_tile_fifo_size == 48 > > >>>>> gfx.sc_earlyz_tile_fifo_size == 304 > > >>>>> gfx.num_tile_pipes == 8 > > >>>>> gfx.backend_enable_mask == 255 > > >>>>> gfx.mem_max_burst_length_bytes == 256 > > >>>>> gfx.mem_row_size_in_kb == 4 > > >>>>> gfx.shader_engine_tile_size == 32 > > >>>>> gfx.num_gpus == 1 > > >>>>> gfx.multi_gpu_tile_size == 64 > > >>>>> gfx.mc_arb_ramcfg == 24738 > > >>>>> gfx.gb_addr_config == 570494979 > > >>>>> gfx.num_rbs == 8 > > >>>>> gfx.family = 130, Volcanic Islands > > >>>>> gfx.rev_id == 00000001 > > >>>>> gfx.external_rev_id == 00000051 > > >>>>> gfx.cg_flags == 003fffcd > > >>>>> AMD_CG_SUPPORT_GFX_MGCG > > >>>>> AMD_CG_SUPPORT_GFX_CGCG > > >>>>> AMD_CG_SUPPORT_GFX_CGLS > > >>>>> AMD_CG_SUPPORT_GFX_CP_LS > > >>>>> AMD_CG_SUPPORT_GFX_RLC_LS > > >>>>> AMD_CG_SUPPORT_MC_LS > > >>>>> AMD_CG_SUPPORT_MC_MGCG > > >>>>> AMD_CG_SUPPORT_SDMA_LS > > >>>>> AMD_CG_SUPPORT_SDMA_MGCG > > >>>>> AMD_CG_SUPPORT_BIF_LS > > >>>>> AMD_CG_SUPPORT_UVD_MGCG > > >>>>> AMD_CG_SUPPORT_VCE_MGCG > > >>>>> AMD_CG_SUPPORT_HDP_LS > > >>>>> AMD_CG_SUPPORT_HDP_MGCG > > >>>>> AMD_CG_SUPPORT_ROM_MGCG > > >>>>> gfx.pg_flags == 00000000 > > >>>> > > >>>> > > >>>> Is this the stock firmware from upstream or the stuff I > pointed you to > > >>>> yesterday on my fdo site? > > >>>> > > >>>> Alex > > >>>> > > >>>>> > > >>>>> Regards, > > >>>>> Andres > > >>>>> > > >>>>> On 2017-04-04 03:59 PM, Tom St Denis wrote: > > >>>>>> > > >>>>>> I'm using the latest from all open (our internal FC24 > repo). I'll > > >>>>>> fetch > > >>>>>> the exact later with "umr -c". > > >>>>>> > > >>>>>> Tom > > >>>>>> > > >>>>>> On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander > > >>>>> > > >>>>> <Alexander.Deucher@amd.com <mailto:Alexander.Deucher@amd.com>> > > >>>>>> > > >>>>>> wrote: > > >>>>>> > > >>>>>>>> -----Original Message----- > > >>>>>>>> From: amd-gfx > [mailto:amd-gfx-bounces@lists.freedesktop.org > <mailto:amd-gfx-bounces@lists.freedesktop.org>] > > On > > >>>>> > > >>>>> Behalf > > >>>>>>>> > > >>>>>>>> Of Andres Rodriguez > > >>>>>>>> Sent: Tuesday, April 04, 2017 3:39 PM > > >>>>>>>> To: StDenis, Tom; amd-gfx@lists.freedesktop.org > <mailto:amd-gfx@lists.freedesktop.org> > > >>>>>>>> Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES > > >>>>> > > >>>>> packet" > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> On 2017-04-04 08:27 AM, Tom St Denis wrote: > > >>>>>>>>> > > >>>>>>>>> On 03/04/17 04:25 PM, Andres Rodriguez wrote: > > >>>>>>>>>> > > >>>>>>>>>> Commit e579f56 results in a KCQ initialization error > for polaris10 > > >>>>>>>>>> cards. Providing the full SET_RESOURCES packet instead > of the > > >>>>>>> > > >>>>>>> truncated > > >>>>>>>>>> > > >>>>>>>>>> version fixes the problem. > > >>>>>>>>>> > > >>>>>>>>>> I think this patch may have been one of the stabs at > fixing the > > KCQ > > >>>>>>>>>> suspend/resume errors. I *think* it may no longer be needed > > if that > > >>>>> > > >>>>> is > > >>>>>>>>>> > > >>>>>>>>>> the case. > > >>>>>>>>>> > > >>>>>>>>>> Sending this mostly as an FYI to get the patch removed from > > the > > >>>>>>> > > >>>>>>> 4.12-wip > > >>>>>>>>>> > > >>>>>>>>>> This reverts commit > > e579f564c333a7eaddf7e12b1b8414410c36e80f. > > >>>>>>>>>> --- > > >>>>>>>>>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- > > >>>>>>>>>> 1 file changed, 5 insertions(+), 1 deletion(-) > > >>>>>>>>>> > > >>>>>>>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >>>>>>>>>> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >>>>>>>>>> index 2d8d7bb..4c3bf51 100644 > > >>>>>>>>>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >>>>>>>>>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > > >>>>>>>>>> @@ -4647,10 +4647,14 @@ static int > > gfx_v8_0_kiq_kcq_enable(struct > > >>>>>>>>>> amdgpu_device *adev) > > >>>>>>>>>> return r; > > >>>>>>>>>> } > > >>>>>>>>>> /* set resources */ > > >>>>>>>>>> - amdgpu_ring_write(kiq_ring, > > PACKET3(PACKET3_SET_RESOURCES, > > >>>>> > > >>>>> 2)); > > >>>>>>>>>> > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, > > >>>>> > > >>>>> PACKET3(PACKET3_SET_RESOURCES, > > >>>>>>>> > > >>>>>>>> 6)); > > >>>>>>>>>> > > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 > > >>>>>>>>>> queue_type:0 > > >>>>>>>>>> (KIQ) */ > > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0x000000FF); /* > queue mask > > lo > > >>>>>>>>>> */ > > >>>>>>>>>> amdgpu_ring_write(kiq_ring, 0); /* queue mask > hi */ > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */ > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */ > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */ > > >>>>>>>>>> + amdgpu_ring_write(kiq_ring, 0); /* gds heap > base:0, gds > > >>>>>>>>>> heap > > >>>>>>>>>> size:0 */ > > >>>>>>>>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) { > > >>>>>>>>>> struct amdgpu_ring *ring = > &adev->gfx.compute_ring[i]; > > >>>>>>>>>> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring- > > >mqd_obj); > > >>>>>>>>>> > > >>>>>>>>> This fixes init issues with my polaris board but there's > still a > > >>>>>>>>> clock > > >>>>>>>>> problem (CP is pegged at 100% as read by umr) resulting > in the > > GPU > > >>>>>>> > > >>>>>>> clock > > >>>>>>>>> > > >>>>>>>>> staying at 1200MHz the entire time. > > >>>>>>>>> > > >>>>>>>> Yeah I sent this out because I was having KCQ init issues > on my > > >>>>>>>> polaris10 card. However, I'm not seeing the CP pegged at > 100% as > > you > > >>>>>>>> mentioned. Everything sitting quietly at 0% here. > > >>>>>>> > > >>>>>>> Which firmware are you using? > > >>>>>>> > > >>>>>>> Alex > > >>>>>>> > > >>>>>>>> > > >>>>>>>>> Tom > > >>>>>>>>> _______________________________________________ > > >>>>>>>>> amd-gfx mailing list > > >>>>>>>>> amd-gfx@lists.freedesktop.org > <mailto:amd-gfx@lists.freedesktop.org> > > >>>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > <https://lists.freedesktop.org/mailman/listinfo/amd-gfx> > > >>>>>>>> > > >>>>>>>> _______________________________________________ > > >>>>>>>> amd-gfx mailing list > > >>>>>>>> amd-gfx@lists.freedesktop.org > <mailto:amd-gfx@lists.freedesktop.org> > > >>>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > <https://lists.freedesktop.org/mailman/listinfo/amd-gfx> > > >>>>>>> > > >>>>>>> _______________________________________________ > > >>>>>>> amd-gfx mailing list > > >>>>>>> amd-gfx@lists.freedesktop.org > <mailto:amd-gfx@lists.freedesktop.org> > > >>>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > <https://lists.freedesktop.org/mailman/listinfo/amd-gfx> > > >>>>>>> > > >>>> > > >> > > >> _______________________________________________ > > >> amd-gfx mailing list > > >> amd-gfx@lists.freedesktop.org > <mailto:amd-gfx@lists.freedesktop.org> > > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > <https://lists.freedesktop.org/mailman/listinfo/amd-gfx> > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-04-05 16:49 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-04-03 20:25 [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" Andres Rodriguez [not found] ` <20170403202534.3311-1-andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-04 12:27 ` Tom St Denis [not found] ` <3ae98951-f12f-3860-e10a-00e0be2b9e84-5C7GfCeVMHo@public.gmane.org> 2017-04-04 19:39 ` Andres Rodriguez [not found] ` <d4fbb81c-be3a-c54a-6d56-17dc4ae27895-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-04 19:46 ` Deucher, Alexander [not found] ` <BN6PR12MB1652D90B12B8A60F1F725AC0F70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-04-04 19:59 ` Tom St Denis [not found] ` <CAAzXoR+TJHk1Eo_h0HJGg-KGfON-uLWE7e27Q-95PXyBY3zcOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-04 20:01 ` Andres Rodriguez [not found] ` <32c1f7e8-54a4-8db7-c764-8bae55bf3f94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-04 20:03 ` Deucher, Alexander [not found] ` <BN6PR12MB1652C9E0D15D794E02FAB2ADF70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-04-04 20:17 ` Andres Rodriguez [not found] ` <CAFQ_0eH8wU1NOfj5TXR+SKWAbFcRqqS4mK-xEFWuSG82V-zozg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-05 11:30 ` Tom St Denis [not found] ` <08b6ee6a-f201-272c-d812-7f7404a51863-5C7GfCeVMHo@public.gmane.org> 2017-04-05 13:06 ` Alex Deucher [not found] ` <CADnq5_O7KZy08QQ2P0mqGMkOdFtFYRh5jrJx_Gfm5Ahxvse8Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-05 13:14 ` Tom St Denis [not found] ` <682c9bb0-19d6-f64a-84d1-73dd77824aa4-5C7GfCeVMHo@public.gmane.org> 2017-04-05 13:56 ` Deucher, Alexander [not found] ` <BN6PR12MB1652D439580DE76681B0EFA7F70A0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-04-05 15:34 ` Andres Rodriguez [not found] ` <CAFQ_0eHiU=HNCpPA=2+Op0944anFsb1w-=Q3923LXPY02Pia3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-05 16:49 ` Tom St Denis
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.