From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA51C433DF for ; Fri, 14 Aug 2020 08:44:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 41D0E2074D for ; Fri, 14 Aug 2020 08:44:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D0E2074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8FC826B0008; Fri, 14 Aug 2020 04:44:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8863B6B000A; Fri, 14 Aug 2020 04:44:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7264A6B000C; Fri, 14 Aug 2020 04:44:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 56FF26B0008 for ; Fri, 14 Aug 2020 04:44:25 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1BA41180AD804 for ; Fri, 14 Aug 2020 08:44:25 +0000 (UTC) X-FDA: 77148537690.03.map24_0000a5626ffb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id E7F9C28A4E8 for ; Fri, 14 Aug 2020 08:44:24 +0000 (UTC) X-HE-Tag: map24_0000a5626ffb X-Filterd-Recvd-Size: 4177 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Aug 2020 08:44:24 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B260A1063; Fri, 14 Aug 2020 01:44:23 -0700 (PDT) Received: from [10.163.65.227] (unknown [10.163.65.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6E833F22E; Fri, 14 Aug 2020 01:44:21 -0700 (PDT) Subject: Re: [PATCH 14/16] debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64 To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org References: <20200812063358.369514-1-aneesh.kumar@linux.ibm.com> <20200812063358.369514-14-aneesh.kumar@linux.ibm.com> <83766a01-6ffb-798c-c5b9-46b2d672f618@arm.com> <535169b9-f4f0-57ce-0c2b-30afc237d4bd@linux.ibm.com> From: Anshuman Khandual Message-ID: <08c63a65-cd3f-73f3-1698-5e60f398fbad@arm.com> Date: Fri, 14 Aug 2020 14:13:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <535169b9-f4f0-57ce-0c2b-30afc237d4bd@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: E7F9C28A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/12/2020 07:22 PM, Aneesh Kumar K.V wrote: > On 8/12/20 7:04 PM, Anshuman Khandual wrote: >> >> >> On 08/12/2020 06:46 PM, Aneesh Kumar K.V wrote: >>> On 8/12/20 6:33 PM, Anshuman Khandual wrote: >>>> >>>> >>>> On 08/12/2020 12:03 PM, Aneesh Kumar K.V wrote: >>>>> The seems to be missing quite a lot of details w.r.t allocating >>>>> the correct pgtable_t page (huge_pte_alloc()), holding the right >>>>> lock (huge_pte_lock()) etc. The vma used is also not a hugetlb VMA. >>>>> >>>>> ppc64 do have runtime checks within CONFIG_DEBUG_VM for most of the= se. >>>>> Hence disable the test on ppc64. >>>> >>>> This test is free from any platform specific #ifdefs which should >>>> never be broken. If hugetlb_advanced_tests() does not work or is >>>> not detailed enough for ppc64, then it would be great if you could >>>> suggest some improvements so that it works for all enabled platforms= . >>>> >>>> >>> >>> As mentioned the test is broken. For hugetlb, the pgtable_t pages sho= uld be allocated by huge_pte_alloc(). We need to hold huget_pte_lock() be= fore=C2=A0 updating huge tlb pte. That takes hugepage size, which is most= ly derived out of vma. Hence vma need to be a hugetlb vma. Some of the fu= nctions also depend on hstate. Also we should use set_huge_pte_at() when = setting up hugetlb pte entries. I was tempted to remove that test complet= ely marking it broken. But avoided that by marking it broken on only PPC6= 4. >> >> The test is not broken, hugetlb helpers on multiple platforms dont com= plain about >> this at all. The tests here emulate 'enough' MM objects required for t= he helpers >> on enabled platforms, to perform the primary task i.e page table trans= formation it >> is expected to do. The test does not claim to emulate a perfect MM env= ironment for >> a given subsystem's (like HugeTLB) arch helpers. Now in this case, the= MM objects >> being emulated for the HugeTLB advanced tests does not seem to be suff= icient for >> ppc64 but it can be improved. But that does not mean it is broken in i= t's current >> form for other platforms. >> >=20 > There is nothing ppc64 specific here. It is just that we have CONFIG_DE= BUG_VM based checks for different possibly wrong usages of these function= s. This was done because we have different page sizes, two different tran= slations to support and we want to avoid any wrong usage. IMHO expecting = hugetlb page table helpers to work with a non hugetlb VMA and=C2=A0 witho= ut holding hugeTLB pte lock is a clear violation of hugetlb interface. Do you have a modified version of the test with HugeTLB marked VMA and wi= th pte lock held, which works on ppc664 ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB10C433DF for ; Fri, 14 Aug 2020 08:46:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5776207DA for ; Fri, 14 Aug 2020 08:46:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5776207DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BScVZ5JsNzDqkq for ; Fri, 14 Aug 2020 18:46:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=anshuman.khandual@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4BScSB48fPzDqkT for ; Fri, 14 Aug 2020 18:44:25 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B260A1063; Fri, 14 Aug 2020 01:44:23 -0700 (PDT) Received: from [10.163.65.227] (unknown [10.163.65.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6E833F22E; Fri, 14 Aug 2020 01:44:21 -0700 (PDT) Subject: Re: [PATCH 14/16] debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64 To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org References: <20200812063358.369514-1-aneesh.kumar@linux.ibm.com> <20200812063358.369514-14-aneesh.kumar@linux.ibm.com> <83766a01-6ffb-798c-c5b9-46b2d672f618@arm.com> <535169b9-f4f0-57ce-0c2b-30afc237d4bd@linux.ibm.com> From: Anshuman Khandual Message-ID: <08c63a65-cd3f-73f3-1698-5e60f398fbad@arm.com> Date: Fri, 14 Aug 2020 14:13:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <535169b9-f4f0-57ce-0c2b-30afc237d4bd@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 08/12/2020 07:22 PM, Aneesh Kumar K.V wrote: > On 8/12/20 7:04 PM, Anshuman Khandual wrote: >> >> >> On 08/12/2020 06:46 PM, Aneesh Kumar K.V wrote: >>> On 8/12/20 6:33 PM, Anshuman Khandual wrote: >>>> >>>> >>>> On 08/12/2020 12:03 PM, Aneesh Kumar K.V wrote: >>>>> The seems to be missing quite a lot of details w.r.t allocating >>>>> the correct pgtable_t page (huge_pte_alloc()), holding the right >>>>> lock (huge_pte_lock()) etc. The vma used is also not a hugetlb VMA. >>>>> >>>>> ppc64 do have runtime checks within CONFIG_DEBUG_VM for most of these. >>>>> Hence disable the test on ppc64. >>>> >>>> This test is free from any platform specific #ifdefs which should >>>> never be broken. If hugetlb_advanced_tests() does not work or is >>>> not detailed enough for ppc64, then it would be great if you could >>>> suggest some improvements so that it works for all enabled platforms. >>>> >>>> >>> >>> As mentioned the test is broken. For hugetlb, the pgtable_t pages should be allocated by huge_pte_alloc(). We need to hold huget_pte_lock() before  updating huge tlb pte. That takes hugepage size, which is mostly derived out of vma. Hence vma need to be a hugetlb vma. Some of the functions also depend on hstate. Also we should use set_huge_pte_at() when setting up hugetlb pte entries. I was tempted to remove that test completely marking it broken. But avoided that by marking it broken on only PPC64. >> >> The test is not broken, hugetlb helpers on multiple platforms dont complain about >> this at all. The tests here emulate 'enough' MM objects required for the helpers >> on enabled platforms, to perform the primary task i.e page table transformation it >> is expected to do. The test does not claim to emulate a perfect MM environment for >> a given subsystem's (like HugeTLB) arch helpers. Now in this case, the MM objects >> being emulated for the HugeTLB advanced tests does not seem to be sufficient for >> ppc64 but it can be improved. But that does not mean it is broken in it's current >> form for other platforms. >> > > There is nothing ppc64 specific here. It is just that we have CONFIG_DEBUG_VM based checks for different possibly wrong usages of these functions. This was done because we have different page sizes, two different translations to support and we want to avoid any wrong usage. IMHO expecting hugetlb page table helpers to work with a non hugetlb VMA and  without holding hugeTLB pte lock is a clear violation of hugetlb interface. Do you have a modified version of the test with HugeTLB marked VMA and with pte lock held, which works on ppc664 ?