From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E676EC433EF for ; Fri, 8 Jul 2022 13:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238026AbiGHNWQ (ORCPT ); Fri, 8 Jul 2022 09:22:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231890AbiGHNWP (ORCPT ); Fri, 8 Jul 2022 09:22:15 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E3102A425 for ; Fri, 8 Jul 2022 06:22:15 -0700 (PDT) Received: from [192.168.178.53] (82-71-8-225.dsl.in-addr.zen.co.uk [82.71.8.225]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbeckett) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5B56E66019BB; Fri, 8 Jul 2022 14:22:13 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657286533; bh=92AcTQpvwBEXxmF+03+cU6InX535v6B3nuv1srwuTJc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cJ3qTgIOLPkH6HJPkiSp3VQ4y4td8Il5ll0ISHiuaA4Mzzhc/O+IJWQqmU7h18YNE FcJGyeTdmRBGNavuRPIGuDQuuOkPpfRqpPsz+B88/CVV4G6oTRVV1ic++zhPkNaapC 3e7s91DM4cP2TFKgWt9G9bDTkDroMjC+WO5t793gyIo71nCTjIoCvnnOSa1WaN9dbc hjI2vguW9VLY+2bl0SiphbjTAgIZJuCkOZIDTjpXmw4RUecrKpL7F26LnTB0i99geO DWahEEivn+V3BSFxwfSxsemoYQ7Fb0a/lbuN/Sv5VLutJSFY5tptPig4axjgCnnyGu ZyvxKxhHV696Q== Message-ID: <08d33248-be80-15ab-d245-a6e23fe55423@collabora.com> Date: Fri, 8 Jul 2022 14:22:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v10 04/11] drm/i915/gem: selftest should not attempt mmap of private regions Content-Language: en-US To: Matthew Auld , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Cc: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , kernel@collabora.com, linux-kernel@vger.kernel.org References: <20220707200230.1657555-1-bob.beckett@collabora.com> <20220707200230.1657555-5-bob.beckett@collabora.com> <6e387f90-dce3-486d-83e9-26a975777265@intel.com> From: Robert Beckett In-Reply-To: <6e387f90-dce3-486d-83e9-26a975777265@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2022 08:53, Matthew Auld wrote: > On 07/07/2022 21:02, Robert Beckett wrote: >> During testing make can_mmap consider whether the region is private. > > Do we still need this with: 938d2fd17d17 ("drm/i915/selftests: skip the > mman tests for stolen") ? huh, I guess not. That wasn't in my tree. I guess I should rebase. Looking at it, my patch would have been preferable initially I think. Each location of the additional checks in that patch first call cam_mmap(), which I think is the most appropriate place to make the decision. I could do a replacement patch that reverts that one if preferred, or we can leave it as is and I will drop this patch. > >> >> Signed-off-by: Robert Beckett >> Reviewed-by: Thomas Hellström >> --- >>   drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c >> b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c >> index 5bc93a1ce3e3..76181e28c75e 100644 >> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c >> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c >> @@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object >> *obj, enum i915_mmap_type type) >>       struct drm_i915_private *i915 = to_i915(obj->base.dev); >>       bool no_map; >> +    if (obj->mm.region && obj->mm.region->private) >> +        return false; >> + >>       if (obj->ops->mmap_offset) >>           return type == I915_MMAP_TYPE_FIXED; >>       else if (type == I915_MMAP_TYPE_FIXED) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC95CC43334 for ; Fri, 8 Jul 2022 13:22:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F6B1113BA0; Fri, 8 Jul 2022 13:22:17 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D5D0113B99; Fri, 8 Jul 2022 13:22:15 +0000 (UTC) Received: from [192.168.178.53] (82-71-8-225.dsl.in-addr.zen.co.uk [82.71.8.225]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbeckett) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5B56E66019BB; Fri, 8 Jul 2022 14:22:13 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657286533; bh=92AcTQpvwBEXxmF+03+cU6InX535v6B3nuv1srwuTJc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cJ3qTgIOLPkH6HJPkiSp3VQ4y4td8Il5ll0ISHiuaA4Mzzhc/O+IJWQqmU7h18YNE FcJGyeTdmRBGNavuRPIGuDQuuOkPpfRqpPsz+B88/CVV4G6oTRVV1ic++zhPkNaapC 3e7s91DM4cP2TFKgWt9G9bDTkDroMjC+WO5t793gyIo71nCTjIoCvnnOSa1WaN9dbc hjI2vguW9VLY+2bl0SiphbjTAgIZJuCkOZIDTjpXmw4RUecrKpL7F26LnTB0i99geO DWahEEivn+V3BSFxwfSxsemoYQ7Fb0a/lbuN/Sv5VLutJSFY5tptPig4axjgCnnyGu ZyvxKxhHV696Q== Message-ID: <08d33248-be80-15ab-d245-a6e23fe55423@collabora.com> Date: Fri, 8 Jul 2022 14:22:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Matthew Auld , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter References: <20220707200230.1657555-1-bob.beckett@collabora.com> <20220707200230.1657555-5-bob.beckett@collabora.com> <6e387f90-dce3-486d-83e9-26a975777265@intel.com> From: Robert Beckett In-Reply-To: <6e387f90-dce3-486d-83e9-26a975777265@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v10 04/11] drm/i915/gem: selftest should not attempt mmap of private regions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , kernel@collabora.com, linux-kernel@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 08/07/2022 08:53, Matthew Auld wrote: > On 07/07/2022 21:02, Robert Beckett wrote: >> During testing make can_mmap consider whether the region is private. > > Do we still need this with: 938d2fd17d17 ("drm/i915/selftests: skip the > mman tests for stolen") ? huh, I guess not. That wasn't in my tree. I guess I should rebase. Looking at it, my patch would have been preferable initially I think. Each location of the additional checks in that patch first call cam_mmap(), which I think is the most appropriate place to make the decision. I could do a replacement patch that reverts that one if preferred, or we can leave it as is and I will drop this patch. > >> >> Signed-off-by: Robert Beckett >> Reviewed-by: Thomas Hellström >> --- >>   drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c >> b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c >> index 5bc93a1ce3e3..76181e28c75e 100644 >> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c >> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c >> @@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object >> *obj, enum i915_mmap_type type) >>       struct drm_i915_private *i915 = to_i915(obj->base.dev); >>       bool no_map; >> +    if (obj->mm.region && obj->mm.region->private) >> +        return false; >> + >>       if (obj->ops->mmap_offset) >>           return type == I915_MMAP_TYPE_FIXED; >>       else if (type == I915_MMAP_TYPE_FIXED)