All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
	Maxim Levitsky <mlevitsk@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: disable on 32-bit unless CONFIG_BROKEN
Date: Thu, 29 Sep 2022 15:26:03 +0200	[thread overview]
Message-ID: <08dab49f-9ca4-4978-4482-1815cf168e74@redhat.com> (raw)
In-Reply-To: <YzSKhUEg3L1eMKOR@google.com>

On 9/28/22 19:55, Sean Christopherson wrote:
>> As far as my opinion goes I do volunteer to test this code more often,
>> and I do not want to see the 32 bit KVM support be removed*yet*.
>
> Yeah, I 100% agree that it shouldn't be removed until we have equivalent test
> coverage.  But I do think it should an "off-by-default" sort of thing.  Maybe
> BROKEN is the wrong dependency though?  E.g. would EXPERT be a better option?

Yeah, maybe EXPERT is better but I'm not sure of the equivalent test 
coverage.  32-bit VMX/SVM kvm-unit-tests are surely a good idea, but 
what's wrong with booting an older guest?

Paolo


  reply	other threads:[~2022-09-29 13:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 16:51 [PATCH] KVM: x86: disable on 32-bit unless CONFIG_BROKEN Paolo Bonzini
2022-09-27 17:07 ` Sean Christopherson
2022-09-28  7:10   ` Maxim Levitsky
2022-09-28  9:55     ` Paolo Bonzini
2022-09-28 16:12       ` Sean Christopherson
2022-09-28 17:43         ` Maxim Levitsky
2022-09-28 17:44         ` Maxim Levitsky
2022-09-28 17:55           ` Sean Christopherson
2022-09-29 13:26             ` Paolo Bonzini [this message]
2022-09-29 13:52               ` Maxim Levitsky
2022-09-29 15:07                 ` Paolo Bonzini
2023-02-17 19:36                 ` Thomas Huth
2023-02-22 22:27                   ` Sean Christopherson
2023-02-23  7:01                     ` Thomas Huth
2023-02-23  8:33                       ` Maxim Levitsky
2023-02-23 22:10                         ` Sean Christopherson
2023-02-24  6:28                           ` Thomas Huth
2022-09-28 10:04   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08dab49f-9ca4-4978-4482-1815cf168e74@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlevitsk@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.