From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Greg Kurz" <groug@kaod.org>
Subject: Re: [Qemu-devel] [PATCH] 9p: simplify source file selection
Date: Thu, 25 Jul 2019 13:22:53 +0200 [thread overview]
Message-ID: <08e92514-c78a-da87-5ae9-d0da78d5013f@redhat.com> (raw)
In-Reply-To: <821f0761-a159-3cab-7608-ff09705ee4c1@redhat.com>
On 7/25/19 12:29 PM, Paolo Bonzini wrote:
> On 25/07/19 12:21, Peter Maydell wrote:
>
>> Patch definitely looks like a good idea, though -- those
>> nested land/lor calls are pretty ugly :-)
>
> Yeah, FWIW this patch came out of Meson conversion, where the sourceset
> mechanism supports "and", "nand" and "or" very well but has issues with
> "nor". While I'm open to adding "nor" if it is really needed, it seems
> to me that in general we should not transpose our Make mess to Meson,
> and rely on Kconfig as the better tool for this kind of job.
Agreed, good idea.
next prev parent reply other threads:[~2019-07-25 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 10:18 [Qemu-devel] [PATCH] 9p: simplify source file selection Paolo Bonzini
2019-07-25 10:21 ` Peter Maydell
2019-07-25 10:29 ` Paolo Bonzini
2019-07-25 11:22 ` Philippe Mathieu-Daudé [this message]
2019-07-25 10:52 ` Greg Kurz
2019-07-25 14:15 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08e92514-c78a-da87-5ae9-d0da78d5013f@redhat.com \
--to=philmd@redhat.com \
--cc=groug@kaod.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.